fernando/luos
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merged in bugfix/PMCORE-2994 (pull request #7935)

Browse Source 
PMCORE-2994 Complete the phpunit test for "SqlBlacklist" class.

Approved-by: Paula Quispe
This commit is contained in:
Roly Rudy Gutierrez Pinto
2021-05-26 15:08:29 +00:00
committed by Paula Quispe
parent 9e57f97b34 7a8c9135f4
commit e1b969a9e5
2 changed files with 122 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

120
tests/unit/workflow/engine/src/ProcessMaker/Validation/SqlBlacklistTest.php Normal file
View File

@@ -0,0 +1,120 @@
<?php
namespace Tests\unit\workflow\engine\src\ProcessMaker\Validation;
use Exception;
use ProcessMaker\Validation\SqlBlacklist;
use Tests\TestCase;
class SqlBlacklistTest extends TestCase
{
/**
* Property $sqlBlacklist
* @var object
*/
private $sqlBlacklist;
/**
* Property $content.
* @var string
*/
private $content;
/**
* Method setUp.
*/
public function setUp()
{
parent::setUp();
$this->content = "";
$path = PATH_CONFIG . 'execute-query-blacklist.ini';
if (file_exists($path)) {
$this->content = file_get_contents($path);
}
}
/**
* Method tearDown.
*/
public function tearDown()
{
parent::tearDown();
$path = PATH_CONFIG . 'execute-query-blacklist.ini';
if (file_exists($path)) {
file_put_contents($path, $this->content);
}
}
/**
* This test the getConfigValues method.
* @test
* @covers \ProcessMaker\Validation\SqlBlacklist::getConfigValues()
*/
public function it_should_test_getConfigValues_method()
{
$this->sqlBlacklist = new SqlBlacklist();
$result = $this->sqlBlacklist->getConfigValues();
//asserts
$this->assertArrayHasKey('tables', $result);
$this->assertArrayHasKey('statements', $result);
$this->assertArrayHasKey('pmtables', $result);
}
/**
* This test the validate method when restricted system tables.
* @test
* @covers \ProcessMaker\Validation\SqlBlacklist::validate()
*/
public function it_should_test_validate_method_when_restricted_system_tables()
{
//assert exception
$this->expectException(Exception::class);
$sql = "INSERT INTO APPLICATION (c1,c2,c3) values('', '', '')";
$this->sqlBlacklist = new SqlBlacklist($sql);
$this->sqlBlacklist->validate();
}
/**
* This test the validate method when restricted queries.
* @test
* @covers \ProcessMaker\Validation\SqlBlacklist::validate()
*/
public function it_should_test_validate_method_when_restricted_queries()
{
//assert exception
$this->expectException(Exception::class);
$path = PATH_CONFIG . 'execute-query-blacklist.ini';
$content = ""
. "queries = \"INSERT|UPDATE|REPLACE|DELETE|SHOW\"\n\n"
. "pmtables = \"PMT_TEST\"\n";
file_put_contents($path, $content);
$sql = "SHOW tables";
$this->sqlBlacklist = new SqlBlacklist($sql);
$this->sqlBlacklist->validate();
}
/**
* This test the validate method when restricted pmtables.
* @test
* @covers \ProcessMaker\Validation\SqlBlacklist::validate()
*/
public function it_should_test_validate_method_when_restricted_pmtables()
{
//assert exception
$this->expectException(Exception::class);
$path = PATH_CONFIG . 'execute-query-blacklist.ini';
$content = ""
. "queries = \"INSERT|UPDATE|REPLACE|DELETE|SHOW\"\n\n"
. "pmtables = \"PMT_TEST\"\n";
file_put_contents($path, $content);
$sql = "INSERT INTO PMT_TEST (c1,c2,c3) values('', '', '')";
$this->sqlBlacklist = new SqlBlacklist($sql);
$this->sqlBlacklist->validate();
}
}

4
workflow/engine/controllers/InstallerModule.php
View File

@@ -730,9 +730,9 @@ class InstallerModule extends Controller
$dbText .= sprintf(" define ('DB_REPORT_PASS', '%s' );\n", $wfPass);
$requestFlag = $_REQUEST['PARTNER_FLAG'];
if (defined('PARTNER_FLAG') || isset($requestFlag])) {
if (defined('PARTNER_FLAG') || isset($requestFlag)) {
$dbText .= "\n";
$dbText .= " (define('PARTNER_FLAG', " . (defined('PARTNER_FLAG') ? PARTNER_FLAG : isset(requestFlag)) ? $requestFlag : 'false') . ");\n";
$dbText .= " define ('PARTNER_FLAG', " . (defined('PARTNER_FLAG') ? PARTNER_FLAG : (isset($requestFlag) ? $requestFlag : 'false') ) . ");\n";
if (!empty($this->systemName)) {
$dbText .= " define ('SYSTEM_NAME', '" . $this->systemName . "');\n";
}