fernando/luos
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PMCORE-1349 [19511] Multiple file fields dont work with Action By Email

Browse Source
This commit is contained in:
Roly Rudy Gutierrez Pinto
2020-06-30 11:23:41 -04:00
parent 78228cfbfd
commit dbc0465174
8 changed files with 449 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
database/factories/AppDocumentFactory.php Normal file
View File

@@ -0,0 +1,41 @@
<?php
use Faker\Generator as Faker;
$factory->define(\ProcessMaker\Model\AppDocument::class, function (Faker $faker) {
$user = factory(\ProcessMaker\Model\User::class)->create();
$process = factory(\ProcessMaker\Model\Process::class)->create();
$task = factory(\ProcessMaker\Model\Task::class)->create([
'PRO_UID' => $process->PRO_UID,
'PRO_ID' => $process->PRO_ID
]);
$application = factory(\ProcessMaker\Model\Application::class)->create([
'PRO_UID' => $process->PRO_UID,
'APP_INIT_USER' => $user->USR_UID,
'APP_CUR_USER' => $user->USR_UID
]);
return [
'APP_DOC_UID' => G::generateUniqueID(),
'APP_DOC_FILENAME' => $faker->name . '.' . $faker->fileExtension,
'APP_DOC_TITLE' => $faker->title,
'APP_DOC_COMMENT' => '',
'DOC_VERSION' => 1,
'APP_UID' => $application->APP_UID,
'DEL_INDEX' => 1,
'DOC_UID' => -1,
'DOC_ID' => 0,
'USR_UID' => $user->USR_UID,
'APP_DOC_TYPE' => 'ATTACHED',
'APP_DOC_CREATE_DATE' => $faker->dateTime(),
'APP_DOC_INDEX' => 1,
'FOLDER_UID' => '',
'APP_DOC_PLUGIN' => '',
'APP_DOC_TAGS' => null,
'APP_DOC_STATUS' => 'ACTIVE',
'APP_DOC_STATUS_DATE' => '',
'APP_DOC_FIELDNAME' => '',
'APP_DOC_DRIVE_DOWNLOAD' => 'a:0:{}',
'SYNC_WITH_DRIVE' => 'UNSYNCHRONIZED',
'SYNC_PERMISSIONS' => null
];
});

69
tests/unit/workflow/engine/methods/cases/CasesShowDocumentTest.php Normal file
View File

@@ -0,0 +1,69 @@
<?php
namespace Tests\unit\workflow\engine\methods\cases;
use G;
use ProcessMaker\Model\AppDocument;
use RBAC;
use Tests\TestCase;
class CasesShowDocumentTest extends TestCase
{
/**
* Setup method.
*/
public function setUp()
{
parent::setUp();
if (!defined('PATH_DOCUMENT')) {
define('PATH_DOCUMENT', PATH_DB . config('system.workspace') . PATH_SEP . 'files' . PATH_SEP);
}
}
/**
* This test verifies the download link of the uploaded file content.
* @test
*/
public function it_should_test_link_cases_show_document()
{
global $RBAC;
$RBAC = RBAC::getSingleton();
$RBAC->initRBAC();
$appDocument = factory(AppDocument::class)->create([
'APP_DOC_FILENAME' => 'text.txt'
]);
$_GET['a'] = $appDocument->APP_DOC_UID;
$_GET['v'] = '1';
$path = G::getPathFromUID($appDocument->APP_UID);
$file = G::getPathFromFileUID($appDocument->APP_UID, $appDocument->APP_DOC_UID);
$realPath = PATH_DOCUMENT . $path . '/' . $file[0] . $file[1] . '_' . 1 . '.txt';
$dirs = explode('/', $realPath);
$filename = array_pop($dirs);
$path = '';
foreach ($dirs as $value) {
if (empty($value)) {
continue;
}
$path = $path . PATH_SEP . $value;
if (!file_exists($path)) {
mkdir($path);
}
}
$expected = 'test';
file_put_contents($realPath, $expected);
$_SERVER['HTTP_USER_AGENT'] = '';
//assert file content
ob_start();
$fileName = PATH_METHODS . 'cases/cases_ShowDocument.php';
require_once $fileName;
$content = ob_get_contents();
ob_end_clean();
$this->assertEquals($expected, $content);
}
}

83
tests/unit/workflow/engine/methods/services/ActionsByEmailDataFormTest.php Normal file
View File

@@ -0,0 +1,83 @@
<?php
namespace Tests\unit\workflow\engine\methods\services;
use Carbon\Carbon;
use G;
use Illuminate\Support\Facades\Cache;
use PmLicenseManager;
use Tests\TestCase;
class ActionsByEmailDataFormTest extends TestCase
{
/**
* Setup method.
*/
public function setUp()
{
parent::setUp();
if (!defined('URL_KEY')) {
define('URL_KEY', 'c0l0s40pt1mu59r1m3');
}
$path = PATH_TRUNK . 'shared' . PATH_SEP . 'compiled';
if (!file_exists($path)) {
mkdir($path);
}
$path = $path . PATH_SEP . 'smarty';
if (!file_exists($path)) {
mkdir($path);
}
$path = $path . PATH_SEP . 'c';
if (!file_exists($path)) {
mkdir($path);
}
if (!defined('PATH_GULLIVER_HOME')) {
define("PATH_GULLIVER_HOME", PATH_TRUNK . "gulliver" . PATH_SEP);
}
if (!defined('PATH_TEMPLATE')) {
define("PATH_TEMPLATE", PATH_GULLIVER_HOME . "templates" . PATH_SEP);
}
}
/**
* This test verify the form Action By Email build.
* @test
*/
public function it_should_test_view_action_by_email_with_time_zone()
{
$process = factory(\ProcessMaker\Model\Process::class)->create();
$pathData = PATH_TRUNK . "tests/resources/dynaform1.json";
$content = file_get_contents($pathData);
$dynaform = factory(\ProcessMaker\Model\Dynaform::class)->create([
'PRO_UID' => $process->PRO_UID,
'DYN_CONTENT' => $content
]);
$delegation = factory(\ProcessMaker\Model\Delegation::class)->state('closed')->create([
'PRO_UID' => $process->PRO_UID
]);
global $RBAC;
$_GET["APP_UID"] = G::encrypt($delegation->APP_UID, URL_KEY);
$_GET["DEL_INDEX"] = G::encrypt($delegation->DEL_INDEX, URL_KEY);
$_GET["DYN_UID"] = G::encrypt($dynaform->DYN_UID, URL_KEY);
$_GET["ABER"] = G::encrypt($delegation->APP_UID, URL_KEY);
$_GET["BROWSER_TIME_ZONE_OFFSET"] = "-14400";
$_REQUEST = $_GET;
$cached = [
'zLhSk5TeEQrNFI2RXFEVktyUGpnczV1WEJNWVp6cjYxbTU3R29mVXVZNWhZQT0=' => true
];
Cache::put(PmLicenseManager::CACHE_KEY . '.' . config("system.workspace"), $cached, Carbon::now()->addDay(1));
ob_start();
$fileName = PATH_METHODS . 'services/ActionsByEmailDataForm.php';
require_once $fileName;
$content = ob_get_contents();
ob_end_clean();
$this->assertNotEmpty($content);
$this->assertContains('ID_ABE_FORM_ALREADY_FILLED', $content);
}
}

216
tests/unit/workflow/engine/src/ProcessMaker/Services/Api/CasesTest.php Normal file
View File

@@ -0,0 +1,216 @@
<?php
namespace Tests\unit\workflow\engine\src\ProcessMaker\Services\Api;
use Luracast\Restler\Data\ApiMethodInfo;
use Luracast\Restler\Defaults;
use Luracast\Restler\HumanReadableCache;
use Luracast\Restler\RestException;
use Maveriks\Extension\Restler;
use ProcessMaker\Services\Api\Cases;
use RBAC;
use ReflectionClass;
use Tests\TestCase;
class CasesTest extends TestCase
{
/**
* Initialize Rest API.
* @param string $userUid
* @return Restler
*/
private function initializeRestApi(string $userUid)
{
//server
$reflection = new ReflectionClass('\ProcessMaker\Services\OAuth2\Server');
$reflectionPropertyUserId = $reflection->getProperty('userId');
$reflectionPropertyUserId->setAccessible(true);
$reflectionPropertyUserId->setValue($userUid);
$reflectionPropertyDSN = $reflection->getProperty('dsn');
$reflectionPropertyDSN->setAccessible(true);
$reflectionPropertyDSN->setValue('mysql:host=' . env('DB_HOST') . ';dbname=' . env('DB_DATABASE'));
$reflectionPropertyUserName = $reflection->getProperty('dbUser');
$reflectionPropertyUserName->setAccessible(true);
$reflectionPropertyUserName->setValue(env('DB_USERNAME'));
$reflectionPropertyPassword = $reflection->getProperty('dbPassword');
$reflectionPropertyPassword->setAccessible(true);
$reflectionPropertyPassword->setValue(env('DB_PASSWORD'));
//application
Defaults::$cacheDirectory = PATH_DB . config('system.workspace') . PATH_SEP;
HumanReadableCache::$cacheDir = PATH_DB . config('system.workspace') . PATH_SEP;
$rest = new Restler(true);
$rest->setFlagMultipart(false);
$rest->setAPIVersion('1.0');
$rest->addAuthenticationClass('ProcessMaker\\Services\\OAuth2\\Server', '');
$rest->addAuthenticationClass('ProcessMaker\\Policies\\AccessControl');
$rest->addAuthenticationClass('ProcessMaker\\Policies\\ControlUnderUpdating');
$rest->apiMethodInfo = new ApiMethodInfo();
return $rest;
}
/**
* This test verify isAllowed method expecting RestException.
* @test
* @covers ProcessMaker\Services\Api\Cases::__isAllowed
*/
public function it_should_test_isAllowed_method_try_exception()
{
$user = factory(\ProcessMaker\Model\User::class)->create();
$rest = $this->initializeRestApi($user->USR_UID);
//assert exception
$this->expectException(RestException::class);
$cases = new Cases();
$cases->parameters = [];
$cases->__isAllowed();
}
/**
* This test verify isAllowed method doGetCaseVariables option.
* @test
* @covers ProcessMaker\Services\Api\Cases::__isAllowed
*/
public function it_should_test_isAllowed_method_doGetCaseVariables_option()
{
$user = factory(\ProcessMaker\Model\User::class)->create();
$process = factory(\ProcessMaker\Model\Process::class)->create();
$task = factory(\ProcessMaker\Model\Task::class)->create([
'PRO_UID' => $process->PRO_UID,
'PRO_ID' => $process->PRO_ID
]);
$dynaform = factory(\ProcessMaker\Model\Dynaform::class)->create([
'PRO_UID' => $process->PRO_UID
]);
$application = factory(\ProcessMaker\Model\Application::class)->create([
'PRO_UID' => $process->PRO_UID,
'APP_INIT_USER' => $user->USR_UID,
'APP_CUR_USER' => $user->USR_UID
]);
$delegation = factory(\ProcessMaker\Model\Delegation::class)->create([
'APP_UID' => $application->APP_UID,
'APP_NUMBER' => $application->APP_NUMBER,
'DEL_INDEX' => 1,
'PRO_UID' => $process->PRO_UID,
'PRO_ID' => $process->PRO_ID,
'TAS_UID' => $task->TAS_UID,
'TAS_ID' => $task->TAS_ID,
'USR_UID' => $user->USR_UID,
'USR_ID' => $user->USR_ID
]);
$rest = $this->initializeRestApi($user->USR_UID);
$rest->apiMethodInfo->methodName = 'doGetCaseVariables';
$rest->apiMethodInfo->arguments = [
'app_uid' => 0,
'dyn_uid' => 1,
'app_index' => 2
];
//assert
$cases = new Cases();
$cases->parameters = [
$application->APP_UID,
$dynaform->DYN_UID,
1
];
$cases->restler = $rest;
$expected = $cases->__isAllowed();
$this->assertTrue($expected);
}
/**
* This test verify isAllowed method doGetCaseVariables option with delegation user.
* @test
* @covers ProcessMaker\Services\Api\Cases::__isAllowed
*/
public function it_should_test_isAllowed_method_doGetCaseVariables_option_without_delegation_user()
{
$user = factory(\ProcessMaker\Model\User::class)->create();
$process = factory(\ProcessMaker\Model\Process::class)->create();
$task = factory(\ProcessMaker\Model\Task::class)->create([
'PRO_UID' => $process->PRO_UID,
'PRO_ID' => $process->PRO_ID
]);
$dynaform = factory(\ProcessMaker\Model\Dynaform::class)->create([
'PRO_UID' => $process->PRO_UID
]);
$application = factory(\ProcessMaker\Model\Application::class)->create([
'PRO_UID' => $process->PRO_UID,
'APP_INIT_USER' => $user->USR_UID,
'APP_CUR_USER' => $user->USR_UID
]);
$rest = $this->initializeRestApi($user->USR_UID);
$rest->apiMethodInfo->methodName = 'doGetCaseVariables';
$rest->apiMethodInfo->arguments = [
'app_uid' => 0,
'dyn_uid' => 1,
'app_index' => 2
];
//assert
$cases = new Cases();
$cases->parameters = [
$application->APP_UID,
$dynaform->DYN_UID,
1
];
$cases->restler = $rest;
$expected = $cases->__isAllowed();
$this->assertFalse($expected);
}
/**
* This test verify isAllowed method doGetCaseVariables option with guest user.
* @test
* @covers ProcessMaker\Services\Api\Cases::__isAllowed
*/
public function it_should_test_isAllowed_method_doGetCaseVariables_option_with_guest_user()
{
$user = factory(\ProcessMaker\Model\User::class)->create();
$process = factory(\ProcessMaker\Model\Process::class)->create();
$task = factory(\ProcessMaker\Model\Task::class)->create([
'PRO_UID' => $process->PRO_UID,
'PRO_ID' => $process->PRO_ID
]);
$dynaform = factory(\ProcessMaker\Model\Dynaform::class)->create([
'PRO_UID' => $process->PRO_UID
]);
$application = factory(\ProcessMaker\Model\Application::class)->create([
'PRO_UID' => $process->PRO_UID,
'APP_INIT_USER' => $user->USR_UID,
'APP_CUR_USER' => $user->USR_UID
]);
$rest = $this->initializeRestApi(RBAC::GUEST_USER_UID);
$rest->apiMethodInfo->methodName = 'doGetCaseVariables';
$rest->apiMethodInfo->arguments = [
'app_uid' => 0,
'dyn_uid' => 1,
'app_index' => 2
];
//assert
$cases = new Cases();
$cases->parameters = [
$application->APP_UID,
$dynaform->DYN_UID,
1
];
$cases->restler = $rest;
$expected = $cases->__isAllowed();
$this->assertTrue($expected);
}
}

7
workflow/engine/methods/cases/cases_ShowDocument.php
View File

@@ -44,7 +44,12 @@ if (empty($_GET['v'])) {
//Check if the user can be download the input Document
//Send the parameter v = Version
//Send the parameter a = Case UID
if ($RBAC->userCanAccess('PM_FOLDERS_ALL') != 1 && defined('DISABLE_DOWNLOAD_DOCUMENTS_SESSION_VALIDATION') && DISABLE_DOWNLOAD_DOCUMENTS_SESSION_VALIDATION == 0) {
$isGuestUser = false;
if (!empty($_SESSION['GUEST_USER']) && $_SESSION['GUEST_USER'] === RBAC::GUEST_USER_UID) {
$isGuestUser = true;
}
$access = $RBAC->userCanAccess('PM_FOLDERS_ALL') != 1 && defined('DISABLE_DOWNLOAD_DOCUMENTS_SESSION_VALIDATION') && DISABLE_DOWNLOAD_DOCUMENTS_SESSION_VALIDATION == 0;
if ($access && $isGuestUser === false) {
if (!$oAppDocument->canDownloadInput($_SESSION['USER_LOGGED'], $_GET['a'], $docVersion)) {
G::header('Location: /errors/error403.php?url=' . urlencode($_SERVER['REQUEST_URI']));
die();

20
workflow/engine/methods/services/ActionsByEmailDataForm.php
View File

@@ -48,7 +48,7 @@ if (isset($_GET['BROWSER_TIME_ZONE_OFFSET'])) {
$record = [];
$record['DYN_CONTENT'] = $configuration['DYN_CONTENT'];
$record['PRO_UID'] = $configuration['PRO_UID'];
$record['PRO_UID'] = $configuration['PRO_UID'];
$record['CURRENT_DYNAFORM'] = G::decrypt($_REQUEST['DYN_UID'], URL_KEY);
$record['APP_UID'] = $_REQUEST['APP_UID'];
$record['DEL_INDEX'] = $_REQUEST['DEL_INDEX'];
@@ -56,9 +56,21 @@ if (isset($_GET['BROWSER_TIME_ZONE_OFFSET'])) {
$record['APP_DATA'] = $caseFields['APP_DATA'];
if (is_null($caseFields['DEL_FINISH_DATE'])) {
$a = new PmDynaform($record);
$a->printABE($action,$record);
//we define the guest user
$restore = false;
if (isset($_SESSION["USER_LOGGED"])) {
$restore = $_SESSION["USER_LOGGED"];
}
$_SESSION["USER_LOGGED"] = RBAC::GUEST_USER_UID;
$_SESSION['GUEST_USER'] = RBAC::GUEST_USER_UID;
$pmDynaform = new PmDynaform($record);
//we must return to the original value of the session
if ($restore === false) {
unset($_SESSION["USER_LOGGED"]);
} else {
$_SESSION["USER_LOGGED"] = $restore;
}
$pmDynaform->printABE($action, $record);
} else {
$G_PUBLISH->AddContent(
'xmlform',

14
workflow/engine/src/ProcessMaker/Model/AppDocument.php Normal file
View File

@@ -0,0 +1,14 @@
<?php
namespace ProcessMaker\Model;
use Illuminate\Database\Eloquent\Model;
class AppDocument extends Model
{
protected $table = "APP_DOCUMENT";
protected $primaryKey = 'APP_DOC_UID';
public $incrementing = false;
public $timestamps = false;
}

4
workflow/engine/src/ProcessMaker/Services/Api/Cases.php
View File

@@ -72,6 +72,10 @@ class Cases extends Api
$dynaformUid = $this->parameters[$arrayArgs['dyn_uid']];
$delIndex = $this->parameters[$arrayArgs['app_index']];
$userUid = $this->getUserId();
//check the guest user
if ($userUid === RBAC::GUEST_USER_UID) {
return true;
}
//Check if the user has the case
$appDelegation = new AppDelegation();
$aCurUser = $appDelegation->getCurrentUsers($applicationUid, $delIndex);