fernando/luos
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merged in mcuiza/processmaker/veracode_29-04-15 (pull request #2057)

Browse Source 
Validaciones nuevas incidencias reporte veracode 29-04-15
This commit is contained in:
Julio Cesar Laura Avendaño
2015-04-30 21:02:55 -04:00
parent d487089339 c3c0f72aed
commit f7fba3769e
30 changed files with 434 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
workflow/engine/controllers/adminProxy.php
View File

@@ -1076,7 +1076,8 @@ class adminProxy extends HttpProxyController
} else {
$failed = "3";
}
unlink ($dir . '/tmp' . $fileName);
$path = $filter->xssFilterHard($dir . '/tmp' . $fileName, 'path');
unlink ($path);
} catch (Exception $e) {
$failed = "3";
}
@@ -1088,6 +1089,7 @@ class adminProxy extends HttpProxyController
}
$uploaded = $filter->validateInput($uploaded,'int');
$files_img_type = $filter->xssFilterHard($files_img_type);
$failed = $filter->validateInput($failed,'int');
echo '{success: true, failed: ' . $failed . ', uploaded: ' . $uploaded . ', type: "' . $files_img_type . '"}';
exit();
}
@@ -1236,6 +1238,11 @@ class adminProxy extends HttpProxyController
public function showLogo($imagen)
{
$info = @getimagesize($imagen);
G::LoadSystem('inputfilter');
$filter = new InputFilter();
$imagen = $filter->validateInput($imagen, "path");
$fp = fopen($imagen, "rb");
if ($info && $fp) {
header("Content-type: {$info['mime']}");
@@ -1295,6 +1302,11 @@ class adminProxy extends HttpProxyController
}
$newDir .= PATH_SEP.$base64Id;
$dir .= PATH_SEP.$base64Id;
G::LoadSystem('inputfilter');
$filter = new InputFilter();
$dir = $filter->validateInput($dir, "path");
copy($dir,$newDir);
self::showLogo($newDir);
die;

0
workflow/engine/controllers/installer.php Executable file → Normal file
View File

1
workflow/engine/includes/inc.JSForms.php
View File

@@ -47,6 +47,7 @@ function RefreshDependentFields(ObjectName, Fields, InitValue) {
global $HTTP_GET_VARS;
if ($HTTP_SESSION_VARS['CURRENT_APPLICATION'] == '') $HTTP_SESSION_VARS['CURRENT_APPLICATION'] = '0';
$appid = $HTTP_SESSION_VARS['CURRENT_APPLICATION'];
$appid = $filter->xssFilterHard($appid);
if ($HTTP_GET_VARS['dynaform'] != ''){
$Dynaform = '&__dynaform__=' . $HTTP_GET_VARS['dynaform'];
$Dynaform = $filter->xssFilterHard($Dynaform);

0
workflow/engine/methods/cases/cases_Ajax.php Executable file → Normal file
View File

3
workflow/engine/methods/cases/proxyNewCasesList.php
View File

@@ -147,7 +147,8 @@ try {
$response['data'] = $result;
$filtersData['action'] = $filters["action"];
$response['totalCount'] = $list->countTotal($userUid, $filtersData);
$response = $filter->xssFilterHard($response);
echo G::json_encode($response);
} catch (Exception $e) {
$msg = array("error" => $e->getMessage());

9
workflow/engine/methods/setup/pluginsRemove.php
View File

@@ -41,15 +41,16 @@ switch ($RBAC->userCanAccess('PM_SETUP_ADVANCE'))
G::LoadClass( "plugin" );
G::LoadSystem('inputfilter');
$filter = new InputFilter();
$pluginName = $_REQUEST["pluginUid"];
$pluginName = $_REQUEST['pluginUid'];
$pluginName = $filter->xssFilterHard($pluginName);
if (file_exists( PATH_PLUGINS . $pluginName . ".php" )) {
$pluginRegistry = &PMPluginRegistry::getSingleton();
$pluginRegistry->uninstallPlugin( $pluginName );
$pluginRegistry->unSerializeInstance( file_get_contents( PATH_DATA_SITE . "plugin.singleton" ) );
$path = $filter->validateInput(PATH_DATA_SITE . 'plugin.singleton', 'path');
$pluginRegistry->unSerializeInstance( file_get_contents( $path ) );
}
G::auditLog("RemovePlugin","Plugin Name: ".$pluginName);
echo $pluginName . " " . nl2br( $filter->xssFilterHard(G::LoadTranslation( "ID_MSG_REMOVE_PLUGIN_SUCCESS" )) );
echo $pluginName . ' ' . nl2br( $filter->xssFilterHard(G::LoadTranslation( 'ID_MSG_REMOVE_PLUGIN_SUCCESS' )) );

6
workflow/engine/methods/setup/setup.php
View File

@@ -78,10 +78,10 @@ $G_PUBLISH->AddContent( 'template', '', '', '', $template );
G::RenderPage( 'publish' );
if (isset( $_GET['module'] )) {
$module = $filter->xssFilterHard($_GET['module']);
print "
print '
<script>
admToolsContent.location='" . $module . "';
admToolsContent.location=\''.$module.'\';
</script>
";
';
}