From b11a06a57aa92642b870c4c6006c9954fa3d558c Mon Sep 17 00:00:00 2001 From: Marco Antonio Nina Mena Date: Thu, 7 Dec 2017 09:34:44 -0400 Subject: [PATCH 1/2] HOR-4159 Custom plugins are not updating the friendly name after changing it - Add section update informacion Friendly name and description --- workflow/engine/src/ProcessMaker/Plugins/PluginRegistry.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/workflow/engine/src/ProcessMaker/Plugins/PluginRegistry.php b/workflow/engine/src/ProcessMaker/Plugins/PluginRegistry.php index b1c06227a..783cd0152 100644 --- a/workflow/engine/src/ProcessMaker/Plugins/PluginRegistry.php +++ b/workflow/engine/src/ProcessMaker/Plugins/PluginRegistry.php @@ -242,6 +242,8 @@ class PluginRegistry $currentPlugin->getNamespace(), $currentPlugin->getFile() ); + $this->_aPluginDetails[$Namespace]->sFriendlyName = $Plugin->sFriendlyName; + $this->_aPluginDetails[$Namespace]->sDescription = $Plugin->sDescription; } else { $Plugin = $currentPlugin; } From 872828da8439e483b24fb4de42dcf4c71e21a6e4 Mon Sep 17 00:00:00 2001 From: Marco Antonio Nina Mena Date: Thu, 7 Dec 2017 11:09:17 -0400 Subject: [PATCH 2/2] Fix CR --- .../src/ProcessMaker/Plugins/PluginRegistry.php | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/workflow/engine/src/ProcessMaker/Plugins/PluginRegistry.php b/workflow/engine/src/ProcessMaker/Plugins/PluginRegistry.php index 783cd0152..bb13dcf11 100644 --- a/workflow/engine/src/ProcessMaker/Plugins/PluginRegistry.php +++ b/workflow/engine/src/ProcessMaker/Plugins/PluginRegistry.php @@ -238,18 +238,18 @@ class PluginRegistry $className = $currentPlugin->getClassName(); /** @var enterprisePlugin $Plugin */ if (class_exists($className)) { - $Plugin = new $className( + $plugin = new $className( $currentPlugin->getNamespace(), $currentPlugin->getFile() ); - $this->_aPluginDetails[$Namespace]->sFriendlyName = $Plugin->sFriendlyName; - $this->_aPluginDetails[$Namespace]->sDescription = $Plugin->sDescription; + $this->_aPluginDetails[$Namespace]->sFriendlyName = $plugin->sFriendlyName; + $this->_aPluginDetails[$Namespace]->sDescription = $plugin->sDescription; } else { - $Plugin = $currentPlugin; + $plugin = $currentPlugin; } - $this->_aPlugins[$Namespace] = $Plugin; - if (method_exists($Plugin, 'enable')) { - $Plugin->enable(); + $this->_aPlugins[$Namespace] = $plugin; + if (method_exists($plugin, 'enable')) { + $plugin->enable(); } /* * 1. register /src directory for autoloading @@ -266,7 +266,7 @@ class PluginRegistry if (array_key_exists($currentPlugin->getNamespace(), $this->_restServiceEnabled) && $this->_restServiceEnabled[$currentPlugin->getNamespace()] == true ) { - $Plugin->registerRestService(); + $plugin->registerRestService(); } return true; } else {