From 6f395343d492f7bec1907f588282884425330e2f Mon Sep 17 00:00:00 2001 From: jennylee Date: Fri, 19 Apr 2013 17:28:04 -0400 Subject: [PATCH 1/2] BUG 11255. PM allows creating RT without validating if process is selected. SOLVED Was added a validation to check if the process is selected before saving the Report Table. --- workflow/engine/templates/pmTables/editReport.js | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/workflow/engine/templates/pmTables/editReport.js b/workflow/engine/templates/pmTables/editReport.js index 8fa64c6db..f2114165c 100755 --- a/workflow/engine/templates/pmTables/editReport.js +++ b/workflow/engine/templates/pmTables/editReport.js @@ -910,6 +910,7 @@ function createReportTable() { var tableName = Ext.getCmp('REP_TAB_NAME').getValue().trim(); var tableDescription = Ext.getCmp('REP_TAB_DSC').getValue().trim(); + var process = Ext.getCmp('PROCESS').getValue().trim(); //validate table name if(Ext.getCmp('REP_TAB_NAME').getValue().trim() == '') { @@ -919,6 +920,15 @@ function createReportTable() }); return false; } + + //validate process + if(Ext.getCmp('PROCESS').getValue().trim() == '') { + Ext.getCmp('PROCESS').focus(); + PMExt.error(_('ID_ERROR'), _('ID_PROCESS_IS_REQUIRED'), function(){ + Ext.getCmp('PROCESS').focus(); + }); + return false; + } // validate table name length if(tableName.length < 4) { From 6ba524d2d9ceb64794622e9b13efb195f9aca8b2 Mon Sep 17 00:00:00 2001 From: jennylee Date: Mon, 22 Apr 2013 10:46:41 -0400 Subject: [PATCH 2/2] BUG 11255. PM allows creating RT without validating if process is selected. SOLVED Was added a validation to check if the process is selected before saving the Report Table. --- workflow/engine/templates/pmTables/editReport.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/workflow/engine/templates/pmTables/editReport.js b/workflow/engine/templates/pmTables/editReport.js index f2114165c..7747ea7d6 100755 --- a/workflow/engine/templates/pmTables/editReport.js +++ b/workflow/engine/templates/pmTables/editReport.js @@ -910,8 +910,7 @@ function createReportTable() { var tableName = Ext.getCmp('REP_TAB_NAME').getValue().trim(); var tableDescription = Ext.getCmp('REP_TAB_DSC').getValue().trim(); - var process = Ext.getCmp('PROCESS').getValue().trim(); - + //validate table name if(Ext.getCmp('REP_TAB_NAME').getValue().trim() == '') { Ext.getCmp('REP_TAB_NAME').focus();