From d87679f079dde4b619d979990c71dca8f7bb8122 Mon Sep 17 00:00:00 2001 From: Rodrigo Quelca Date: Tue, 30 Oct 2018 13:58:33 +0000 Subject: [PATCH] FBI-2533: When the googleMaps variable was not defined in the class PmDynaform.php and /js/cases/core/pmDynaform.js the form crashes. clean code clean code 2 remove an extra coma --- workflow/engine/classes/PmDynaform.php | 4 ++-- workflow/engine/js/cases/core/pmDynaform.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/workflow/engine/classes/PmDynaform.php b/workflow/engine/classes/PmDynaform.php index f614521d3..79f62ffd4 100644 --- a/workflow/engine/classes/PmDynaform.php +++ b/workflow/engine/classes/PmDynaform.php @@ -1039,7 +1039,7 @@ class PmDynaform }, token: credentials, submitRest: false, - googleMaps: googleMaps + googleMaps: typeof googleMaps !== 'undefined' ? googleMaps : null }); $(document).find(\"form\").submit(function (e) { e.preventDefault(); @@ -1101,7 +1101,7 @@ class PmDynaform " },\n" . " token: credentials,\n" . " submitRest: false,\n" . - " googleMaps: googleMaps\n" . + " googleMaps: typeof googleMaps !== 'undefined' ? googleMaps : null\n" . " });\n" . " $(document).find('form').find('button').on('click', function (e) {\n" . " e.preventDefault();\n" . diff --git a/workflow/engine/js/cases/core/pmDynaform.js b/workflow/engine/js/cases/core/pmDynaform.js index 56cc81ef2..6fc55a959 100644 --- a/workflow/engine/js/cases/core/pmDynaform.js +++ b/workflow/engine/js/cases/core/pmDynaform.js @@ -91,7 +91,7 @@ $(window).load(function () { }, token: credentials, submitRest: false, - googleMaps: googleMaps, + googleMaps: typeof googleMaps !== "undefined" ? googleMaps : null, onLoad: function () { var dynaformname = document.createElement("input"), appuid,