From d2a7e59718f9593a225bf7483d004c39b8fb8fb0 Mon Sep 17 00:00:00 2001
From: Marco Antonio Nina Mena <marco.antonio.nina@processmaker.com>
Date: Mon, 30 Oct 2017 13:10:37 -0400
Subject: [PATCH] HOR-4012 Verify type columns in table PLUGINS_REGISTRY

- change type field to mediumtext
- set table collation utf8_general_ci
---
 .../model/map/PluginsRegistryMapBuilder.php   |  2 +-
 .../classes/model/om/BasePluginsRegistry.php  |  4 ++--
 workflow/engine/config/schema.xml             | 24 ++++++++++++++++++-
 workflow/engine/data/mysql/schema.sql         |  2 +-
 4 files changed, 27 insertions(+), 5 deletions(-)

diff --git a/workflow/engine/classes/model/map/PluginsRegistryMapBuilder.php b/workflow/engine/classes/model/map/PluginsRegistryMapBuilder.php
index 25cfaf8c6..42470e305 100644
--- a/workflow/engine/classes/model/map/PluginsRegistryMapBuilder.php
+++ b/workflow/engine/classes/model/map/PluginsRegistryMapBuilder.php
@@ -69,7 +69,7 @@ class PluginsRegistryMapBuilder
 
         $tMap->addColumn('PLUGIN_NAMESPACE', 'PluginNamespace', 'string', CreoleTypes::VARCHAR, true, 100);
 
-        $tMap->addColumn('PLUGIN_DESCRIPTION', 'PluginDescription', 'string', CreoleTypes::VARCHAR, false, 200);
+        $tMap->addColumn('PLUGIN_DESCRIPTION', 'PluginDescription', 'string', CreoleTypes::LONGVARCHAR, false, null);
 
         $tMap->addColumn('PLUGIN_CLASS_NAME', 'PluginClassName', 'string', CreoleTypes::VARCHAR, true, 100);
 
diff --git a/workflow/engine/classes/model/om/BasePluginsRegistry.php b/workflow/engine/classes/model/om/BasePluginsRegistry.php
index d6f0be021..a3e4d77b8 100644
--- a/workflow/engine/classes/model/om/BasePluginsRegistry.php
+++ b/workflow/engine/classes/model/om/BasePluginsRegistry.php
@@ -43,7 +43,7 @@ abstract class BasePluginsRegistry extends BaseObject implements Persistent
      * The value for the plugin_description field.
      * @var        string
      */
-    protected $plugin_description = '';
+    protected $plugin_description;
 
     /**
      * The value for the plugin_class_name field.
@@ -508,7 +508,7 @@ abstract class BasePluginsRegistry extends BaseObject implements Persistent
             $v = (string) $v;
         }
 
-        if ($this->plugin_description !== $v || $v === '') {
+        if ($this->plugin_description !== $v) {
             $this->plugin_description = $v;
             $this->modifiedColumns[] = PluginsRegistryPeer::PLUGIN_DESCRIPTION;
         }
diff --git a/workflow/engine/config/schema.xml b/workflow/engine/config/schema.xml
index 276ccb68d..6fa41d930 100644
--- a/workflow/engine/config/schema.xml
+++ b/workflow/engine/config/schema.xml
@@ -5649,10 +5649,32 @@
     </index>
   </table>
   <table name="PLUGINS_REGISTRY" idMethod="native">
+    <vendor type="mysql">
+      <parameter name="Name" value="PLUGINS_REGISTRY"/>
+      <parameter name="Engine" value="InnoDB"/>
+      <parameter name="Version" value="10"/>
+      <parameter name="Row_format" value="Dynamic"/>
+      <parameter name="Data_free" value="0"/>
+      <parameter name="Auto_increment" value=""/>
+      <parameter name="Check_time" value=""/>
+      <parameter name="Collation" value="utf8_general_ci"/>
+      <parameter name="Checksum" value=""/>
+      <parameter name="Create_options" value=""/>
+      <parameter name="Comment" value="Registry of plugins details"/>
+    </vendor>
     <!--PluginDetails-->
     <column name="PR_UID" type="VARCHAR" size="32" required="true" primaryKey="true" default=""/>
     <column name="PLUGIN_NAMESPACE" type="VARCHAR" size="100" required="true"/>
-    <column name="PLUGIN_DESCRIPTION" type="VARCHAR" size="200" default=""/>
+    <column name="PLUGIN_DESCRIPTION" type="LONGVARCHAR">
+      <vendor type="mysql">
+        <parameter name="Field" value="PLUGIN_DESCRIPTION"/>
+        <parameter name="Type" value="MEDIUMTEXT"/>
+        <parameter name="Null" value="NO"/>
+        <parameter name="Key" value=""/>
+        <parameter name="Default" value=""/>
+        <parameter name="Extra" value=""/>
+      </vendor>
+    </column>
     <column name="PLUGIN_CLASS_NAME" type="VARCHAR" size="100" required="true"/>
     <column name="PLUGIN_FRIENDLY_NAME" type="VARCHAR" size="150" default=""/>
     <column name="PLUGIN_FILE" type="VARCHAR" size="250" required="true"/>
diff --git a/workflow/engine/data/mysql/schema.sql b/workflow/engine/data/mysql/schema.sql
index 0f75d38d0..0d2aeb48c 100644
--- a/workflow/engine/data/mysql/schema.sql
+++ b/workflow/engine/data/mysql/schema.sql
@@ -3157,7 +3157,7 @@ CREATE TABLE `PLUGINS_REGISTRY`
 (
 	`PR_UID` VARCHAR(32) default '' NOT NULL,
 	`PLUGIN_NAMESPACE` VARCHAR(100)  NOT NULL,
-	`PLUGIN_DESCRIPTION` VARCHAR(200) default '',
+	`PLUGIN_DESCRIPTION` MEDIUMTEXT,
 	`PLUGIN_CLASS_NAME` VARCHAR(100)  NOT NULL,
 	`PLUGIN_FRIENDLY_NAME` VARCHAR(150) default '',
 	`PLUGIN_FILE` VARCHAR(250)  NOT NULL,