PMC-580: release/3.3.8

workflow/engine/classes/model/AppNotes.php

@@ -180,8 +180,12 @@ class AppNotes extends BaseAppNotes
      * @param string $noteRecipients
      * @param string $from
      * @param integer $delIndex
-     *
+     * @return void
      * @throws Exception
+     *
+     * @see AppNotes->addCaseNote()
+     * @see AppNotes->postNewNote()
+     * @see workflow/engine/src/ProcessMaker/Util/helpers.php::postNote()
     */
     public function sendNoteNotification ($appUid, $usrUid, $noteContent, $noteRecipients, $from = '', $delIndex = 0)
     {
@@ -224,7 +228,7 @@ class AppNotes extends BaseAppNotes
                     '',
                     $appUid,
                     $delIndex,
-                    'DERIVATION',
+                    WsBase::MESSAGE_TYPE_CASE_NOTE,
                     G::replaceDataField($configNoteNotification['subject'], $fieldCase),
                     G::buildFrom($configuration, $from),
                     $to,

workflow/engine/classes/model/Groupwf.php

@@ -98,13 +98,13 @@ class Groupwf extends BaseGroupwf
                 $this->setGrpTitle('Default Group Title');
             }
 
-            if (!empty($aData['GRP_STATUS'])) {
+            if (!empty($data['GRP_STATUS'])) {
                 $this->setGrpStatus($data['GRP_STATUS']);
             } else {
                 $this->setGrpStatus('ACTIVE');
             }
 
-            if (!empty($aData['GRP_LDAP_DN'])) {
+            if (!empty($data['GRP_LDAP_DN'])) {
                 $this->setGrpLdapDn($data['GRP_LDAP_DN']);
             } else {
                 $this->setGrpLdapDn('');