fernando/luos
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merged in bugfix/PMCORE-1140 (pull request #7290)

Browse Source 
PMCORE-1140

Approved-by: Julio Cesar Laura Avendaño <contact@julio-laura.com>
This commit is contained in:
Fabio Guachalla
2020-03-30 13:46:14 +00:00
committed by Julio Cesar Laura Avendaño
parent 487d2a3494 3640ebd4f3
commit c94d78847d
2 changed files with 48 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
tests/unit/workflow/engine/src/ProcessMaker/BusinessModel/CasesTest.php
View File

@@ -77,4 +77,33 @@ class CasesTest extends TestCase
$case = new Cases();
$case->deleteCase($application->APP_UID, $_SESSION['USER_LOGGED']);
}
/**
* This checks the validation of documents
*
* @covers \ProcessMaker\BusinessModel\Cases::validateAppDocUid()
* @test
*/
public function it_should_validate_app_doc_uid()
{
$arrayVariableDocument = [
0 => [
"appDocUid" => "4371401485e7cd60d160062060139220",
"name" => "test_1.txt",
"version" => "1"
],
1 => [
"name" => "test_1.txt",
"version" => "1"
],
2 => [
"appDocUid" => "6837968225e7cd60dc17588042896388",
"name" => "test_1.txt",
"version" => "1"
]
];
$case = new Cases();
$newArrayVariableDocument = $case->validateAppDocUid($arrayVariableDocument);
$this->assertNotEmpty($newArrayVariableDocument);
$this->assertNotEquals($newArrayVariableDocument, $arrayVariableDocument);
}
}

19
workflow/engine/src/ProcessMaker/BusinessModel/Cases.php
View File

@@ -3230,6 +3230,7 @@ class Cases
$arrayApplicationData = $this->getApplicationRecordByPk($applicationUid, [], false);
$arrayApplicationData['APP_DATA'] = $case->unserializeData($arrayApplicationData['APP_DATA']);
$flagDelete = false;
$arrayVariableDocumentToDelete = $this->validateAppDocUid($arrayVariableDocumentToDelete);
foreach ($arrayVariableDocumentToDelete as $key => $value) {
if (is_array($value) && !empty($value)) {
@@ -3315,6 +3316,24 @@ class Cases
}
}
/**
* Validate if all documents have appDocUid
*
* @param array $arrayVariableDocument
*
* @return array
*/
public function validateAppDocUid(array $arrayVariableDocument)
{
$newArrayVariableDocument = [];
foreach ($arrayVariableDocument as $value) {
if (array_key_exists('appDocUid', $value)) {
$newArrayVariableDocument[] = $value;
}
}
return $newArrayVariableDocument;
}
/**
* Get Permissions, Participate, Access, Objects supervisor
*