From 6ff6f7ff2731f843a895b42fd2e7c7dc878f1f68 Mon Sep 17 00:00:00 2001
From: dheeyi <dheeyi@gmail.com>
Date: Tue, 21 Apr 2015 17:15:36 -0400
Subject: [PATCH 01/16] =?UTF-8?q?PM-2255=20Error=20de=20escritura=20en=20e?=
 =?UTF-8?q?l=20mensaje.=20Causa=20:=20Definida=20asi=20en=20su=20construcc?=
 =?UTF-8?q?i=C3=B3Soluci=C3=B3=20Se=20cambio=20la=20descripcion=20de=20los?=
 =?UTF-8?q?=20labels=20tal=20com=20se=20indica.?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 workflow/engine/templates/installer/installer_cards.js | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/workflow/engine/templates/installer/installer_cards.js b/workflow/engine/templates/installer/installer_cards.js
index f9e741b0a..27b3f22d8 100644
--- a/workflow/engine/templates/installer/installer_cards.js
+++ b/workflow/engine/templates/installer/installer_cards.js
@@ -207,8 +207,8 @@ Ext.onReady(function(){
     Ext.Ajax.request({
       url: 'checkDatabases',
       success: function(response){
-        var existMsg = '<span style="color: red;">' + _('ID_EXIST') + '</span>';
-        var noExistsMsg = '<span style="color: green;">' + _('ID_NO_EXIST') + '</span>';
+        var existMsg = '<span style="color: red;">' + _('ID_NOT_AVAILABLE_DATABASE') + '</span>';
+        var noExistsMsg = '<span style="color: green;">' + _('ID_AVAILABLE_DATABASE') + '</span>';
         var response = Ext.util.JSON.decode(response.responseText);
         Ext.get('wfDatabaseSpan').dom.innerHTML = (response.wfDatabaseExists ? existMsg : noExistsMsg);
 
@@ -784,11 +784,12 @@ Ext.onReady(function(){
                  }),
                  {
                     xtype     : 'textfield',
-                    fieldLabel: _('ID_WF_DATABASE_NAME') + ' <span id="wfDatabaseSpan"></span>',
+                    fieldLabel: _('ID_WF_DATABASE_NAME') + ':<br>' + ' <span id="wfDatabaseSpan"></span>',
                     id : 'wfDatabase',
                     value  :'wf_workflow',
                     allowBlank : false,
                     maxLength: 32,
+                    labelSeparator : "",
                     validator  : function(v){
                         var t = /^[a-zA-Z_0-9]+$/;
                         return t.test(v);

From 2fd192a5ccf4563fbcf908b9039b4d6cd6044111 Mon Sep 17 00:00:00 2001
From: dheeyi <dheeyi@gmail.com>
Date: Wed, 22 Apr 2015 10:29:24 -0400
Subject: [PATCH 02/16] =?UTF-8?q?PM-2255=20Error=20de=20escritura=20en=20e?=
 =?UTF-8?q?l=20mensaje.=20Causa=20:=20Definida=20asi=20en=20su=20construcc?=
 =?UTF-8?q?i=C3=B3Soluci=C3=B3=20Se=20cambio=20la=20descripcion=20de=20los?=
 =?UTF-8?q?=20labels=20tal=20com=20se=20indica.?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 workflow/engine/templates/installer/installer_cards.js | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/workflow/engine/templates/installer/installer_cards.js b/workflow/engine/templates/installer/installer_cards.js
index 27b3f22d8..e407ec035 100644
--- a/workflow/engine/templates/installer/installer_cards.js
+++ b/workflow/engine/templates/installer/installer_cards.js
@@ -210,7 +210,7 @@ Ext.onReady(function(){
         var existMsg = '<span style="color: red;">' + _('ID_NOT_AVAILABLE_DATABASE') + '</span>';
         var noExistsMsg = '<span style="color: green;">' + _('ID_AVAILABLE_DATABASE') + '</span>';
         var response = Ext.util.JSON.decode(response.responseText);
-        Ext.get('wfDatabaseSpan').dom.innerHTML = (response.wfDatabaseExists ? existMsg : noExistsMsg);
+        Ext.get('database_message').dom.innerHTML = (response.wfDatabaseExists ? existMsg : noExistsMsg);
 
         var dbFlag = ((!response.wfDatabaseExists) || Ext.getCmp('deleteDB').getValue());
         wizard.onClientValidation(4, dbFlag);
@@ -784,12 +784,11 @@ Ext.onReady(function(){
                  }),
                  {
                     xtype     : 'textfield',
-                    fieldLabel: _('ID_WF_DATABASE_NAME') + ':<br>' + ' <span id="wfDatabaseSpan"></span>',
+                    fieldLabel: _('ID_WF_DATABASE_NAME'),
                     id : 'wfDatabase',
                     value  :'wf_workflow',
                     allowBlank : false,
                     maxLength: 32,
-                    labelSeparator : "",
                     validator  : function(v){
                         var t = /^[a-zA-Z_0-9]+$/;
                         return t.test(v);
@@ -800,6 +799,10 @@ Ext.onReady(function(){
                       wizard.onClientValidation(4, false);
                     }}
                   },
+                  {
+                    xtype     : 'displayfield',
+                    id  : 'database_message'
+                  },
                   new Ext.form.Checkbox({
                     boxLabel   : _('ID_DELETE_DATABASES'),
                     id : 'deleteDB',

From 51fd1ef9500e5699241003eb669bfbef2108f83f Mon Sep 17 00:00:00 2001
From: "marcelo.cuiza" <marcelo.cuiza@colosa.com>
Date: Thu, 23 Apr 2015 09:46:55 -0400
Subject: [PATCH 03/16] PM-2238

DesignerBPMN>ProcessFileManager: Cuando importas un template no verifica si existe otro template con el mismo nombre

Se corrigio la validacion que se tenia, para que valide tambien cargar templates
---
 .../src/ProcessMaker/BusinessModel/FilesManager.php    | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/workflow/engine/src/ProcessMaker/BusinessModel/FilesManager.php b/workflow/engine/src/ProcessMaker/BusinessModel/FilesManager.php
index cdb3a9fc8..da32040ec 100644
--- a/workflow/engine/src/ProcessMaker/BusinessModel/FilesManager.php
+++ b/workflow/engine/src/ProcessMaker/BusinessModel/FilesManager.php
@@ -190,12 +190,11 @@ class FilesManager
                     break;
             }
             $content = $aData['prf_content'];
-            if (is_string($content)) {
-                if (file_exists($sDirectory)) {
-                    $directory = $sMainDirectory. PATH_SEP . $sSubDirectory . $aData['prf_filename'];
-                    throw new \Exception(\G::LoadTranslation("ID_EXISTS_FILE", array($directory)));
-                }
+            if (file_exists($sDirectory) ) {
+                $directory = $sMainDirectory. PATH_SEP . $sSubDirectory . $aData['prf_filename'];
+                throw new \Exception(\G::LoadTranslation("ID_EXISTS_FILE", array($directory)));
             }
+            
             if (!file_exists($sCheckDirectory)) {
                 $sPkProcessFiles = \G::generateUniqueID();
                 $oProcessFiles = new \ProcessFiles();
@@ -555,4 +554,3 @@ class FilesManager
         }
     }
 }
-

From 52f0930b31a95a53ebe622dd235866e38a9ca567 Mon Sep 17 00:00:00 2001
From: Brayan Pereyra <brayan@colosa.com>
Date: Thu, 23 Apr 2015 12:06:04 -0400
Subject: [PATCH 04/16] PM-2398 El contador de listados en home muestran datos
 incorrectos

---
 workflow/engine/classes/class.case.php         |  8 +++++---
 workflow/engine/classes/model/ListCanceled.php | 14 +++++++++++++-
 2 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/workflow/engine/classes/class.case.php b/workflow/engine/classes/class.case.php
index 87839c453..4f27344f9 100755
--- a/workflow/engine/classes/class.case.php
+++ b/workflow/engine/classes/class.case.php
@@ -4100,6 +4100,7 @@ class Cases
 
         $oApplication = new Application();
         $aFields = $oApplication->load($sApplicationUID);
+        $appStatusCurrent = $aFields['APP_STATUS'];
         $oCriteria = new Criteria('workflow');
         $oCriteria->add(AppDelegationPeer::APP_UID, $sApplicationUID);
         $oCriteria->add(AppDelegationPeer::DEL_FINISH_DATE, null, Criteria::ISNULL);
@@ -4168,9 +4169,10 @@ class Cases
         }
         /*----------------------------------********---------------------------------*/
         $data = array (
-            'APP_UID'   => $sApplicationUID,
-            'DEL_INDEX' => $iIndex,
-            'USR_UID'   => $user_logged
+            'APP_UID'            => $sApplicationUID,
+            'DEL_INDEX'          => $iIndex,
+            'USR_UID'            => $user_logged,
+            'APP_STATUS_CURRENT' => $appStatusCurrent
         );
         $data = array_merge($aFields, $data);
         $oListCanceled = new ListCanceled();
diff --git a/workflow/engine/classes/model/ListCanceled.php b/workflow/engine/classes/model/ListCanceled.php
index a81944440..f5d740bc4 100644
--- a/workflow/engine/classes/model/ListCanceled.php
+++ b/workflow/engine/classes/model/ListCanceled.php
@@ -104,9 +104,21 @@ class ListCanceled extends BaseListCanceled {
         $oListInbox->removeAll($data['APP_UID']);
 
         $users = new Users();
-        $users->refreshTotal($data['USR_UID'], 'removed', 'inbox');
+        if (!empty($data['APP_STATUS_CURRENT']) && $data['APP_STATUS_CURRENT'] == 'DRAFT') {
+            $users->refreshTotal($data['USR_UID'], 'removed', 'draft');
+        } else {
+            $users->refreshTotal($data['USR_UID'], 'removed', 'inbox');
+        }
         $users->refreshTotal($data['USR_UID'], 'add', 'canceled');
 
+        //Update - WHERE
+        $criteriaWhere = new Criteria("workflow");
+        $criteriaWhere->add(ListParticipatedLastPeer::APP_UID, $data["APP_UID"], Criteria::EQUAL);
+        //Update - SET
+        $criteriaSet = new Criteria("workflow");
+        $criteriaSet->add(ListParticipatedLastPeer::APP_STATUS, 'CANCELLED');
+        BasePeer::doUpdate($criteriaWhere, $criteriaSet, Propel::getConnection("workflow"));
+
         $con = Propel::getConnection( ListCanceledPeer::DATABASE_NAME );
         try {
             $this->fromArray( $data, BasePeer::TYPE_FIELDNAME );

From ec1972a758fcf7459a8450245c37ff6488d33f5b Mon Sep 17 00:00:00 2001
From: rodrigo quelca <rodrigo@colosa.com>
Date: Thu, 23 Apr 2015 15:43:51 -0400
Subject: [PATCH 05/16] PM-2167 and PM-2194 Add waiting/loading icon/gif when
 the process is being created or loaded.(fixed)

---
 workflow/engine/templates/designer/index.html | 1 +
 1 file changed, 1 insertion(+)

diff --git a/workflow/engine/templates/designer/index.html b/workflow/engine/templates/designer/index.html
index bdc08add1..c9d76d383 100644
--- a/workflow/engine/templates/designer/index.html
+++ b/workflow/engine/templates/designer/index.html
@@ -79,6 +79,7 @@
 </head>
 <body onresize="resizingFrame();">
 <!--<div class="ui-layout-north">-->
+     <div class="loader"></div>
      <section class="navBar" id="idNavBar">
         <div class="head"></div>
         <nav>

From 22b00722e8dd669fdf021c402cc91d59dfa79f8f Mon Sep 17 00:00:00 2001
From: Victor Saisa Lopez <victor@colosa.com>
Date: Thu, 23 Apr 2015 16:33:28 -0400
Subject: [PATCH 06/16] PM-2068 "0017117: Error in weekly scheduled case"
 SOLVED

Issue:
    0017117: Error in weekly scheduled case
Cause:
    PHP Fatal error: Class "ConfigurationPeer" not found
Solution:
    Added "Configuration" class with method "Bootstrap::registerClass()"
---
 workflow/engine/bin/cron_single.php | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/workflow/engine/bin/cron_single.php b/workflow/engine/bin/cron_single.php
index dbe2951c0..4d7b59945 100755
--- a/workflow/engine/bin/cron_single.php
+++ b/workflow/engine/bin/cron_single.php
@@ -10,11 +10,6 @@ register_shutdown_function(
     )
 );
 
-/**
- * cron_single.php
- * @package workflow-engine-bin
- */
-
 if (!defined('SYS_LANG')) {
     define('SYS_LANG', 'en');
 }
@@ -220,9 +215,6 @@ Bootstrap::registerClass('CaseTrackerObject',    PATH_HOME . "engine/classes/mod
 Bootstrap::registerClass('BaseCaseTrackerObjectPeer',PATH_HOME . "engine/classes/model/om/BaseCaseTrackerObjectPeer.php");
 Bootstrap::registerClass('CaseTrackerObjectPeer',    PATH_HOME . "engine/classes/model/CaseTrackerObjectPeer.php");
 
-Bootstrap::registerClass('BaseConfiguration',   PATH_HOME . "engine/classes/model/om/BaseConfiguration.php");
-Bootstrap::registerClass('Configuration',       PATH_HOME . "engine/classes/model/Configuration.php");
-
 Bootstrap::registerClass('BaseDbSource',        PATH_HOME . "engine/classes/model/om/BaseDbSource.php");
 Bootstrap::registerClass('DbSource',            PATH_HOME . "engine/classes/model/DbSource.php");
 
@@ -367,7 +359,7 @@ Bootstrap::registerClass("AddonsManagerPeer",   PATH_HOME . "engine" . PATH_SEP
 Bootstrap::registerClass('dashboards',   PATH_HOME . "engine/classes/class.dashboards.php");
 /*----------------------------------********---------------------------------*/
 
-$arrayClass = array("EmailServer", "ListInbox", "ListParticipatedHistory");
+$arrayClass = array("Configuration", "EmailServer", "ListInbox", "ListParticipatedHistory");
 
 foreach ($arrayClass as $value) {
     Bootstrap::registerClass("Base" . $value,          PATH_HOME . "engine" . PATH_SEP . "classes" . PATH_SEP . "model" . PATH_SEP . "om" . PATH_SEP . "Base" . $value . ".php");

From 26193ee621df880ce123d50825767b967159a0c5 Mon Sep 17 00:00:00 2001
From: "marcelo.cuiza" <marcelo.cuiza@colosa.com>
Date: Thu, 23 Apr 2015 16:35:26 -0400
Subject: [PATCH 07/16] PM-2433

Admin>Settings>Email Servers: En Windwos Server 2012 nos dice que falta una tabla al crear una configuracion de email

problema: al momento de instalar PM, no se creaba la tabla "APP_MESSAGE" debido que se tenia un default value definido en un campo de tipo BLOB/TEXT.
EL default value en windows genera un error, en otras plataformas solo una alerta,

solucion: Se cambio le modo de sql a otro que no ejecuta errores.
---
 workflow/engine/data/mysql/schema.sql | 1 +
 1 file changed, 1 insertion(+)

diff --git a/workflow/engine/data/mysql/schema.sql b/workflow/engine/data/mysql/schema.sql
index 22fa6d65d..20d16b974 100755
--- a/workflow/engine/data/mysql/schema.sql
+++ b/workflow/engine/data/mysql/schema.sql
@@ -2,6 +2,7 @@
 # This is a fix for InnoDB in MySQL >= 4.1.x
 # It "suspends judgement" for fkey relationships until are tables are set.
 SET FOREIGN_KEY_CHECKS = 0;
+SET @@global.sql_mode='MYSQL40';
 
 #-----------------------------------------------------------------------------
 #-- APPLICATION

From 92b4b028be2d328c4dc9ac3e69efbe5d59ddbc72 Mon Sep 17 00:00:00 2001
From: Victor Saisa Lopez <victor@colosa.com>
Date: Fri, 24 Apr 2015 12:45:30 -0400
Subject: [PATCH 08/16] PM-2430 "Admin > Users > Authentication Sources > New:
 Se..." SOLVED

Issue:
    Admin > Users > Authentication Sources > New: Se muestra la opcion del plugin
    ldapAdvanced aun cuando este esta en estado "Disable" en el workspace
Cause:
    No se verifica si el plugin esta enabled/disabled
Solution:
    Se verifica si el plugin esta enabled/disabled
---
 .../engine/classes/class.pluginRegistry.php   | 21 +++++++---------
 .../methods/authSources/authSources_Ajax.php  | 24 +++++++++++++++----
 2 files changed, 28 insertions(+), 17 deletions(-)

diff --git a/workflow/engine/classes/class.pluginRegistry.php b/workflow/engine/classes/class.pluginRegistry.php
index e6a24a476..27248d4fa 100755
--- a/workflow/engine/classes/class.pluginRegistry.php
+++ b/workflow/engine/classes/class.pluginRegistry.php
@@ -399,22 +399,19 @@ class PMPluginRegistry
     }
 
     /**
-     * get status plugin in the singleton
+     * Get status plugin in the singleton
      *
-     * @param unknown_type $sNamespace
+     * @param string $name Plugin name
+     *
+     * return mixed Return a string with status plugin, 0 otherwise
      */
-    public function getStatusPlugin ($sNamespace)
+    public function getStatusPlugin($name)
     {
-        foreach ($this->_aPluginDetails as $namespace => $detail) {
-            if ($sNamespace == $namespace) {
-                if ($this->_aPluginDetails[$sNamespace]->enabled) {
-                    return 'enabled';
-                } else {
-                    return 'disabled';
-                }
-            }
+        try {
+            return (isset($this->_aPluginDetails[$name]))? (($this->_aPluginDetails[$name]->enabled)? "enabled" : "disabled") : 0;
+        } catch (Excepton $e) {
+            throw $e;
         }
-        return 0;
     }
 
     /**
diff --git a/workflow/engine/methods/authSources/authSources_Ajax.php b/workflow/engine/methods/authSources/authSources_Ajax.php
index 5e2dbb57b..edf936350 100755
--- a/workflow/engine/methods/authSources/authSources_Ajax.php
+++ b/workflow/engine/methods/authSources/authSources_Ajax.php
@@ -149,16 +149,30 @@ try {
             }
             break;
         case 'authSourcesNew':
+            $pluginRegistry = &PMPluginRegistry::getSingleton();
+
             $arr = Array ();
             $oDirectory = dir( PATH_RBAC . 'plugins' . PATH_SEP );
-            $aAuthSourceTypes = array ();
+
             while ($sObject = $oDirectory->read()) {
                 if (($sObject != '.') && ($sObject != '..') && ($sObject != '.svn') && ($sObject != 'ldap')) {
                     if (is_file( PATH_RBAC . 'plugins' . PATH_SEP . $sObject )) {
-                        $sType = trim( str_replace( 'class.', '', str_replace( '.php', '', $sObject ) ) );
-                        $aAuthSourceTypes['sType'] = $sType;
-                        $aAuthSourceTypes['sLabel'] = $sType;
-                        $arr[] = $aAuthSourceTypes;
+                        $sType = trim(str_replace(array("class.", ".php"), "", $sObject));
+
+                        $statusPlugin = $pluginRegistry->getStatusPlugin($sType);
+                        $flagAdd = false;
+
+                        if (preg_match("/^(?:enabled|disabled)$/", $statusPlugin)) {
+                            if ($statusPlugin == "enabled") {
+                                $flagAdd = true;
+                            }
+                        } else {
+                            $flagAdd = true;
+                        }
+
+                        if ($flagAdd) {
+                            $arr[] = array("sType" => $sType, "sLabel" => $sType);
+                        }
                     }
                 }
             }

From 55363137410e9acb61289719c2271a69cbc8c8b3 Mon Sep 17 00:00:00 2001
From: dheeyi <dheeyi@gmail.com>
Date: Fri, 24 Apr 2015 12:47:33 -0400
Subject: [PATCH 09/16] se definio un tamano maximo de 100 mismo que es
 definida en la base de datos

---
 workflow/engine/xmlform/login/forgotPasswordpm3.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/workflow/engine/xmlform/login/forgotPasswordpm3.xml b/workflow/engine/xmlform/login/forgotPasswordpm3.xml
index 98122fc1f..60d8b9b6f 100755
--- a/workflow/engine/xmlform/login/forgotPasswordpm3.xml
+++ b/workflow/engine/xmlform/login/forgotPasswordpm3.xml
@@ -6,7 +6,7 @@
   <USR_USERNAME type="text" size="30" maxlength="50" required="true" validate="Any" autocomplete="0">
     <en><![CDATA[User]]></en>
   </USR_USERNAME>
-  <USR_EMAIL type="text" size="30" required="true" maxlength="254"  autocomplete="0">
+  <USR_EMAIL type="text" size="30" required="true" maxlength="100"  autocomplete="0">
     <en><![CDATA[Email]]></en>
   </USR_EMAIL>
   <URL type="hidden"/>

From 44d7a1e0eae2fb558c2f64c6b1b6ae8e4677b095 Mon Sep 17 00:00:00 2001
From: Victor Saisa Lopez <victor@colosa.com>
Date: Fri, 24 Apr 2015 14:09:22 -0400
Subject: [PATCH 10/16] PM-2409 "No muestra ningun mensaje de error al
 ejecutar..." SOLVED

Issue:
    No muestra ningun mensaje de error al ejecutar messageeventcron.php con un workspace inexistente
Cause:
    No se valida el workspace
Solution:
    Se agrega validacion para verificar si el workspace existe, esto para:
        - cron.php
        - messageeventcron.php
---
 workflow/engine/bin/cron.php             | 8 ++++++--
 workflow/engine/bin/messageeventcron.php | 4 ++++
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/workflow/engine/bin/cron.php b/workflow/engine/bin/cron.php
index 4e0932e73..9ab67a4ad 100755
--- a/workflow/engine/bin/cron.php
+++ b/workflow/engine/bin/cron.php
@@ -5,7 +5,7 @@
  */
 
 if ( !defined('PATH_SEP') ) {
-  define('PATH_SEP', ( substr(PHP_OS, 0, 3) == 'WIN' ) ? '\\' : '/');
+    define("PATH_SEP", (substr(PHP_OS, 0, 3) == "WIN")? "\\" : "/");
 }
 
 $docuroot = explode(PATH_SEP, str_replace('engine' . PATH_SEP . 'methods' . PATH_SEP . 'services', '', dirname(__FILE__)));
@@ -129,7 +129,7 @@ if ($force || !$bCronIsRunning) {
             $oDirectory = dir(PATH_DB);
             $cws = 0;
 
-            while($sObject = $oDirectory->read()) {
+            while (($sObject = $oDirectory->read()) !== false) {
                 if (($sObject != ".") && ($sObject != "..")) {
                     if (is_dir(PATH_DB . $sObject)) {
                         if (file_exists(PATH_DB . $sObject . PATH_SEP . "db.php")) {
@@ -141,6 +141,10 @@ if ($force || !$bCronIsRunning) {
                 }
             }
         } else {
+            if (!is_dir(PATH_DB . $ws) || !file_exists(PATH_DB . $ws . PATH_SEP . "db.php")) {
+                throw new Exception("Error: The workspace \"$ws\" does not exist");
+            }
+
             $cws = 1;
 
             system("php -f \"" . dirname(__FILE__) . PATH_SEP . "cron_single.php\" $ws \"$sDate\" \"$dateSystem\" $argsx", $retval);
diff --git a/workflow/engine/bin/messageeventcron.php b/workflow/engine/bin/messageeventcron.php
index e8d1d9a50..4d884768d 100644
--- a/workflow/engine/bin/messageeventcron.php
+++ b/workflow/engine/bin/messageeventcron.php
@@ -114,6 +114,10 @@ try {
                     }
                 }
             } else {
+                if (!is_dir(PATH_DB . $workspace) || !file_exists(PATH_DB . $workspace . PATH_SEP . "db.php")) {
+                    throw new Exception("Error: The workspace \"$workspace\" does not exist");
+                }
+
                 $countw++;
 
                 passthru("php -f \"$messageEventCronSinglePath\" $workspace \"" . base64_encode(PATH_HOME) . "\" \"" . base64_encode(PATH_TRUNK) . "\" \"" . base64_encode(PATH_OUTTRUNK) . "\"");

From 1a8c76daba6df611e8c58e6410a75398196cb768 Mon Sep 17 00:00:00 2001
From: Brayan Pereyra <brayan@colosa.com>
Date: Fri, 24 Apr 2015 14:17:17 -0400
Subject: [PATCH 11/16] PM-2344 Adicion de validacion al momento de borrar un
 caso

---
 .../engine/methods/cases/casesListExtJs.php   |  6 ++++++
 .../src/ProcessMaker/BusinessModel/Cases.php  | 20 ++++++++++++++++++-
 .../src/ProcessMaker/Services/Api/Cases.php   |  3 ++-
 3 files changed, 27 insertions(+), 2 deletions(-)

diff --git a/workflow/engine/methods/cases/casesListExtJs.php b/workflow/engine/methods/cases/casesListExtJs.php
index 7d86cf9b0..48e7560e3 100755
--- a/workflow/engine/methods/cases/casesListExtJs.php
+++ b/workflow/engine/methods/cases/casesListExtJs.php
@@ -42,6 +42,12 @@ switch ($action) {
         $urlProxy = 'proxyCasesList';
         $action = 'unassigned';
         break;
+    case 'to_revise':
+        $urlProxy = 'proxyCasesList';
+        break;
+    case 'to_reassign':
+        $urlProxy = 'proxyCasesList';
+        break;
 }
 /*----------------------------------********---------------------------------*/
 
diff --git a/workflow/engine/src/ProcessMaker/BusinessModel/Cases.php b/workflow/engine/src/ProcessMaker/BusinessModel/Cases.php
index 60f790ddf..56a1ac627 100644
--- a/workflow/engine/src/ProcessMaker/BusinessModel/Cases.php
+++ b/workflow/engine/src/ProcessMaker/BusinessModel/Cases.php
@@ -861,15 +861,33 @@ class Cases
      *
      * @access public
      * @param string $app_uid, Uid for case
+     * @param string $usr_uid, Uid user
      * @return array
      *
      * @author Brayan Pereyra (Cochalo) <brayan@colosa.com>
      * @copyright Colosa - Bolivia
      */
-    public function deleteCase($app_uid)
+    public function deleteCase($app_uid, $usr_uid)
     {
         Validator::isString($app_uid, '$app_uid');
         Validator::appUid($app_uid, '$app_uid');
+
+        $criteria = new \Criteria();
+        $criteria->addSelectColumn( \ApplicationPeer::APP_STATUS );
+        $criteria->addSelectColumn( \ApplicationPeer::APP_INIT_USER );
+        $criteria->add( \ApplicationPeer::APP_UID, $app_uid, \Criteria::EQUAL );
+        $dataset = \ApplicationPeer::doSelectRS($criteria);
+        $dataset->setFetchmode(\ResultSet::FETCHMODE_ASSOC);
+        $dataset->next();
+        $aRow = $dataset->getRow();
+        if ($aRow['APP_STATUS'] != 'DRAFT') {
+            throw (new \Exception(\G::LoadTranslation("ID_DELETE_CASE_NO_STATUS")));
+        }
+
+        if ($aRow['APP_INIT_USER'] != $usr_uid) {
+            throw (new \Exception(\G::LoadTranslation("ID_DELETE_CASE_NO_OWNER")));
+        }
+
         $case = new \Cases();
         $case->removeCase( $app_uid );
     }
diff --git a/workflow/engine/src/ProcessMaker/Services/Api/Cases.php b/workflow/engine/src/ProcessMaker/Services/Api/Cases.php
index 00c92a0f6..6a65fc7b4 100644
--- a/workflow/engine/src/ProcessMaker/Services/Api/Cases.php
+++ b/workflow/engine/src/ProcessMaker/Services/Api/Cases.php
@@ -809,8 +809,9 @@ class Cases extends Api
     public function doDeleteCase($cas_uid)
     {
         try {
+            $usr_uid = $this->getUserId();
             $cases = new \ProcessMaker\BusinessModel\Cases();
-            $cases->deleteCase($cas_uid);
+            $cases->deleteCase($cas_uid, $usr_uid);
         } catch (\Exception $e) {
             throw (new RestException(Api::STAT_APP_EXCEPTION, $e->getMessage()));
         }

From d9b1c9b019a301a52c9634cfd6ff89cfae2a93b4 Mon Sep 17 00:00:00 2001
From: "marcelo.cuiza" <marcelo.cuiza@colosa.com>
Date: Fri, 24 Apr 2015 14:34:06 -0400
Subject: [PATCH 12/16] PM-2316

Admin>Settings>Users: En Grupos y Departamentos al querer crear con espacios en blanco no despliega mensaje de campos requerido

se aumento validacion y mensaje
---
 workflow/engine/templates/departments/departmentList.js | 5 +++++
 workflow/engine/templates/groups/groupsList.js          | 8 +++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/workflow/engine/templates/departments/departmentList.js b/workflow/engine/templates/departments/departmentList.js
index 1d39938e4..a1e21b5ea 100755
--- a/workflow/engine/templates/departments/departmentList.js
+++ b/workflow/engine/templates/departments/departmentList.js
@@ -317,6 +317,11 @@ CloseWindow = function(){
   Ext.getCmp('w').hide();
 };
 SaveNewDepartment = function(){
+  if( newForm.getForm().findField('dep_name').getValue().trim() == "") {
+    Ext.Msg.alert(_('ID_WARNING'), _("ID_FIELD_REQUIRED", _("ID_DEPARTMENT_NAME")));
+    newForm.getForm().findField('dep_name').setValue("");
+    return false;
+  }  
   waitLoading.show();
   var dep_node = Ext.getCmp('treePanel').getSelectionModel().getSelectedNode();
   if (dep_node) dep_node.unselect();
diff --git a/workflow/engine/templates/groups/groupsList.js b/workflow/engine/templates/groups/groupsList.js
index 2844375d7..1b38439bc 100755
--- a/workflow/engine/templates/groups/groupsList.js
+++ b/workflow/engine/templates/groups/groupsList.js
@@ -182,7 +182,13 @@ Ext.onReady(function(){
             text: _("ID_SAVE"),
             handler: function (btn, ev)
             {
-                Ext.getCmp("btnCreateSave").setDisabled(true);
+                if( newForm.getForm().findField('name').getValue().trim() == "") {
+                    Ext.Msg.alert(_('ID_WARNING'), _("ID_FIELD_REQUIRED", _("ID_GROUP_NAME")));
+                    newForm.getForm().findField('name').setValue("");
+                    return false;
+                } else {
+                    Ext.getCmp("btnCreateSave").setDisabled(true);
+                }
 
                 SaveNewGroupAction();
             }

From ebb2c4534d308a1d311a758174f8d5cf3a77d950 Mon Sep 17 00:00:00 2001
From: rodrigo quelca <rodrigo@colosa.com>
Date: Fri, 24 Apr 2015 15:47:37 -0400
Subject: [PATCH 13/16] =?UTF-8?q?PM-2384=20Al=20importar=20un=20proceso=20?=
 =?UTF-8?q?que=20contiene=20elementos=20no=20soportados=20en=20IE=20se=20a?=
 =?UTF-8?q?bre=20en=20el=20mismo=20dise=C3=B1ador?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 workflow/engine/templates/processes/main.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/workflow/engine/templates/processes/main.js b/workflow/engine/templates/processes/main.js
index ef7e95f59..81afbfe15 100755
--- a/workflow/engine/templates/processes/main.js
+++ b/workflow/engine/templates/processes/main.js
@@ -1402,7 +1402,11 @@ importProcessBpmnSubmit = function () {
                     return;
                 }
                 Ext.getCmp('importProcessWindow').close();
-                window.location.href = "../designer?prj_uid=" + resp_.prj_uid;
+                if (typeof(importProcessGlobal.processFileType) != "undefined" && importProcessGlobal.processFileType == "bpmn") {
+                    openWindowIfIE("../designer?prj_uid=" + resp_.prj_uid);
+                } else {
+                    window.location.href = "processes_Map?PRO_UID=" + resp_.prj_uid;
+                }
             },
             failure: function (o, resp) {
                 Ext.getCmp('importProcessWindow').close();

From 3e0fba2d2d445bb46e87624712384705e9905148 Mon Sep 17 00:00:00 2001
From: Brayan Pereyra <brayan@colosa.com>
Date: Fri, 24 Apr 2015 16:18:07 -0400
Subject: [PATCH 14/16] PM-2263 Se corregio el almacenado de un start event sin
 task

---
 .../src/ProcessMaker/Project/Adapter/BpmnWorkflow.php    | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/workflow/engine/src/ProcessMaker/Project/Adapter/BpmnWorkflow.php b/workflow/engine/src/ProcessMaker/Project/Adapter/BpmnWorkflow.php
index 0235e922c..cefb56f9f 100755
--- a/workflow/engine/src/ProcessMaker/Project/Adapter/BpmnWorkflow.php
+++ b/workflow/engine/src/ProcessMaker/Project/Adapter/BpmnWorkflow.php
@@ -497,7 +497,10 @@ class BpmnWorkflow extends Project\Bpmn
                             //Setting as start Task
                             //or
                             //Remove as start Task
-                            $this->wp->setStartTask($arrayFlowData["FLO_ELEMENT_DEST"], $flagStartTask);
+                            $bwp = new self;
+                            if ($bwp->getActivity($arrayFlowData["FLO_ELEMENT_DEST"])) {
+                                $this->wp->setStartTask($arrayFlowData["FLO_ELEMENT_DEST"], $flagStartTask);
+                            }
                             break;
                     }
                 }
@@ -1384,6 +1387,10 @@ class BpmnWorkflow extends Project\Bpmn
 
             $activity = $bwp->getActivity($activityData["ACT_UID"]);
 
+            if ($activity["BOU_CONTAINER"] != $activityData["BOU_CONTAINER"]) {
+                $activity = null;
+            }
+
             if ($forceInsert || is_null($activity)) {
                 if ($generateUid) {
                     //Generate and update UID

From 34dd15070a14f1f9d607c9ad0388dfa88377883f Mon Sep 17 00:00:00 2001
From: "Paula V. Quispe" <paula.quispe@colosa.com>
Date: Fri, 24 Apr 2015 20:13:02 -0400
Subject: [PATCH 15/16] PM-2378: I deleted the requerid field in licenseExpired

---
 workflow/engine/xmlform/login/licenseExpiredpm3.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/workflow/engine/xmlform/login/licenseExpiredpm3.html b/workflow/engine/xmlform/login/licenseExpiredpm3.html
index 2f57e2d0f..3f5531645 100644
--- a/workflow/engine/xmlform/login/licenseExpiredpm3.html
+++ b/workflow/engine/xmlform/login/licenseExpiredpm3.html
@@ -16,7 +16,7 @@
         {$form.updateButton}                
     </fieldset>
 
-    <div class="FormRequiredTextMessage"><font color="red">*  </font>Required Field</div>       </div>
+    <div class="FormRequiredTextMessage"></div>
        <div class="boxBottom"><div class="a">&nbsp;</div><div class="b">&nbsp;</div><div class="c">&nbsp;</div></div>
        </div>
     <script type="text/javascript">      

From 609b39cba4e53aebd8ac930b34a41cbc69a3610c Mon Sep 17 00:00:00 2001
From: Richard Yujra <richard.yujra@colosa.com>
Date: Mon, 27 Apr 2015 10:07:16 -0400
Subject: [PATCH 16/16] PM-2346 resolved

---
 .../engine/skinEngine/neoclassic/layout.html  |  2 +-
 .../engine/templates/processes/mainLoad.php   | 33 +++++++++++++++----
 2 files changed, 27 insertions(+), 8 deletions(-)

diff --git a/workflow/engine/skinEngine/neoclassic/layout.html b/workflow/engine/skinEngine/neoclassic/layout.html
index a2996d5ba..3c8649a41 100644
--- a/workflow/engine/skinEngine/neoclassic/layout.html
+++ b/workflow/engine/skinEngine/neoclassic/layout.html
@@ -15,7 +15,7 @@
               <tr>
                   {if $user_logged neq '' or $tracker neq ''}
                   <td rowspan="2" style="vertical-align:top;width: 245px;"><img src="{$logo_company}" class="logo_company"/></td>
-                  <td class="mainMenuBG" rowspan="2" valign="center" >
+                  <td id="mainMenuBG" class="mainMenuBG" rowspan="2" valign="center" >
                       {include file="$tpl_menu"}
                       {if (count($subMenus)>0) }
                           {include file= "$tpl_submenu"}
diff --git a/workflow/engine/templates/processes/mainLoad.php b/workflow/engine/templates/processes/mainLoad.php
index 2e73d2dc4..940b627ef 100755
--- a/workflow/engine/templates/processes/mainLoad.php
+++ b/workflow/engine/templates/processes/mainLoad.php
@@ -25,13 +25,32 @@
     document.getElementById('pm_submenu').style.display = 'none';
   document.documentElement.style.overflowY = 'hidden';
   function autoResizeScreen() {
-    oCasesFrame    = document.getElementById('frameMain');
-    oClientWinSize = getClientWindowSize();
-    height = oClientWinSize.height-105;
-    oCasesFrame.style.height = height;
-    if (oCasesFrame.height ) {
-    	oCasesFrame.height = height;
-    }
+  	var containerList1, containerList2;
+    oCasesFrame = document.getElementById('frameMain');
+	containerList1 = document.getElementById("pm_header");
+	if (document.getElementById("mainMenuBG") && 
+		document.getElementById("mainMenuBG").parentNode &&
+		document.getElementById("mainMenuBG").parentNode.parentNode &&
+		document.getElementById("mainMenuBG").parentNode.parentNode.parentNode &&
+		document.getElementById("mainMenuBG").parentNode.parentNode.parentNode.parentNode
+		){
+			containerList2 = document.getElementById("mainMenuBG").parentNode.parentNode.parentNode.parentNode;			
+		}
+	if (containerList1 === containerList2) {
+		height = oClientWinSize.height - containerList1.clientHeight;
+		oCasesFrame.style.height = height;
+		if (oCasesFrame.height ) {
+			oCasesFrame.height = height;
+		}
+	} else {
+	    oCasesFrame    = document.getElementById('frameMain');
+		oClientWinSize = getClientWindowSize();
+		height = oClientWinSize.height-105;
+		oCasesFrame.style.height = height;
+		if (oCasesFrame.height ) {
+			oCasesFrame.height = height;
+		}		
+	}
     //oCasesSubFrame = oCasesFrame.contentWindow.document.getElementById('casesSubFrame');
     //oCasesSubFrame.style.height = height-10;
   }