diff --git a/database/factories/DocumentsFactory.php b/database/factories/DocumentsFactory.php index acfafb0ce..f4ef0429f 100644 --- a/database/factories/DocumentsFactory.php +++ b/database/factories/DocumentsFactory.php @@ -28,7 +28,7 @@ $factory->define(\ProcessMaker\Model\Documents::class, function (Faker $faker) { ]; }); -// Create a dynaform with the foreign keys +// Create a document related to the case notes $factory->state(\ProcessMaker\Model\Documents::class, 'case_notes', function (Faker $faker) { return [ 'APP_DOC_UID' => G::generateUniqueID(), diff --git a/workflow/engine/classes/WsBase.php b/workflow/engine/classes/WsBase.php index 48330d1cd..dd84fcc3c 100644 --- a/workflow/engine/classes/WsBase.php +++ b/workflow/engine/classes/WsBase.php @@ -1,6 +1,7 @@ addNote($caseUid, $userUid, $note, $sendMail, $files); //Response diff --git a/workflow/engine/classes/model/AppNotes.php b/workflow/engine/classes/model/AppNotes.php index 823096a79..4ecece2d9 100644 --- a/workflow/engine/classes/model/AppNotes.php +++ b/workflow/engine/classes/model/AppNotes.php @@ -231,7 +231,7 @@ class AppNotes extends BaseAppNotes } if (!empty($attachFileLinks)) { - $body = $body . "
" . G::LoadTranslation('ID_ATTACHED_FILES') . ": 
" . implode("
", $attachFileLinks); + $body = $body . "
" . G::LoadTranslation('ID_ATTACHED_FILES') . ": 
" . implode("
", $attachFileLinks); } $users = new Users(); $recipientsArray = explode(",", $noteRecipients); diff --git a/workflow/engine/src/ProcessMaker/BusinessModel/Cases.php b/workflow/engine/src/ProcessMaker/BusinessModel/Cases.php index 372ac5b14..b021baa02 100644 --- a/workflow/engine/src/ProcessMaker/BusinessModel/Cases.php +++ b/workflow/engine/src/ProcessMaker/BusinessModel/Cases.php @@ -3858,7 +3858,6 @@ class Cases * @param array $files * * @return array - * @throws Exception */ public function addNote($appUid, $userUid, $note, $sendMail = false, $files = []) { @@ -3925,7 +3924,7 @@ class Cases * @param string $userUid * @param string $appUid * @param array $filesReferences - * @param string $appDocUid + * @param int $noteId * * @return array * @throws Exception diff --git a/workflow/engine/src/ProcessMaker/Util/helpers.php b/workflow/engine/src/ProcessMaker/Util/helpers.php index e63d20a30..dac3f1644 100644 --- a/workflow/engine/src/ProcessMaker/Util/helpers.php +++ b/workflow/engine/src/ProcessMaker/Util/helpers.php @@ -609,6 +609,7 @@ function getMysqlVersion() * @param string $appUid * @param string $appDocUid * @param int $version + * @param bool $upload * * @return string */