From b507788b33a75d536f2018fb0430824977a1273b Mon Sep 17 00:00:00 2001
From: Fabio Guachalla <fabio.guachalla@processmaker.com>
Date: Fri, 13 May 2022 12:43:49 -0400
Subject: [PATCH] PMCORE-3812:Ada compliant in Extjs

Code Style

gulliver

dialog

CR

Corrections

CR 2
---
 .../js/home/TaskMetrics/ProcessPopover.vue    |   3 +-
 .../methods/appFolder/appFolderAjax.php       |   8 +-
 .../neoclassic/css/pmos-xtheme-gray.css       |   6 +
 workflow/engine/templates/app/main.js         |   2 +
 .../engine/templates/cases/caseHistory.js     |  11 +-
 .../cases/caseHistoryDynaformPage.js          |  12 +-
 .../templates/cases/caseMessageHistory.js     |  11 +-
 .../engine/templates/cases/casesDocuments.js  |  23 +-
 .../cases/casesGenerateDocumentPage.js        |  11 +-
 workflow/engine/templates/cases/casesList.js  |  13 +-
 .../cases/casesUploadedDocumentsPage.js       |  13 +-
 workflow/engine/templates/cases/open.js       | 217 +++++++++++++++---
 .../templates/oauth2/applicationsLoad.php     |   2 +-
 .../cases/cases_ViewOutputDocument1.xml       |  19 +-
 14 files changed, 293 insertions(+), 58 deletions(-)

diff --git a/resources/assets/js/home/TaskMetrics/ProcessPopover.vue b/resources/assets/js/home/TaskMetrics/ProcessPopover.vue
index 8e494f038..f889b4c6f 100644
--- a/resources/assets/js/home/TaskMetrics/ProcessPopover.vue
+++ b/resources/assets/js/home/TaskMetrics/ProcessPopover.vue
@@ -21,7 +21,8 @@
             v-model="text"
             aria-label="search"
           />
-        </div>        <div class="form-check border-bottom">
+        </div>
+        <div class="form-check border-bottom">
           <input
             class="form-check-input"
             type="checkbox"
diff --git a/workflow/engine/methods/appFolder/appFolderAjax.php b/workflow/engine/methods/appFolder/appFolderAjax.php
index ad1b83e93..fb05e178a 100644
--- a/workflow/engine/methods/appFolder/appFolderAjax.php
+++ b/workflow/engine/methods/appFolder/appFolderAjax.php
@@ -1635,14 +1635,16 @@ function newFolder()
     $formNewFolder["items"]= array();
 
     $field=array();
-    $field["xtype"]= "label";
+    $field["xtype"]= "textfield";
     $field["fieldLabel"]= G::LoadTranslation('ID_CREATE_FOLDER_PATH_FOLDER');
-    $field["name"]= "form[FOLDER_PATH]";
-    $field["id"]= "form[FOLDER_PATH]";
+    $field["name"]= "FOLDER_PATH";
+    $field["id"]= "FOLDER_PATH";
     $field["width"]=175;
     $field["allowBlank"]=false;
     $field["value"]=$folderPath;
     $field["text"]=$folderPath;
+    $field["readOnly"]= true;
+    $field["style"] = "{'border': 'none'}";
     $formNewFolder["items"][]= $field;
 
     $field=array();
diff --git a/workflow/engine/skinEngine/neoclassic/css/pmos-xtheme-gray.css b/workflow/engine/skinEngine/neoclassic/css/pmos-xtheme-gray.css
index c2432451d..a97c089f6 100644
--- a/workflow/engine/skinEngine/neoclassic/css/pmos-xtheme-gray.css
+++ b/workflow/engine/skinEngine/neoclassic/css/pmos-xtheme-gray.css
@@ -329,6 +329,12 @@ button.x-btn-text:focus,
   background-image: url(/skins/neoclassic/images/icons_silk/sprites.png);
   height: 18px;
 }
+#FOLDER_PATH{
+  border: none;
+  background-image: none;
+  background-color: #f1f1f1;
+  cursor: default;
+}
 .ICON_FOLDERS {
   /*.ss_folder_explore*/
 
diff --git a/workflow/engine/templates/app/main.js b/workflow/engine/templates/app/main.js
index 432a68563..2c9769d09 100644
--- a/workflow/engine/templates/app/main.js
+++ b/workflow/engine/templates/app/main.js
@@ -398,6 +398,7 @@ function newNoteHandler() {
     });
 
     Ext.getCmp('addCancelBtn').setIcon('/images/comment_add.gif');
+    Ext.getCmp('addCancelBtn').btnEl.dom.ariaLabel = _('ID_CASES_NOTES_ADD');
 
     caseNotesWindow.getTopToolbar().hide();
     Ext.getCmp("chkSendMail").hide();
@@ -411,6 +412,7 @@ function newNoteHandler() {
     Ext.getCmp('addCancelBtn').setText('');
     Ext.getCmp('addCancelBtn').setTooltip({ title: _('ID_CASES_NOTES_CANCEL') });
     Ext.getCmp('addCancelBtn').setIcon('/images/cancel.png');
+    Ext.getCmp('addCancelBtn').btnEl.dom.ariaLabel = _('ID_CASES_NOTES_CANCEL');
 
     caseNotesWindow.getTopToolbar().show();
     Ext.getCmp("chkSendMail").show();
diff --git a/workflow/engine/templates/cases/caseHistory.js b/workflow/engine/templates/cases/caseHistory.js
index 4dcf45717..70ef1f309 100644
--- a/workflow/engine/templates/cases/caseHistory.js
+++ b/workflow/engine/templates/cases/caseHistory.js
@@ -89,11 +89,18 @@
     );
 
     Ext.onReady(function(){
+      var i;
       Ext.state.Manager.setProvider(new Ext.state.CookieProvider());
       Ext.QuickTips.init();
-
       historyGridList();
-
+      if (document.getElementsByTagName('input')) {
+        document.getElementsByTagName('input')[0].ariaLabel = "pagination";
+      }
+      if (document.getElementsByTagName('button')) {
+        for (i = 0; i < document.getElementsByTagName('button').length; i+= 1) {
+          document.getElementsByTagName('button')[i].ariaLabel = document.getElementsByTagName('button')[i].getAttribute('id');
+        } 
+      }
     });
 
     //!historyGridList|
diff --git a/workflow/engine/templates/cases/caseHistoryDynaformPage.js b/workflow/engine/templates/cases/caseHistoryDynaformPage.js
index 2e5591656..2d85d43b9 100644
--- a/workflow/engine/templates/cases/caseHistoryDynaformPage.js
+++ b/workflow/engine/templates/cases/caseHistoryDynaformPage.js
@@ -222,12 +222,20 @@
       }
     );
 
-    Ext.onReady(function(){
+    Ext.onReady(function() {
+      var i;
       Ext.state.Manager.setProvider(new Ext.state.CookieProvider());
       Ext.QuickTips.init();
 
       historyDynaformGrid();
-
+      if (document.getElementsByTagName('input')) {
+        document.getElementsByTagName('input')[0].ariaLabel = "pagination";
+      }
+      if (document.getElementsByTagName('button')) {
+        for (i = 0; i < document.getElementsByTagName('button').length; i+= 1) {
+          document.getElementsByTagName('button')[i].ariaLabel = document.getElementsByTagName('button')[i].getAttribute('id');
+        }
+      }
     });
 
   var historyDynaformGridPreviewGlobal = {};
diff --git a/workflow/engine/templates/cases/caseMessageHistory.js b/workflow/engine/templates/cases/caseMessageHistory.js
index ba7ca255d..354c550f1 100644
--- a/workflow/engine/templates/cases/caseMessageHistory.js
+++ b/workflow/engine/templates/cases/caseMessageHistory.js
@@ -217,11 +217,18 @@ var ActionTabFrameGlobal = '';
     );
 
     Ext.onReady(function(){
+      var i;
       Ext.state.Manager.setProvider(new Ext.state.CookieProvider());
       Ext.QuickTips.init();
-
       messageHistoryGridList();
-
+      if (document.getElementsByTagName('input')) {
+        document.getElementsByTagName('input')[0].ariaLabel = "pagination";
+      }
+      if (document.getElementsByTagName('button')) {
+        for (i = 0; i < document.getElementsByTagName('button').length; i+= 1) {
+          document.getElementsByTagName('button')[i].ariaLabel = document.getElementsByTagName('button')[i].getAttribute('id');
+        } 
+      }
     });
 
     //!historyGridList|
diff --git a/workflow/engine/templates/cases/casesDocuments.js b/workflow/engine/templates/cases/casesDocuments.js
index 329385b6e..48b39df0d 100644
--- a/workflow/engine/templates/cases/casesDocuments.js
+++ b/workflow/engine/templates/cases/casesDocuments.js
@@ -2092,11 +2092,11 @@ var documentsTab = {
 
 };
 Ext.onReady(function() {
-
-  var viewport = new Ext.Viewport({
-    layout : 'border',
-    items: [treepanelmain, documentsTab]
-  });
+  var i,
+    viewport = new Ext.Viewport({
+      layout : 'border',
+      items: [treepanelmain, documentsTab]
+    });
 
   // console.info("viewport -end");
 
@@ -2108,5 +2108,16 @@ Ext.onReady(function() {
     parent.Ext.getCmp('debugPanel').hide();
     parent.Ext.getCmp('debugPanel').ownerCt.doLayout();
   }
-
+  if (document.getElementsByTagName('input')) {
+    document.getElementsByTagName('input')[0].ariaLabel = "filterField";
+  }
+  if (document.getElementsByTagName('input')) {
+    document.getElementsByTagName('input')[1].ariaLabel = "pagination";
+  }
+  if (document.getElementsByTagName('button')) {
+    for (i = 0; i < document.getElementsByTagName('button').length; i+= 1) {
+      document.getElementsByTagName('button')[i].ariaLabel = document.getElementsByTagName('button')[i].id;
+    }
+  }
+  
 });
diff --git a/workflow/engine/templates/cases/casesGenerateDocumentPage.js b/workflow/engine/templates/cases/casesGenerateDocumentPage.js
index 5a89766e3..24eebf129 100644
--- a/workflow/engine/templates/cases/casesGenerateDocumentPage.js
+++ b/workflow/engine/templates/cases/casesGenerateDocumentPage.js
@@ -154,11 +154,18 @@
     );
 
     Ext.onReady(function(){
+      var i;
       Ext.state.Manager.setProvider(new Ext.state.CookieProvider());
       Ext.QuickTips.init();
-
       generateDocumentGrid();
-
+      if (document.getElementsByTagName('input')) {
+        document.getElementsByTagName('input')[0].ariaLabel = "pagination";
+      }
+      if (document.getElementsByTagName('button')) {
+        for (i = 0; i < document.getElementsByTagName('button').length; i+= 1) {
+          document.getElementsByTagName('button')[i].ariaLabel = document.getElementsByTagName('button')[i].getAttribute('id');
+        }
+      }
     });
 
 
diff --git a/workflow/engine/templates/cases/casesList.js b/workflow/engine/templates/cases/casesList.js
index 150dd4c8a..ab163edce 100644
--- a/workflow/engine/templates/cases/casesList.js
+++ b/workflow/engine/templates/cases/casesList.js
@@ -2784,8 +2784,17 @@ Ext.onReady ( function() {
         }
     });
 // Add the additional 'advanced' VTypes -- [End]
-
-
+    var i;
+    if (document.getElementsByTagName('input')) {
+        for (i = 0; i < document.getElementsByTagName('input').length; i+= 1) {
+            document.getElementsByTagName('input')[i].ariaLabel = document.getElementsByTagName('input')[i].id;
+        }
+    }
+    if (document.getElementsByTagName('button')) {
+        for (i = 0; i < document.getElementsByTagName('button').length; i+= 1) {
+            document.getElementsByTagName('button')[i].ariaLabel = document.getElementsByTagName('button')[i].id;
+        }
+    }
 });
 
 function msgBox(title, msg, type){
diff --git a/workflow/engine/templates/cases/casesUploadedDocumentsPage.js b/workflow/engine/templates/cases/casesUploadedDocumentsPage.js
index e7af764f6..ff4e87b83 100644
--- a/workflow/engine/templates/cases/casesUploadedDocumentsPage.js
+++ b/workflow/engine/templates/cases/casesUploadedDocumentsPage.js
@@ -260,12 +260,19 @@
       }
     );
 
-    Ext.onReady(function(){
+    Ext.onReady(function() {
+      var i;
       Ext.state.Manager.setProvider(new Ext.state.CookieProvider());
       Ext.QuickTips.init();
-
       uploadDocumentGrid();
-
+      if (document.getElementsByTagName('input')) {
+        document.getElementsByTagName('input')[0].ariaLabel = "pagination";
+      }
+      if (document.getElementsByTagName('button')) {
+        for (i = 0; i < document.getElementsByTagName('button').length; i+= 1) {
+          document.getElementsByTagName('button')[i].ariaLabel = document.getElementsByTagName('button')[i].getAttribute('id');
+        }
+      }
     });
 
 
diff --git a/workflow/engine/templates/cases/open.js b/workflow/engine/templates/cases/open.js
index d4c09e5b5..e34d7f25b 100644
--- a/workflow/engine/templates/cases/open.js
+++ b/workflow/engine/templates/cases/open.js
@@ -392,7 +392,11 @@ Ext.onReady(function(){
             items:[{
               id: 'casesTab',
               title: _('ID_CASE') +' ' + _APP_NUM,
-              frameConfig:{name:'openCaseFrame', id:'openCaseFrame'},
+              frameConfig:{
+                name:'openCaseFrame',
+                id:'openCaseFrame',
+                title:'openCaseFrame'
+              },
               defaultSrc : uri,
               loadMask:{msg: _('ID_LOADING_GRID') },
               bodyStyle:{height: (PMExt.getBrowser().screen.height-60) + 'px', overflow:'hidden'},
@@ -680,6 +684,7 @@ Ext.onReady(function(){
 	          } else {
 	              fieldset = {
 	                  xtype : 'fieldset',
+	                  title: _('ID_INFORMATION'),
 	                  autoHeight : true,
 	                  defaults : {
 	                      width : 170,
@@ -688,11 +693,66 @@ Ext.onReady(function(){
 	                      style: 'font-weight: bold'
 	                  },
 	                  items : [
-	                      {fieldLabel: _('ID_TITLE'), text: data.PRO_TITLE},
-	                      {fieldLabel: _('ID_DESCRIPTION'), text: data.PRO_DESCRIPTION},
-	                      {fieldLabel: _('ID_CATEGORY'), text: data.PRO_CATEGORY_LABEL},
-	                      {fieldLabel: _('ID_AUTHOR'), text: data.PRO_AUTHOR},
-	                      {fieldLabel: _('ID_CREATE_DATE'), text: data.PRO_CREATE_DATE}
+                      {
+                        xtype: 'textfield',
+                        fieldLabel: _('ID_TITLE'),
+                        value: data.PRO_TITLE,
+                        readOnly: true,
+                        style: {
+                          border: 'none',
+                          backgroundImage: 'none',
+                          fontWeight: 'bold',
+                          width: '170px'
+                        }
+                      },
+	                    {
+                        xtype: 'textfield',
+                        fieldLabel: _('ID_DESCRIPTION'),
+                        value: data.PRO_DESCRIPTION,
+                        readOnly: true,
+                        style: {
+                          border: 'none',
+                          backgroundImage: 'none',
+                          fontWeight: 'bold',
+                          width: '170px'
+                        }
+                      },
+	                    {
+                        xtype: 'textfield',
+                        fieldLabel: _('ID_CATEGORY'),
+                        value: data.PRO_CATEGORY_LABEL,
+                        readOnly: true,
+                        style: {
+                          border: 'none',
+                          backgroundImage: 'none',
+                          fontWeight: 'bold',
+                          width: '170px'
+                        }
+                      },
+	                    {
+                        xtype: 'textfield',
+                        fieldLabel: _('ID_AUTHOR'),
+                        value: data.PRO_AUTHOR,
+                        readOnly: true,
+                        style: {
+                          border: 'none',
+                          backgroundImage: 'none',
+                          fontWeight: 'bold',
+                          width: '170px'
+                        }
+                      },
+                      {
+                        xtype: 'textfield',
+                        fieldLabel: _('ID_CREATE_DATE'),
+                        value: data.PRO_CREATE_DATE,
+                        readOnly: true,
+                        style: {
+                          border: 'none',
+                          backgroundImage: 'none',
+                          fontWeight: 'bold',
+                          width: '170px'
+                        }
+                      }
 	                 ]
 	             }
 
@@ -755,24 +815,91 @@ Ext.onReady(function(){
 	                  }
 	              });
 	          } else {
-				fieldset = {
-				xtype : 'fieldset',
-				autoHeight : true,
-				defaults : {
-				width : 170,
-				xtype:'label',
-				labelStyle : 'padding: 0px;',
-				style: 'font-weight: bold'
-				},
-				items : [
-				{fieldLabel: _('ID_TITLE'), text: data.TAS_TITLE},
-				{fieldLabel: _('ID_DESCRIPTION'), text: data.TAS_DESCRIPTION},
-				{fieldLabel: _('ID_INIT_DATE'), text: data.INIT_DATE_LABEL},
-				{fieldLabel: _('ID_DUE_DATE'), text: data.DUE_DATE_LABEL},
-				{fieldLabel: _('ID_FINISH_DATE'), text: data.FINISH},
-				{fieldLabel: _('ID_TASK_DURATION'), text: data.DURATION}
-				]
-				}
+                fieldset = {
+                    xtype : 'fieldset',
+                    title: _('ID_INFORMATION'),
+                    autoHeight : true,
+                    defaults : {
+                    width : 170,
+				            xtype:'label',
+                    labelStyle : 'padding: 0px;',
+                    style: 'font-weight: bold'
+                },
+                items : [
+                  {
+                        xtype: 'textfield',
+                        fieldLabel: _('ID_TITLE'),
+                        value: data.TAS_TITLE,
+                        readOnly: true,
+                        style: {
+                          border: 'none',
+                          backgroundImage: 'none',
+                          fontWeight: 'bold',
+                          width: '170px'
+                        }
+                    },
+				            {
+                        xtype: 'textfield',
+                        fieldLabel: _('ID_DESCRIPTION'),
+                        value: data.TAS_DESCRIPTION,
+                        readOnly: true,
+                        style: {
+                          border: 'none',
+                          backgroundImage: 'none',
+                          fontWeight: 'bold',
+                          width: '170px'
+                        }
+                    },
+                    {
+                      xtype: 'textfield',
+                      fieldLabel: _('ID_INIT_DATE'),
+                      value: data.INIT_DATE_LABEL,
+                      readOnly: true,
+                      style: {
+                        border: 'none',
+                        backgroundImage: 'none',
+                        fontWeight: 'bold',
+                        width: '170px'
+                      }
+                    },
+                    {
+                      xtype: 'textfield',
+                      fieldLabel: _('ID_DUE_DATE'),
+                      value: data.DUE_DATE_LABEL,
+                      readOnly: true,
+                      style: {
+                        border: 'none',
+                        backgroundImage: 'none',
+                        fontWeight: 'bold',
+                        width: '170px'
+                      }
+                    },
+                    {
+                      xtype: 'textfield',
+                      fieldLabel: _('ID_FINISH_DATE'),
+                      value: data.FINISH,
+                      readOnly: true,
+                      style: {
+                        border: 'none',
+                        backgroundImage: 'none',
+                        fontWeight: 'bold',
+                        width: '170px'
+                      }
+                    },
+                    {
+                      xtype: 'textfield',
+                      fieldLabel: _('ID_TASK_DURATION'),
+                      value: data.DURATION,
+                      readOnly: true,
+                      style: {
+                        border: 'none',
+                        backgroundImage: 'none',
+                        fontWeight: 'bold',
+                        width: '170px'
+                      }
+                    }
+				        ]
+				    }
 
 				var frm = new Ext.FormPanel( {
 				labelAlign : 'right',
@@ -1322,7 +1449,8 @@ Ext.onReady(function(){
         url : 'ajaxListener' ,
         params : {action : 'verifySession'},
         success: function ( result, request ) {
-          var data = Ext.util.JSON.decode(result.responseText);
+          var data = Ext.util.JSON.decode(result.responseText),
+              i;
           if( data.lostSession ) {
            Ext.Msg.show({
                   title: _('ID_ERROR'),
@@ -1353,8 +1481,17 @@ Ext.onReady(function(){
                   }
                 });
           } else {
-                winReassignInCasesList.show();
-                grdpnlUsersToReassign.store.load();
+              winReassignInCasesList.show();
+              grdpnlUsersToReassign.store.load();
+              if (document.getElementsByTagName('input')) {
+                document.getElementsByTagName('input')[1].ariaLabel = "search";
+                document.getElementsByTagName('input')[2].ariaLabel = "pagination";
+              }
+              if (document.getElementsByTagName('button')) {
+                for (i = 0; i < document.getElementsByTagName('button').length; i+= 1) {
+                  document.getElementsByTagName('button')[i].ariaLabel = document.getElementsByTagName('button')[i].getAttribute('id');
+                }
+              }
           }
         },
         failure: function ( result, request) {
@@ -1439,8 +1576,30 @@ Ext.onReady(function(){
         style: 'font-weight: bold'
       },
       items : [
-        {fieldLabel: _("ID_CASE"), text: stringReplace("\\: ", "", _APP_NUM)},
-        {fieldLabel: _("ID_PAUSE_DATE"), text: _ENV_CURRENT_DATE},
+        {
+          xtype: 'textfield',
+          fieldLabel: _('ID_CASE'),
+          value: stringReplace("\\: ", "", _APP_NUM),
+          readOnly: true,
+          style: {
+            border: 'none',
+            backgroundImage: 'none',
+            fontWeight: 'bold',
+            width: '170px'
+          }
+        },
+        {
+          xtype: 'textfield',
+          fieldLabel: _('ID_PAUSE_DATE'),
+          value: _ENV_CURRENT_DATE,
+          readOnly: true,
+          style: {
+            border: 'none',
+            backgroundImage: 'none',
+            fontWeight: 'bold',
+            width: '170px'
+          }
+        },
         new Ext.form.DateField({
           id:   'unpauseDate',
           format: 'Y-m-d',
diff --git a/workflow/engine/templates/oauth2/applicationsLoad.php b/workflow/engine/templates/oauth2/applicationsLoad.php
index c751dc20b..52cd7650f 100644
--- a/workflow/engine/templates/oauth2/applicationsLoad.php
+++ b/workflow/engine/templates/oauth2/applicationsLoad.php
@@ -4,7 +4,7 @@
         overflow-y: hidden;
     }
 </style>
-<iframe name="adminFrame" id="adminFrame" src ="clientSetup" width="99%" height="768" frameborder="0">
+<iframe title="adminFrame" name="adminFrame" id="adminFrame" src ="clientSetup" width="99%" height="768" frameborder="0">
     <p>Your browser does not support iframes.</p>
 </iframe>
 </body>
diff --git a/workflow/engine/xmlform/cases/cases_ViewOutputDocument1.xml b/workflow/engine/xmlform/cases/cases_ViewOutputDocument1.xml
index 2914ecc32..8e6ae4519 100644
--- a/workflow/engine/xmlform/cases/cases_ViewOutputDocument1.xml
+++ b/workflow/engine/xmlform/cases/cases_ViewOutputDocument1.xml
@@ -26,10 +26,19 @@
     <en><![CDATA[Next step]]></en>
   </NEXT_STEP>
   <JS type="javascript"><![CDATA[
-var nextStep = function(oForm)
-{
-  oForm.action = 'cases_NextStep';
-  oForm.submit();
-};
+    var i,
+      span,
+      nextStep = function(oForm) {
+        oForm.action = 'cases_NextStep';
+        oForm.submit();
+      };
+    label1 = document.getElementsByTagName('label')[0];
+    label2 = document.getElementsByTagName('label')[1];
+    span1 = document.createElement('span');
+    span1.innerHTML = label1.innerHTML;
+    span2 = document.createElement('span');
+    span2.innerHTML = label2.innerHTML;
+    label1.parentNode.replaceChild(span1, label1);
+    label2.parentNode.replaceChild(span2, label2);
 ]]></JS>
 </dynaForm>