From 99baadbee8274fb1e0e28b924c1cf23755e2b31e Mon Sep 17 00:00:00 2001
From: Rodrigo Quelca <rodrigo@processmaker.com>
Date: Tue, 13 Jul 2021 15:30:03 +0000
Subject: [PATCH] PMCORE-3082

fix myCases code style

add filters for tasks
---
 .../js/components/search/CasesFilter.vue      | 299 ++++++++++--------
 .../js/components/search/MyCasesFilter.vue    | 145 ++++++---
 2 files changed, 267 insertions(+), 177 deletions(-)

diff --git a/resources/assets/js/components/search/CasesFilter.vue b/resources/assets/js/components/search/CasesFilter.vue
index 7dfbae632..12310e9c9 100644
--- a/resources/assets/js/components/search/CasesFilter.vue
+++ b/resources/assets/js/components/search/CasesFilter.vue
@@ -7,14 +7,23 @@
     >
       <template v-slot:body>
         <b-form-group>
-          <b-form-radio-group
-            v-model="selected"
-            :options="filterItems"
-            value-field="id"
-            text-field="optionLabel"
-            name="flavour-2a"
-            stacked
-          ></b-form-radio-group>
+            <b-form-radio-group
+                v-model="selected"
+                :options="filterItems"
+                value-field="id"
+                text-field="optionLabel"
+                name="flavour-2a"
+                stacked
+            ></b-form-radio-group>
+            <b-form-checkbox
+                id="checkbox-1"
+                v-model="byProcessName"
+                name="checkbox-1"
+                value="processName"
+
+            >
+                {{$t('ID_BY_PROCESS_NAME') }}
+            </b-form-checkbox>
         </b-form-group>
       </template>
     </SearchPopover>
@@ -68,7 +77,7 @@
 
 <script>
 import SearchPopover from "./popovers/SearchPopover.vue";
-import CaseIntegerNumber from "./popovers/CaseIntegerNumber.vue";
+import CaseNumber from "./popovers/CaseNumber.vue";
 import CaseTitle from "./popovers/CaseTitle.vue";
 import ProcessName from "./popovers/ProcessName.vue";
 import DateFilter from "./popovers/DateFilter.vue";
@@ -80,7 +89,7 @@ export default {
   props: ["filters", "title"],
   components: {
     SearchPopover,
-    CaseIntegerNumber,
+    CaseNumber,
     CaseTitle,
     ProcessName,
     DateFilter,
@@ -88,104 +97,102 @@ export default {
   },
   data() {
     return {
-      searchLabel: this.$i18n.t("ID_SEARCH"),
-      addSearchTitle: this.$i18n.t("ID_ADD_SEARCH_FILTER_CRITERIA"),
-      searchTags: [],
+        searchLabel: this.$i18n.t("ID_SEARCH"),
+        addSearchTitle: this.$i18n.t("ID_ADD_SEARCH_FILTER_CRITERIA"),
+        searchTags: [],
 
-      filterItems: [
-        {
-          type: "CaseIntegerNumber",
-          id: "caseNumber",
-          title: `${this.$i18n.t("ID_FILTER")}: ${this.$i18n.t(
-            "ID_BY_CASE_NUMBER"
-          )}`,
-          optionLabel: this.$i18n.t("ID_BY_CASE_NUMBER"),
-          detail: this.$i18n.t("ID_PLEASE_SET_THE_CASE_NUMBER_TO_BE_SEARCHED"),
-          tagText: "",
-          tagPrefix: this.$i18n.t("ID_SEARCH_BY_CASE_NUMBER"),
-          items: [
+        filterItems: [
             {
-              id: "caseNumber",
-              value: "",
+            type: "CaseNumber",
+            id: "caseNumber",
+            title: `${this.$i18n.t("ID_FILTER")}: ${this.$i18n.t(
+                "ID_BY_CASE_NUMBER"
+            )}`,
+            optionLabel: this.$i18n.t("ID_BY_CASE_NUMBER"),
+            detail: this.$i18n.t("ID_PLEASE_SET_THE_CASE_NUMBER_TO_BE_SEARCHED"),
+            tagText: "",
+            tagPrefix: this.$i18n.t("ID_SEARCH_BY_CASE_NUMBER"),
+            items: [
+                {
+                id: "filterCases",
+                value: "",
+                },
+            ],
+            autoShow: true,
+            makeTagText: function (params, data) {
+                return `${params.tagPrefix}: ${data[0].value}`;
+            },
             },
-          ],
-          autoShow: true,
-          makeTagText: function (params, data) {
-            return `${params.tagPrefix}: ${data[0].value}`;
-          },
-        },
-        {
-          type: "CaseTitle",
-          id: "caseTitle",
-          title: `${this.$i18n.t("ID_FILTER")}: ${this.$i18n.t(
-            "ID_BY_CASE_TITLE"
-          )}`,
-          optionLabel: this.$i18n.t("ID_BY_CASE_TITLE"),
-          tagPrefix: this.$i18n.t("ID_SEARCH_BY_CASE_TITLE"),
-          detail: "",
-          tagText: "",
-          items: [
             {
-              id: "caseTitle",
-              value: "",
+            type: "CaseTitle",
+            id: "caseTitle",
+            title: `${this.$i18n.t("ID_FILTER")}: ${this.$i18n.t(
+                "ID_BY_CASE_TITLE"
+            )}`,
+            optionLabel: this.$i18n.t("ID_BY_CASE_TITLE"),
+            tagPrefix: this.$i18n.t("ID_SEARCH_BY_CASE_TITLE"),
+            detail: "",
+            tagText: "",
+            items: [
+                {
+                id: "caseTitle",
+                value: "",
+                },
+            ],
+            autoShow: true,
+            makeTagText: function (params, data) {
+                return `${this.tagPrefix} ${data[0].value}`;
+            },
             },
-          ],
-          autoShow: true,
-          makeTagText: function (params, data) {
-            return `${this.tagPrefix} ${data[0].value}`;
-          },
-        },
-        {
-          type: "ProcessName",
-          id: "processName",
-          title: `${this.$i18n.t("ID_FILTER")}: ${this.$i18n.t(
-            "ID_BY_PROCESS_NAME"
-          )}`,
-          optionLabel: this.$i18n.t("ID_BY_PROCESS_NAME"),
-          detail: "",
-          tagText: "",
-          tagPrefix: this.$i18n.t("ID_SEARCH_BY_PROCESS_NAME"),
-          autoShow: true,
-          items: [
             {
-              id: "process",
-              value: "",
-              options: [],
-              placeholder: this.$i18n.t("ID_PROCESS_NAME"),
+            type: "TaskTitle",
+            id: "taskTitle",
+            title: `${this.$i18n.t("ID_FILTER")}: ${this.$i18n.t(
+                "ID_TASK_NAME"
+            )}`,
+            optionLabel: this.$i18n.t("ID_TASK"),
+            detail: "",
+            tagText: "",
+            tagPrefix: this.$i18n.t("ID_SEARCH_BY_TASK_NAME"),
+            autoShow: true,
+            items: [
+                {
+                id: "task",
+                value: "",
+                options: [],
+                placeholder: this.$i18n.t("ID_TASK_NAME"),
+                },
+            ],
+            makeTagText: function (params, data) {
+                return `${this.tagPrefix}: ${data[0].label || ""}`;
             },
-          ],
-          makeTagText: function (params, data) {
-            return `${this.tagPrefix} ${
-              (data[0].options && data[0].options.label) || ""
-            }`;
-          },
-        },
-        {
-          type: "TaskTitle",
-          id: "taskTitle",
-          title: `${this.$i18n.t("ID_FILTER")}: ${this.$i18n.t(
-            "ID_TASK_NAME"
-          )}`,
-          optionLabel: this.$i18n.t("ID_TASK"),
-          detail: "",
-          tagText: "",
-          tagPrefix: this.$i18n.t("ID_SEARCH_BY_TASK_NAME"),
-          autoShow: true,
-          items: [
-            {
-              id: "task",
-              value: "",
-              options: [],
-              placeholder: this.$i18n.t("ID_TASK_NAME"),
             },
-          ],
-          makeTagText: function (params, data) {
-            return `${this.tagPrefix}: ${data[0].label || ""}`;
-          },
-        },
-      ],
-      selected: "",
-      itemModel: {},
+        ],
+        processName: {
+                type: "ProcessName",
+                id: "processName",
+                title: `${this.$i18n.t('ID_FILTER')}: ${this.$i18n.t('ID_BY_PROCESS_NAME')}`,
+                optionLabel: this.$i18n.t('ID_BY_PROCESS_NAME'),
+                detail: "",
+                tagText: "",
+                tagPrefix:  this.$i18n.t('ID_SEARCH_BY_PROCESS_NAME'),
+                autoShow: false,
+                items:[
+                    {
+                        id: "process",
+                        value: "",
+                        options: [],
+                        placeholder: this.$i18n.t('ID_PROCESS_NAME')
+                    }
+                ],
+                makeTagText: function (params, data) {
+
+                    return  `${this.tagPrefix} ${data[0].options && data[0].options.label || ''}`;
+                }
+            },
+        selected: "",
+        itemModel: {},
+        byProcessName: ""
     };
   },
   mounted() {
@@ -199,38 +206,62 @@ export default {
     }
   },
   watch: {
-    filters: function (filters) {
-      this.searchTags = [];
-      this.selected = "";
-      this.setFilters(filters);
-    },
+    filters: { 
+        immediate: true, 
+        handler(newVal, oldVal) { 
+            this.searchTags = [];
+            this.selected = [];
+            this.setFilters(newVal);
+        }
+    }
   },
   methods: {
     /**
      * Add filter criteria save button handler
      */
     onOk() {
-      let self = this,
-        element,
-        initialFilters = [],
-        item;
-      this.$root.$emit("bv::hide::popover");
-      element = _.find(this.filterItems, function (o) {
-        return o.id === self.selected;
-      });
-      if (element) {
-        _.forEach(element.items, function (value, key) {
-          item = {
-            filterVar: value.id,
-            fieldId: self.selected,
-            value: "",
-            label: "",
-            options: [],
-          };
-          initialFilters.push(item);
+        let self = this,
+            element,
+            initialFilters = [],
+            item;
+        this.$root.$emit("bv::hide::popover");
+        element = _.find(this.filterItems, function (o) {
+            return o.id === self.selected;
         });
-      }
-      this.$emit("onUpdateFilters", { params: initialFilters, refresh: false });
+        if  (element) {
+            initialFilters = this.prepareFilterItems(element.items, this.selected, true);
+        }
+        //adding process name filter
+        initialFilters =[...new Set([...initialFilters,...this.prepareFilterItems(this.processName.items, self.byProcessName, true)])];
+        this.$emit("onUpdateFilters", {params: initialFilters, refresh: false}); 
+    },
+    /**
+     * Prepare the filter items
+     * @param {array} items
+     * @param {id} string
+     * @param {boolean} restore
+     */
+    prepareFilterItems(items, id, restore){
+        let initialFilters = [],
+            self = this,
+            filter,
+            item;
+        _.forEach(items, function(value, key) {
+            filter = _.find(self.filters, function(o) { return o.filterVar === value.id; });
+            if (filter && restore) {
+                initialFilters.push(filter);
+            } else {
+                item = {
+                    filterVar: value.id,
+                    fieldId: id,
+                    value:  '',
+                    label: "",
+                    options: []
+                };
+                initialFilters.push(item);
+            }
+        });
+        return initialFilters;
     },
     /**
      * Set Filters and make the tag labels
@@ -248,6 +279,12 @@ export default {
           self.itemModel[component.id] = component;
           self.itemModel[component.id].autoShow = typeof item.autoShow !== "undefined" ? item.autoShow : true
         }
+        if(item.fieldId === "processName") {
+            self.searchTags.push(self.processName.id);
+            self.byProcessName = self.processName.id;
+            self.itemModel[self.processName.id] = self.processName;
+            self.itemModel[self.processName.id].autoShow = typeof self.processName.autoShow !== "undefined" ? self.processName.autoShow  : true;
+        }
       });
     },
     dataToFilter(id) {
@@ -293,8 +330,16 @@ export default {
      * @param {string} tag filter identifier
      */
     customRemove(removeTag, tag) {
-      this.selected = "";
-      this.$emit("onUpdateFilters", { params: [], refresh: true });
+        let temp = [];
+        _.forEach(this.filters, function(item, key) {
+            if(item.fieldId !== tag) { 
+                temp.push(item);   
+            }
+        });
+        if (tag === "processName") {
+            this.byProcessName = "";
+        }
+        this.$emit("onUpdateFilters", {params: temp, refresh: true});
     },
     /**
      * Update the filter model this is fired from filter popaver save action
diff --git a/resources/assets/js/components/search/MyCasesFilter.vue b/resources/assets/js/components/search/MyCasesFilter.vue
index 0131d8e2f..578f2c189 100644
--- a/resources/assets/js/components/search/MyCasesFilter.vue
+++ b/resources/assets/js/components/search/MyCasesFilter.vue
@@ -16,6 +16,14 @@
                         stacked
                     ></b-form-radio-group>
                 </b-form-group>
+                <b-form-checkbox
+                    id="checkbox-1"
+                    v-model="byProcessName"
+                    name="checkbox-1"
+                    value="processName"
+                >
+                    {{$t('ID_BY_PROCESS_NAME') }}
+                </b-form-checkbox>
             </template>
         </SearchPopover>
 
@@ -69,7 +77,7 @@
 
 <script>
 import SearchPopover from "./popovers/SearchPopover.vue";
-import CaseIntegerNumber from "./popovers/CaseIntegerNumber.vue";
+import CaseNumber from "./popovers/CaseNumber.vue";
 import CaseTitle from "./popovers/CaseTitle.vue";
 import ProcessName from "./popovers/ProcessName.vue";
 import DateFilter from "./popovers/DateFilter.vue";
@@ -81,7 +89,7 @@ export default {
     props: ["filters","title"],
     components:{
         SearchPopover,
-        CaseIntegerNumber,
+        CaseNumber,
         CaseTitle,
         ProcessName,
         DateFilter,
@@ -92,10 +100,9 @@ export default {
             searchLabel: this.$i18n.t('ID_SEARCH'),
             addSearchTitle: this.$i18n.t('ID_ADD_SEARCH_FILTER_CRITERIA'),
             searchTags: [],
-        
             filterItems: [
                 {   
-                    type: "CaseIntegerNumber",
+                    type: "CaseNumber",
                     id: "caseNumber",
                     title: `${this.$i18n.t('ID_FILTER')}: ${this.$i18n.t('ID_BY_CASE_NUMBER')}`,
                     optionLabel: this.$i18n.t('ID_BY_CASE_NUMBER'),
@@ -104,7 +111,7 @@ export default {
                     tagPrefix:  this.$i18n.t('ID_SEARCH_BY_CASE_NUMBER'),
                     items:[
                         {
-                            id: "caseNumber",
+                            id: "filterCases",
                             value: ""
                         }
                     ],
@@ -131,29 +138,7 @@ export default {
                     makeTagText: function (params, data) {
                         return  `${this.tagPrefix} ${data[0].value}`;
                     }
-                },
-                {
-                    type: "ProcessName",
-                    id: "processName",
-                    title: `${this.$i18n.t('ID_FILTER')}: ${this.$i18n.t('ID_BY_PROCESS_NAME')}`,
-                    optionLabel: this.$i18n.t('ID_BY_PROCESS_NAME'),
-                    detail: "",
-                    tagText: "",
-                    tagPrefix:  this.$i18n.t('ID_SEARCH_BY_PROCESS_NAME'),
-                    autoShow: true,
-                    items:[
-                        {
-                            id: "process",
-                            value: "",
-                            options: [],
-                            placeholder: this.$i18n.t('ID_PROCESS_NAME')
-                        }
-                    ],
-                    makeTagText: function (params, data) {
-
-                        return  `${this.tagPrefix} ${data[0].options && data[0].options.label || ''}`;
-                    }
-                },
+                }, 
                 {
                     type: "TaskTitle",
                     id: "taskTitle",
@@ -226,8 +211,31 @@ export default {
                     }
                 },
             ],
+            processName: {
+                type: "ProcessName",
+                id: "processName",
+                title: `${this.$i18n.t('ID_FILTER')}: ${this.$i18n.t('ID_BY_PROCESS_NAME')}`,
+                optionLabel: this.$i18n.t('ID_BY_PROCESS_NAME'),
+                detail: "",
+                tagText: "",
+                tagPrefix:  this.$i18n.t('ID_SEARCH_BY_PROCESS_NAME'),
+                autoShow: false,
+                items:[
+                    {
+                        id: "process",
+                        value: "",
+                        options: [],
+                        placeholder: this.$i18n.t('ID_PROCESS_NAME')
+                    }
+                ],
+                makeTagText: function (params, data) {
+
+                    return  `${this.tagPrefix} ${data[0].options && data[0].options.label || ''}`;
+                }
+            },
             selected: "",
-            itemModel: {}
+            itemModel: {},
+            byProcessName: ""
         };
     },
     mounted() {
@@ -241,14 +249,17 @@ export default {
         }
   },
     watch: {
-        filters: function (filters) {
-            this.searchTags = [];
-            this.selected = "";
-            this.setFilters(filters);
-            
+        filters: { 
+            immediate: true, 
+            handler(newVal, oldVal) { 
+                this.searchTags = [];
+                this.selected = [];
+                this.setFilters(newVal);
+            }
         }
     },
     methods: {
+        
         /**
          * Add filter criteria save button handler
          */
@@ -257,23 +268,43 @@ export default {
                 element,
                 initialFilters = [],
                 item;
-                // element = _.find(this.filterItems, function(o) { return o.id === self.selected; });
             this.$root.$emit('bv::hide::popover');
             element = _.find(this.filterItems, function(o) { return o.id === self.selected; });
-                if  (element) {
-                    _.forEach(element.items, function(value, key) {
-                        item = {
-                            filterVar: value.id,
-                            fieldId: self.selected,
-                            value:  '',
-                            label: "",
-                            options: []
-                        };
-                        initialFilters.push(item);
-                    });
-                }
+            if  (element) {
+                initialFilters = this.prepareFilterItems(element.items, this.selected, true);
+            }
+            //adding process name filter
+            initialFilters =[...new Set([...initialFilters,...this.prepareFilterItems(this.processName.items, self.byProcessName, true)])];
             this.$emit("onUpdateFilters", {params: initialFilters, refresh: false}); 
         },
+        /**
+         * Prepare the filter items
+         * @param {array} items
+         * @param {id} string
+         * @param {boolean} restore
+         */
+        prepareFilterItems(items, id, restore){
+            let initialFilters = [],
+                self = this,
+                filter,
+                item;
+            _.forEach(items, function(value, key) {
+                filter = _.find(self.filters, function(o) { return o.filterVar === value.id; });
+                if (filter && restore) {
+                    initialFilters.push(filter);
+                } else {
+                    item = {
+                        filterVar: value.id,
+                        fieldId: id,
+                        value:  '',
+                        label: "",
+                        options: []
+                    };
+                    initialFilters.push(item);
+                }
+            });
+            return initialFilters;
+        },
         /**
          * Set Filters and make the tag labels
          * @param {object} filters json to manage the query 
@@ -288,6 +319,12 @@ export default {
                     self.itemModel[component.id] = component;
                     self.itemModel[component.id].autoShow = typeof item.autoShow !== "undefined" ? item.autoShow : true;
                 }
+                if(item.fieldId === "processName") {
+                    self.searchTags.push(self.processName.id);
+                    self.byProcessName = self.processName.id;
+                    self.itemModel[self.processName.id] = self.processName;
+                    self.itemModel[self.processName.id].autoShow = typeof self.processName.autoShow !== "undefined" ? self.processName.autoShow  : true;
+                }
             });
         },
         dataToFilter(id) {
@@ -327,15 +364,23 @@ export default {
          * @param {string} tag filter identifier
          */
         customRemove(removeTag, tag) {
-            this.selected = "";
-            this.$emit("onUpdateFilters",  {params: [], refresh: true});
+            let temp = [];
+            _.forEach(this.filters, function(item, key) {
+                if(item.fieldId !== tag) { 
+                    temp.push(item);   
+                }
+            });
+            if (tag === "processName") {
+                this.byProcessName = "";
+            }
+            this.$emit("onUpdateFilters", {params: temp, refresh: true});
         },
         /**
          * Update the filter model this is fired from filter popaver save action
          * @param {object} params - arrives the settings
          * @param {string} tag filter identifier
          */
-        updateSearchTag(params) {          
+        updateSearchTag(params) {      
             let temp = this.filters.concat(params);
             temp = [...new Set([...this.filters,...params])]
             this.$emit("onUpdateFilters",  {params: temp, refresh: true});