fernando/luos
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merged in bugfix/PMCORE-1996 (pull request #8379)

Browse Source 
PMCORE-1996 Spaces as password is validate but the user can not login again

Approved-by: Julio Cesar Laura Avendaño
This commit is contained in:
Roly Gutierrez
2022-02-10 15:45:58 +00:00
committed by Julio Cesar Laura Avendaño
parent 6b469a1b70 730c12fe85
commit 985db58407
5 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
workflow/engine/classes/model/UsersProperties.php
View File

@@ -195,6 +195,10 @@ class UsersProperties extends BaseUsersProperties
$changePassword = 1;
}
}
//Spaces not supported at the end of passwords
if (substr($password, -1) === " ") {
$listErrors[] = 'ID_PPP_SPACES_NOT_SUPPORTED_AT_THE_END_OF_PASSWORD';
}
if ($changePassword == 1) {
$listErrors[] = 'ID_PPP_CHANGE_PASSWORD_AFTER_NEXT_LOGIN';

6
workflow/engine/content/translations/english/processmaker.en.po
View File

@@ -22277,6 +22277,12 @@ msgstr "Minimum length"
msgid "Numerical Character is required"
msgstr "Numerical Character is required"
# TRANSLATION
# LABEL/ID_PPP_SPACES_NOT_SUPPORTED_AT_THE_END_OF_PASSWORD
#: LABEL/ID_PPP_SPACES_NOT_SUPPORTED_AT_THE_END_OF_PASSWORD
msgid "Spaces not supported at the end of password"
msgstr "Spaces not supported at the end of password"
# TRANSLATION
# LABEL/ID_PPP_SPECIAL_CHARACTER_REQUIRED
#: LABEL/ID_PPP_SPECIAL_CHARACTER_REQUIRED

1
workflow/engine/data/mysql/insert.sql
View File

@@ -60625,6 +60625,7 @@ INSERT INTO TRANSLATION (TRN_CATEGORY,TRN_ID,TRN_LANG,TRN_VALUE,TRN_UPDATE_DATE
( 'LABEL','ID_PPP_MINIMUM_LENGTH','en','Minimum length','2014-01-15') ,
( 'LABEL','ID_PPP_MINIMUN_LENGTH','en','Minimum length','2014-01-15') ,
( 'LABEL','ID_PPP_NUMERICAL_CHARACTER_REQUIRED','en','Numerical Character is required','2014-01-15') ,
( 'LABEL','ID_PPP_SPACES_NOT_SUPPORTED_AT_THE_END_OF_PASSWORD','en','Spaces not supported at the end of password','2022-02-09') ,
( 'LABEL','ID_PPP_SPECIAL_CHARACTER_REQUIRED','en','Special Character is required','2014-01-15') ,
( 'LABEL','ID_PPP_UPPERCASE_CHARACTER_REQUIRED','en','Uppercase Character is required','2014-01-15') ,
( 'LABEL','ID_PREFERENCES','en','Preferences','2014-01-15') ,

3
workflow/engine/methods/login/authentication.php
View File

@@ -40,7 +40,8 @@ try {
if (isset($frm['USR_USERNAME'])) {
$usr = mb_strtolower(trim($frm['USR_USERNAME']), 'UTF-8');
$pwd = trim($frm['USR_PASSWORD']);
//Spaces not supported at the end of passwords
$pwd = rtrim($frm['USR_PASSWORD']);
}
/*----------------------------------********---------------------------------*/
require_once PATH_CORE . 'methods' . PATH_SEP . 'enterprise' . PATH_SEP . 'enterprise.php';

5
workflow/engine/xmlform/login/changePasswordpm3.xml
View File

@@ -108,6 +108,11 @@ var verifyPassword = function() {
return;
}
}
//Spaces not supported at the end of passwords
if (oPassword1.value.slice(-1) === ' ') {
alert('@G::LoadTranslation(ID_PPP_SPACES_NOT_SUPPORTED_AT_THE_END_OF_PASSWORD)');
return;
}
oPassword1.form.submit();
};