PMCORE-646 Special characters in oracle connection passwords causes bad behavior

2020-04-17 18:50:58 -04:00
parent c72026912f
commit 8deff59f74
3 changed files with 102 additions and 0 deletions
--- a/workflow/engine/src/ProcessMaker/Core/System.php
+++ b/workflow/engine/src/ProcessMaker/Core/System.php
@@ -1695,4 +1695,50 @@ class System
        }
        return (object) $result;
    }
+
+    /**
+     * Parse an url with not encoded password that break the native “parse_url” function.
+     * @param string $dsn
+     * @return array
+     */
+    public static function parseUrlWithNotEncodedPassword(string $dsn): array
+    {
+        $default = [
+            'scheme' => '',
+            'host' => '',
+            'port' => '',
+            'user' => '',
+            'pass' => '',
+            'path' => '',
+            'query' => '',
+        ];
+        $separator = "://";
+        $colon = ":";
+        $at = "@";
+
+        $result = explode($separator, $dsn, 2);
+        if (empty($result[0]) || empty($result[1])) {
+            return $default;
+        }
+        $scheme = $result[0];
+        $urlWithoutScheme = $result[1];
+
+        $colonPosition = strpos($urlWithoutScheme, $colon);
+        $user = substr($urlWithoutScheme, 0, $colonPosition);
+
+        $withoutUser = substr($urlWithoutScheme, $colonPosition + 1);
+        $atPosition = strrpos($withoutUser, $at);
+        $pass = substr($urlWithoutScheme, $colonPosition + 1, $atPosition);
+
+        $withoutPass = substr($withoutUser, $atPosition + 1);
+
+        $fixedDsn = $scheme . $separator . $user . $colon . urlencode($pass) . $at . $withoutPass;
+
+        $parseDsn = parse_url($fixedDsn);
+        if ($parseDsn === false) {
+            return $default;
+        }
+        $parseDsn["pass"] = urldecode($parseDsn["pass"]);
+        return $parseDsn;
+    }
 }