fernando/luos
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PMCORE-1656 PMCORE-1178 There is no validation of mime-type when upload a modified file.

Browse Source
This commit is contained in:
Roly Rudy Gutierrez Pinto
2020-06-17 17:36:32 -04:00
parent aea65a651a
commit 841e8b45c3
1 changed files with 8 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
workflow/engine/src/ProcessMaker/Validation/ValidationUploadedFiles.php
View File

@@ -6,6 +6,7 @@ use Bootstrap;
use G; use G;
use Illuminate\Filesystem\Filesystem; use Illuminate\Filesystem\Filesystem;
use Illuminate\Support\Facades\Cache; use Illuminate\Support\Facades\Cache;
use Monolog\Logger;
use ProcessMaker\Core\System; use ProcessMaker\Core\System;
use ProcessMaker\Services\OAuth2\Server; use ProcessMaker\Services\OAuth2\Server;
use ProcessMaker\Util\PhpShorthandByte; use ProcessMaker\Util\PhpShorthandByte;
@@ -301,7 +302,7 @@ class ValidationUploadedFiles
*/ */
public function runRulesForPostFilesOfNote($file) public function runRulesForPostFilesOfNote($file)
{ {
$validator = new Validator(); $validator = $this->runRules($file);
//rule: file exists //rule: file exists
$rule = $validator->addRule(); $rule = $validator->addRule();
@@ -314,20 +315,9 @@ class ValidationUploadedFiles
} }
return self::VALID; return self::VALID;
}) })
->status(400) ->status(Logger::ERROR)
->log(function($rule) { ->log(function($rule) {
/** Bootstrap::registerMonologPhpUploadExecution('phpUpload', Logger::ERROR, $rule->getMessage(), $rule->getData()->filename);
* Levels supported by MonologProvider is:
* 100 "DEBUG"
* 200 "INFO"
* 250 "NOTICE"
* 300 "WARNING"
* 400 "ERROR"
* 500 "CRITICAL"
* 550 "ALERT"
* 600 "EMERGENCY"
*/
Bootstrap::registerMonologPhpUploadExecution('phpUpload', $rule->getStatus(), $rule->getMessage(), $rule->getData()->filename);
}); });
//rule: extensions //rule: extensions
@@ -344,20 +334,9 @@ class ValidationUploadedFiles
} }
return self::VALID; return self::VALID;
}) })
->status(400) ->status(Logger::ERROR)
->log(function($rule) { ->log(function($rule) {
/** Bootstrap::registerMonologPhpUploadExecution('phpUpload', Logger::ERROR, $rule->getMessage(), $rule->getData()->filename);
* Levels supported by MonologProvider is:
* 100 "DEBUG"
* 200 "INFO"
* 250 "NOTICE"
* 300 "WARNING"
* 400 "ERROR"
* 500 "CRITICAL"
* 550 "ALERT"
* 600 "EMERGENCY"
*/
Bootstrap::registerMonologPhpUploadExecution('phpUpload', $rule->getStatus(), $rule->getMessage(), $rule->getData()->filename);
}); });
//rule: file size //rule: file size
@@ -375,20 +354,9 @@ class ValidationUploadedFiles
} }
return self::VALID; return self::VALID;
}) })
->status(400) ->status(Logger::ERROR)
->log(function($rule) { ->log(function($rule) {
/** Bootstrap::registerMonologPhpUploadExecution('phpUpload', Logger::ERROR, $rule->getMessage(), $rule->getData()->filename);
* Levels supported by MonologProvider is:
* 100 "DEBUG"
* 200 "INFO"
* 250 "NOTICE"
* 300 "WARNING"
* 400 "ERROR"
* 500 "CRITICAL"
* 550 "ALERT"
* 600 "EMERGENCY"
*/
Bootstrap::registerMonologPhpUploadExecution('phpUpload', $rule->getStatus(), $rule->getMessage(), $rule->getData()->filename);
}); });
return $validator->validate(); return $validator->validate();