From 7d2574d516f0213d2636dbde4abcc80850a979b3 Mon Sep 17 00:00:00 2001 From: Roly Rudy Gutierrez Pinto Date: Tue, 26 Nov 2019 13:43:30 -0400 Subject: [PATCH] PMC-1403 Targeting a 'switch' control structure with a 'continue' statement is strongly discouraged and will throw a warning as of PHP 7.3. --- workflow/engine/classes/ProcessMap.php | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/workflow/engine/classes/ProcessMap.php b/workflow/engine/classes/ProcessMap.php index eb7c54390..8719038b2 100644 --- a/workflow/engine/classes/ProcessMap.php +++ b/workflow/engine/classes/ProcessMap.php @@ -729,6 +729,7 @@ class ProcessMap $urlEdit = ''; $linkEditValue = ''; + $shouldItContinue = false; switch ($aRow['STEP_TYPE_OBJ']) { case 'DYNAFORM': $oDynaform = new Dynaform(); @@ -748,7 +749,8 @@ class ProcessMap $oInputDocument = new InputDocument(); $aFields = $oInputDocument->getByUid($aRow['STEP_UID_OBJ']); if ($aFields === false) { - continue; + $shouldItContinue = true; + break; } $sTitle = $aFields['INP_DOC_TITLE']; break; @@ -757,7 +759,8 @@ class ProcessMap $aFields = $oOutputDocument->getByUid($aRow['STEP_UID_OBJ']); if ($aFields === false) { - continue; + $shouldItContinue = true; + break; } $sTitle = $aFields['OUT_DOC_TITLE']; break; @@ -777,6 +780,9 @@ class ProcessMap } break; } + if ($shouldItContinue === true) { + continue; + } $aSteps[] = array('STEP_TITLE' => $sTitle, 'STEP_UID' => $aRow['STEP_UID'], 'STEP_TYPE_OBJ' => $aRow['STEP_TYPE_OBJ'], 'STEP_MODE' => $aRow['STEP_MODE'], 'STEP_CONDITION' => $aRow['STEP_CONDITION'], 'STEP_POSITION' => $aRow['STEP_POSITION'], 'urlEdit' => $urlEdit, 'linkEditValue' => $linkEditValue, 'PRO_UID' => $aRow['PRO_UID'] );