From 71d88443d4b18051bb07accfd98693a57de1cebc Mon Sep 17 00:00:00 2001
From: Rodrigo Quelca <rodrigo@processmaker.com>
Date: Wed, 2 Dec 2020 20:45:15 +0000
Subject: [PATCH] PMCORE-2506: sideabr collapsed feature is not working

remove bad code
---
 .../js/components/menu/CustomSidebar.vue      | 212 +++++++++---------
 resources/assets/js/home/Home.vue             |  27 +--
 2 files changed, 119 insertions(+), 120 deletions(-)

diff --git a/resources/assets/js/components/menu/CustomSidebar.vue b/resources/assets/js/components/menu/CustomSidebar.vue
index 92fa34740..9427fe3ea 100644
--- a/resources/assets/js/components/menu/CustomSidebar.vue
+++ b/resources/assets/js/components/menu/CustomSidebar.vue
@@ -1,131 +1,129 @@
 <template>
-  <div>
-    <sidebar-menu
-      ref="sidebar"
-      :width="sidebarWidth"
-      :menu="menu"
-      :hideToggle="hideToggle"
-      :collapsed="collapsed"
-      :theme="selectedTheme"
-      :show-one-child="true"
-      @item-click="onItemClick"
-    >
-      <div slot="header">
-        <div class="text-right" @click="onToggleClick">
-          <b-icon :icon="className"></b-icon>
-        </div>
-      </div>
-    </sidebar-menu>
-  </div>
+    <div>
+        <sidebar-menu
+            ref="sidebar"
+            :width="sidebarWidth"
+            :menu="menu"
+            :hideToggle="hideToggle"
+            :collapsed="collapsed"
+            :theme="selectedTheme"
+            :show-one-child="true"
+            @item-click="onItemClick"
+        >
+            <div slot="header">
+                <div class="text-right" @click="onToggleClick">
+                    <b-icon :icon="className"></b-icon>
+                </div>
+            </div>
+        </sidebar-menu>
+    </div>
 </template>
 
 <script>
 import api from "./../../api/index";
 
 export default {
-  name: "CustomSidebar",
-  data() {
-    return {
-      menu: [],
-      collapsed: false,
-      isOnMobile: false,
-      hideToggle: true,
-      selectedTheme: "",
-      sidebarWidth: "310px",
-    };
-  },
-  computed: {
-    className() {
-      return this.collapsed
-        ? "arrow-right-circle-fill"
-        : "arrow-left-circle-fill";
+    name: "CustomSidebar",
+    data() {
+        return {
+            menu: [],
+            collapsed: false,
+            isOnMobile: false,
+            hideToggle: true,
+            selectedTheme: "",
+            sidebarWidth: "310px",
+        };
     },
-  },
-  mounted() {
-    this.onResize();
-    window.addEventListener("resize", this.onResize);
-    api.menu
-      .get()
-      .then((response) => {
-        this.menu = response;
-      })
-      .catch((e) => {
-        console.error(e);
-      });
-  },
-  methods: {
-    onToggleClick() {
-      this.$refs.sidebar.$emit("toggle-collapse", this.collapsed);
-      this.collapsed = !this.collapsed;
+    computed: {
+        className() {
+            return this.collapsed
+                ? "arrow-right-circle-fill"
+                : "arrow-left-circle-fill";
+        },
     },
-    createCounter() {
-      let els = document.querySelectorAll("a[href='#/foo']");
-      this.inboxCounter = document.createElement("span");
-      this.inboxCounter.setAttribute(
-        "class",
-        "float-right badge badge-light navBadget"
-      );
-      this.inboxCounter.innerHTML += "5";
-      if (els && els[0]) {
-        els[0].appendChild(this.inboxCounter);
-      }
+    mounted() {
+        this.onResize();
+        window.addEventListener("resize", this.onResize);
+        api.menu
+            .get()
+            .then((response) => {
+                this.menu = response;
+            })
+            .catch((e) => {
+                console.error(e);
+            });
     },
-    onToggleCollapse(collapsed) {
-      console.log(collapsed);
-      this.collapsed = collapsed;
+    methods: {
+        /**
+         * Toggle Handler, fired on click
+         */
+        onToggleClick() {
+            this.collapsed = !this.collapsed;
+            this.$refs.sidebar.$emit("toggle-collapse", this.collapsed);
+            this.$emit("onToggleCollapse", this.collapsed);
+        },
+        /**
+         * Toggle item Handler, fired when a menu item is clicked
+         * @param {object} event - click event params
+         * @param {object} item - menu item params
+         * @param {object} node - html node
+         */
+        onItemClick(event, item, node) {
+            this.$emit("OnClickSidebarItem", { item });
+        },
+         /**
+         * On resize event handler id the windows is resized 
+         * collase and isMobile proerty will be updated
+         */
+        onResize() {
+            if (window.innerWidth <= 767) {
+                this.isOnMobile = true;
+                this.collapsed = true;
+            } else {
+                this.isOnMobile = false;
+                this.collapsed = false;
+            }
+        },
     },
-    onItemClick(event, item, node) {
-      this.$emit("OnClickSidebarItem", { item });
-    },
-    onResize() {
-      if (window.innerWidth <= 767) {
-        this.isOnMobile = true;
-        this.collapsed = true;
-      } else {
-        this.isOnMobile = false;
-        this.collapsed = false;
-      }
-    },
-  },
 };
 </script>
 
 <style lang="scss">
 .badge-custom {
-  color: #000;
-  background-color: #d4dfe6;
-  padding: 0px 6px;
-  font-size: 12px;
-  border-radius: 3px;
-  height: 20px;
-  line-height: 20px;
-  font-weight: 600;
-  text-transform: uppercase;
+    color: #000;
+    background-color: #d4dfe6;
+    padding: 0px 6px;
+    font-size: 12px;
+    border-radius: 3px;
+    height: 20px;
+    line-height: 20px;
+    font-weight: 600;
+    text-transform: uppercase;
 }
 .text-right {
-  color: white;
-  font-size: x-large;
-  margin: 3px;
-  margin-right: 16px;
+    color: white;
+    font-size: x-large;
+    margin: 3px;
+    margin-right: 16px;
 }
 .sidebar-overlay {
-  position: fixed;
-  width: 100%;
-  height: 100%;
-  top: 0;
-  left: 0;
-  background-color: #000;
-  opacity: 0.5;
-  z-index: 900;
+    position: fixed;
+    width: 100%;
+    height: 100%;
+    top: 0;
+    left: 0;
+    background-color: #000;
+    opacity: 0.5;
+    z-index: 900;
 }
 
 pre {
-  font-family: Consolas, monospace;
-  color: #000;
-  background: #fff;
-  border-radius: 2px;
-  padding: 15px;
-  line-height: 1.5;
-  overflow: auto;
+    font-family: Consolas, monospace;
+    color: #000;
+    background: #fff;
+    border-radius: 2px;
+    padding: 15px;
+    line-height: 1.5;
+    overflow: auto;
 }
-</style>
\ No newline at end of file
+</style>
diff --git a/resources/assets/js/home/Home.vue b/resources/assets/js/home/Home.vue
index 13422a20e..55e88479e 100644
--- a/resources/assets/js/home/Home.vue
+++ b/resources/assets/js/home/Home.vue
@@ -5,7 +5,10 @@
         <router-view />
       </div>
 
-      <CustomSidebar @OnClickSidebarItem="OnClickSidebarItem" />
+      <CustomSidebar
+              @OnClickSidebarItem="OnClickSidebarItem"
+              @onToggleCollapse="onToggleCollapse"
+      />
       <div
         v-if="isOnMobile && !collapsed"
         class="sidebar-overlay"
@@ -15,21 +18,11 @@
       <component v-bind:is="page"></component>
     </div>
   </div>
-</template> onResize() {
-            if (window.innerWidth <= 767) {
-                this.isOnMobile = true;
-                this.collapsed = true;
-            } else {
-                this.isOnMobile = false;
-                this.collapsed = false;
-            }
-        },
-
+</template> 
 <script>
 import CustomSidebar from "./../components/menu/CustomSidebar";
 import MyCases from "./MyCases";
 
-
 export default {
     name: "Home",
     components: {
@@ -64,6 +57,14 @@ export default {
                 this.collapsed = false;
             }
         },
+        /**
+         * Toggle sidebar handler
+         * @param {Boolean} collapsed - if sidebar is collapsed true|false
+         *  
+         */
+        onToggleCollapse(collapsed) {
+            this.collapsed = collapsed;
+        }
     },
 };
 </script>
@@ -71,7 +72,7 @@ export default {
 <style lang="scss">
 #home {
   padding-left: 310px;
-  transition: 0.3s ease;
+  transition: 0.3s;
 }
 #home.collapsed {
   padding-left: 50px;