From a98068b4a41f57a167c5db81fefa0f0e2880ea27 Mon Sep 17 00:00:00 2001 From: dheeyi Date: Thu, 26 Feb 2015 15:10:35 -0400 Subject: [PATCH 1/6] PM-1127 Change following text in the Trigger Wizard MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Causa: Textos definidos previamentes. SolucióEdicion de nuevos textos. --- workflow/engine/classes/class.pmFunctions.php | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/workflow/engine/classes/class.pmFunctions.php b/workflow/engine/classes/class.pmFunctions.php index 949a8a034..f69f43390 100755 --- a/workflow/engine/classes/class.pmFunctions.php +++ b/workflow/engine/classes/class.pmFunctions.php @@ -1235,7 +1235,7 @@ function WSInformationUser($userUid) * * @method * - * Returns the unique ID for the current active session. + * Returns the unique ID for the current login session. * * @name WSGetSession * @label WS Get Session @@ -1400,7 +1400,7 @@ function WSUnpauseCase ($caseUid, $delIndex, $userUid) * * @method * - * Add case note. + * Add a case note. * * @name WSAddCaseNote * @label WS Add case note @@ -1537,7 +1537,7 @@ function PMFUserList () //its test was successfull /** * @method * - * Add a input document. + * Add an Input Document. * * @name PMFAddInputDocument * @label PMF Add a input document @@ -1552,7 +1552,7 @@ function PMFUserList () //its test was successfull * @param string(32) | $caseUid | ID of the case | The unique ID of the case. * @param int | $delIndex | Delegation index of the case | The delegation index of the current task in the case. * @param string(32) | $taskUid | ID of the task | The unique ID of the task. - * @param string(32) | $userUid | ID user | The unique ID of the user who will add a input document. + * @param string(32) | $userUid | ID user | The unique ID of the user who will add an input document. * @param string | $option = "file" | Option | Option, value: "file". * @param string | $file = "path_to_file/myfile.txt" | File, path to file | File, path to file. * @return string | $appDocUid | ID of the application document | Returns ID if it has added the input document successfully; otherwise, returns null or empty if an error occurred. @@ -2061,7 +2061,7 @@ function PMFNewCase ($processId, $userId, $taskId, $variables) * * @method * - * Assigns a user to a group. + * * * Assigns a user to a group. Note that the logged-in user must have the PM_USERS permission in his/her role to be able to assign a user to a group. * @@ -2466,7 +2466,7 @@ function PMFGetNextAssignedUser ($application, $task, $delIndex = null, $userUid /** * @method * - * Returns a list or user. + * Returns the email address of the specified user. * * @name PMFGetUserEmailAddress * @label PMF Get User Email Address @@ -2845,7 +2845,7 @@ function PMFAddAttachmentToArray($arrayData, $index, $value, $suffix = " Copy({i /** *@method * - * It delete the mask a field. + * Removes the currency symbol and thousands separator inserted by a currency mask. * * @name PMFRemoveMask * @label PMF Remove Mask From 11ee25b8df02ff011e156df80b94de6d14a9ea59 Mon Sep 17 00:00:00 2001 From: dheeyi Date: Thu, 26 Feb 2015 15:22:35 -0400 Subject: [PATCH 2/6] PM-878 Change description of the "processmaker change-password-hash-method" command in the help --- workflow/engine/bin/tasks/cliAddons.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/workflow/engine/bin/tasks/cliAddons.php b/workflow/engine/bin/tasks/cliAddons.php index e47e0fe42..27af448db 100644 --- a/workflow/engine/bin/tasks/cliAddons.php +++ b/workflow/engine/bin/tasks/cliAddons.php @@ -21,7 +21,7 @@ EOT /*----------------------------------********---------------------------------*/ CLI::taskName('change-password-hash-method'); CLI::taskDescription(<< Date: Thu, 26 Feb 2015 16:46:52 -0400 Subject: [PATCH 3/6] =?UTF-8?q?PM-1698=20"Los=20procesos=20dise=C3=B1ados?= =?UTF-8?q?=20se=20guardan=20vacios=20despues=20de=20usar=20el=20Zoom=20"?= =?UTF-8?q?=20SOLVED?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../Project/Adapter/BpmnWorkflow.php | 32 +++++++++++++++++-- 1 file changed, 29 insertions(+), 3 deletions(-) diff --git a/workflow/engine/src/ProcessMaker/Project/Adapter/BpmnWorkflow.php b/workflow/engine/src/ProcessMaker/Project/Adapter/BpmnWorkflow.php index 5edd19296..516ec4cf9 100755 --- a/workflow/engine/src/ProcessMaker/Project/Adapter/BpmnWorkflow.php +++ b/workflow/engine/src/ProcessMaker/Project/Adapter/BpmnWorkflow.php @@ -1283,7 +1283,12 @@ class BpmnWorkflow extends Project\Bpmn $activity = $bwp->getActivity($activityData["ACT_UID"]); + if ($activity["BOU_CONTAINER"] != $activityData["BOU_CONTAINER"]) { + $activity = null; + } + if ($forceInsert || is_null($activity)) { + if ($generateUid) { //Activity @@ -1316,6 +1321,7 @@ class BpmnWorkflow extends Project\Bpmn $diagram["activities"][$i] = $activityData; $whiteList[] = $activityData["ACT_UID"]; + } $activities = $bwp->getActivities(); @@ -1337,6 +1343,10 @@ class BpmnWorkflow extends Project\Bpmn $artifact = $bwp->getArtifact($artifactData["ART_UID"]); + if ($artifact["BOU_CONTAINER"] != $artifactData["BOU_CONTAINER"]) { + $artifact = null; + } + if ($forceInsert || is_null($artifact)) { if ($generateUid) { //Artifact @@ -1397,6 +1407,10 @@ class BpmnWorkflow extends Project\Bpmn $gateway = $bwp->getGateway($gatewayData["GAT_UID"]); + if ($gateway["BOU_CONTAINER"] != $gatewayData["BOU_CONTAINER"]) { + $gateway = null; + } + if ($forceInsert || is_null($gateway)) { if ($generateUid) { //Gateway @@ -1471,6 +1485,10 @@ class BpmnWorkflow extends Project\Bpmn $event = $bwp->getEvent($eventData["EVN_UID"]); + if ($event["BOU_CONTAINER"] != $eventData["BOU_CONTAINER"]) { + $event = null; + } + if ($forceInsert || is_null($event)) { if ($generateUid) { //Event @@ -1527,6 +1545,10 @@ class BpmnWorkflow extends Project\Bpmn $dataObject = $bwp->getData($dataObjectData["DAT_UID"]); + if ($dataObject["BOU_CONTAINER"] != $dataObjectData["BOU_CONTAINER"]) { + $dataObject = null; + } + if ($forceInsert || is_null($dataObject)) { if ($generateUid) { //Data @@ -1581,9 +1603,13 @@ class BpmnWorkflow extends Project\Bpmn $participantData = array_change_key_case($participantData, CASE_UPPER); unset($participantData["_EXTENDED"]); - $dataObject = $bwp->getParticipant($participantData["PAR_UID"]); + $participant = $bwp->getParticipant($participantData["PAR_UID"]); - if ($forceInsert || is_null($dataObject)) { + if ($participant["BOU_CONTAINER"] != $participantData["BOU_CONTAINER"]) { + $participant = null; + } + + if ($forceInsert || is_null($participant)) { if ($generateUid) { //Participant @@ -1609,7 +1635,7 @@ class BpmnWorkflow extends Project\Bpmn } $bwp->addParticipant($participantData); - } elseif (! $bwp->isEquals($dataObject, $participantData)) { + } elseif (! $bwp->isEquals($participant, $participantData)) { $bwp->updateParticipant($participantData["PAR_UID"], $participantData); } else { Util\Logger::log("Update Participant ({$participantData["PAR_UID"]}) Skipped - No changes required"); From 69f5ca8c2331ddfb06c42f4b8587121a1dff9940 Mon Sep 17 00:00:00 2001 From: Victor Saisa Lopez Date: Thu, 26 Feb 2015 17:02:34 -0400 Subject: [PATCH 4/6] PM-1679 "No se ejecuta el cron en Servidores Windows" SOLVED Issue: No se ejecuta el cron en Servidores Windows Cause: - En PHP-5.4 se incorpora de manera predefinida la constante E_STRICT, siendo este la causa para los "Warnings PHP Strict Standards" - No se esta cargando los files de "processmaker/workflow/engine/src/ProcessMaker" Solution: - Se ha corregido codigo para respetar el "PHP Strict Standards" - Se ha agregado codigo para cargar los files requeridos de "processmaker/workflow/engine/src/ProcessMaker" --- gulliver/system/class.dvEditor.php | 2 +- gulliver/system/class.g.php | 5 +- gulliver/system/class.xmlMenu.php | 4 +- gulliver/system/class.xmlform.php | 81 +++++++++---------- gulliver/system/class.xmlformExtension.php | 2 +- workflow/engine/bin/cron_single.php | 59 +++++++++----- .../engine/bin/messageeventcron_single.php | 2 +- 7 files changed, 88 insertions(+), 67 deletions(-) diff --git a/gulliver/system/class.dvEditor.php b/gulliver/system/class.dvEditor.php index af447c5ab..1068c8347 100755 --- a/gulliver/system/class.dvEditor.php +++ b/gulliver/system/class.dvEditor.php @@ -55,7 +55,7 @@ class XmlForm_Field_HTML extends XmlForm_Field * @return string * */ - public function render ($value, $owner = null) + public function render($value = null, $owner = null) { $value = ($value == '') ? '
' : $value; $html = "
"; diff --git a/gulliver/system/class.g.php b/gulliver/system/class.g.php index 7ae0529e3..e406ac3d2 100755 --- a/gulliver/system/class.g.php +++ b/gulliver/system/class.g.php @@ -713,7 +713,7 @@ class G * @param string $strClass * @return void */ - public function LoadThirdParty ($sPath, $sFile) + public static function LoadThirdParty($sPath, $sFile) { $classfile = PATH_THIRDPARTY . $sPath . '/' . $sFile . ((substr( $sFile, 0, - 4 ) !== '.php') ? '.php' : ''); return require_once ($classfile); @@ -3330,7 +3330,7 @@ class G * * @return boolean true or false */ - public function isHttpRequest() + public static function isHttpRequest() { if (isset($_SERVER['SERVER_SOFTWARE']) && strpos(strtolower($_SERVER['SERVER_SOFTWARE']), 'apache') !== false) { return true; @@ -5647,3 +5647,4 @@ function __ ($msgID, $lang = SYS_LANG, $data = null) { return G::LoadTranslation( $msgID, $lang, $data ); } + diff --git a/gulliver/system/class.xmlMenu.php b/gulliver/system/class.xmlMenu.php index bde2c516c..c6745e98a 100755 --- a/gulliver/system/class.xmlMenu.php +++ b/gulliver/system/class.xmlMenu.php @@ -76,7 +76,7 @@ class XmlForm_Field_XmlMenu extends XmlForm_Field * * @return object $out */ - public function render ($value) + public function render($value = null, $paramDummy2 = null) { $this->xmlMenu = new xmlMenu( $this->xmlfile, $this->home ); $this->xmlMenu->setValues( $value ); @@ -97,7 +97,7 @@ class XmlForm_Field_XmlMenu extends XmlForm_Field * * @return none */ - public function renderGrid ($value) + public function renderGrid($value = null, $paramDummy2 = null, $paramDummy3 = null, $paramDummy4 = null) { return $this->render( $value ); } diff --git a/gulliver/system/class.xmlform.php b/gulliver/system/class.xmlform.php index 93458d03b..29e7d0966 100755 --- a/gulliver/system/class.xmlform.php +++ b/gulliver/system/class.xmlform.php @@ -394,7 +394,7 @@ class XmlForm_Field * @param string value * @return string */ - public function render ($value = null) + public function render($value = null, $paramDummy2 = null) { //this is an unknown field type. return $this->htmlentities( $value != '' ? $value : $this->name, ENT_COMPAT, 'utf-8' ); @@ -934,7 +934,7 @@ class XmlForm_Field_Title extends XmlForm_Field * @param string value * @return string */ - public function render ($value = null, &$owner = null) + public function render($value = null, $owner = null) { $this->label = G::replaceDataField( $this->label, $owner->values ); return 'name . ']\' name=\'form[' . $this->name . ']\' ' . $this->NSFieldType() . ' >' . $this->htmlentities( $this->label ) . ''; @@ -970,7 +970,7 @@ class XmlForm_Field_Subtitle extends XmlForm_Field * @param string value * @return string */ - public function render ($value = null) + public function render($value = null, $paramDummy2 = null) { return 'name . ']\' name=\'form[' . $this->name . ']\' ' . $this->NSFieldType() . ' >' . $this->htmlentities( $this->label ) . ''; } @@ -1012,7 +1012,7 @@ class XmlForm_Field_SimpleText extends XmlForm_Field * @param string value * @return string */ - public function render ($value = null, &$owner = null) + public function render($value = null, $owner = null) { if (($this->pmconnection != '') && ($this->pmfield != '') && $value == null) { $value = $this->getPMTableValue( $owner ); @@ -1040,7 +1040,7 @@ class XmlForm_Field_SimpleText extends XmlForm_Field * @param string owner * @return string */ - public function renderGrid ($values = array(), $owner = null) + public function renderGrid($values = array(), $owner = null, $paramDummy3 = null, $paramDummy4 = null) { $result = array (); $r = 1; @@ -1204,7 +1204,7 @@ class XmlForm_Field_Text extends XmlForm_Field_SimpleText * @param string owner * @return string */ - public function renderGrid ($values = array(), $owner = null) + public function renderGrid($values = array(), $owner = null, $paramDummy3 = null, $paramDummy4 = null) { $result = $aux = array (); $r = 1; @@ -1257,7 +1257,7 @@ class XmlForm_Field_Text extends XmlForm_Field_SimpleText return $result; } - public function renderTable ($values = '', $owner = null) + public function renderTable($values = "", $owner = null, $paramDummy3 = null) { $result = $this->htmlentities( $values, ENT_COMPAT, 'utf-8' ); return $result; @@ -1716,7 +1716,7 @@ class XmlForm_Field_Suggest extends XmlForm_Field_SimpleText //by neyek * @param string owner * @return string */ - public function renderGrid ($values = array(), $owner = null) + public function renderGrid($values = array(), $owner = null, $paramDummy3 = null, $paramDummy4 = null) { $aResult = array(); $r = 1; @@ -1735,7 +1735,7 @@ class XmlForm_Field_Suggest extends XmlForm_Field_SimpleText //by neyek * @param $owner * @return $result */ - public function renderTable ($values = '', $owner = null) + public function renderTable($values = "", $owner = null, $paramDummy3 = null) { $result = $this->htmlentities( $values, ENT_COMPAT, 'utf-8' ); return $result; @@ -1812,10 +1812,8 @@ class XmlForm_Field_Caption extends XmlForm_Field * @param $owner * @return true */ - public function validateValue ($value, &$owner) + public function validateValue($value) { - /*$this->executeSQL( $owner ); - return isset($value) && ( array_key_exists( $value , $this->options ) );*/ return true; } @@ -1897,7 +1895,7 @@ class XmlForm_Field_Password extends XmlForm_Field * @param string value * @return string */ - public function render ($value = null) + public function render($value = null, $paramDummy2 = null) { if ($this->autocomplete === '1') { $this->autocomplete = "on"; @@ -2013,7 +2011,7 @@ class XmlForm_Field_Textarea extends XmlForm_Field * @param string owner * @return string */ - public function renderGrid ($values = array(), $owner = null) + public function renderGrid($values = array(), $owner = null, $paramDummy3 = null, $paramDummy4 = null) { $this->gridFieldType = 'textarea'; @@ -2176,7 +2174,7 @@ class XmlForm_Field_Currency extends XmlForm_Field_SimpleText * @param string owner * @return string */ - public function renderGrid ($values = array(), $owner = null) + public function renderGrid($values = array(), $owner = null, $paramDummy3 = null, $paramDummy4 = null) { $result = array (); $r = 1; @@ -2242,7 +2240,7 @@ class XmlForm_Field_CaptionCurrency extends XmlForm_Field * @param string value * @return string */ - public function render ($value = null) + public function render($value = null, $paramDummy2 = null) { return '$ ' . $this->htmlentities( $value, ENT_COMPAT, 'utf-8' ); } @@ -2323,7 +2321,7 @@ class XmlForm_Field_Percentage extends XmlForm_Field_SimpleText return $html; } - public function renderGrid ($values = array(), $owner = null) + public function renderGrid($values = array(), $owner = null, $paramDummy3 = null, $paramDummy4 = null) { $result = array (); $r = 1; @@ -2381,7 +2379,7 @@ class XmlForm_Field_Percentage extends XmlForm_Field_SimpleText class XmlForm_Field_CaptionPercentage extends XmlForm_Field { - public function render ($value = null) + public function render($value = null, $paramDummy2 = null) { return $this->htmlentities( $value, ENT_COMPAT, 'utf-8' ); } @@ -2575,7 +2573,7 @@ class XmlForm_Field_Date2 extends XmlForm_Field_SimpleText * @param $onlyValue * @return */ - public function renderGrid ($values = null, $owner = null, $onlyValue = false) + public function renderGrid($values = null, $owner = null, $onlyValue = false, $paramDummy4 = null) { $result = array (); $r = 1; @@ -2658,7 +2656,7 @@ class XmlForm_Field_Date2 extends XmlForm_Field_SimpleText class XmlForm_Field_DateView extends XmlForm_Field { - public function render ($value = null) + public function render($value = null, $paramDummy2 = null) { return $this->htmlentities( $value, ENT_COMPAT, 'utf-8' ); } @@ -2741,7 +2739,7 @@ class XmlForm_Field_YesNo extends XmlForm_Field * @param $owner * @return */ - public function renderGrid ($values = array(), $owner = null) + public function renderGrid($values = array(), $owner = null, $paramDummy3 = null, $paramDummy4 = null) { $this->gridFieldType = 'yesno'; $result = array (); @@ -2888,7 +2886,7 @@ class XmlForm_Field_Link extends XmlForm_Field * @param $owner * @return */ - public function renderGrid($value = array(), $label = array(), $owner = null) + public function renderGrid($value = array(), $label = array(), $owner = null, $paramDummy4 = null) { $arrayResult = array(); $row = 1; @@ -2914,7 +2912,7 @@ class XmlForm_Field_Link extends XmlForm_Field * @param $owner * @return */ - public function renderTable ($value = null, $owner = null) + public function renderTable($value = null, $owner = null, $paramDummy3 = null) { $onclick = $this->htmlentities( G::replaceDataField( $this->onclick, $owner->values ), ENT_QUOTES, 'utf-8' ); $link = $this->htmlentities( G::replaceDataField( $this->link, $owner->values ), ENT_QUOTES, 'utf-8' ); @@ -3053,7 +3051,7 @@ class XmlForm_Field_File extends XmlForm_Field return $html; } - public function renderGrid ($value = array(), $owner = null, $therow = -1) + public function renderGrid($value = array(), $owner = null, $therow = -1, $paramDummy4 = null) { $arrayResult = array (); $r = 1; @@ -3142,7 +3140,7 @@ class XmlForm_Field_Checkboxpt extends XmlForm_Field * @param $owner * @return result */ - public function renderGrid ($values = array(), $owner = null) + public function renderGrid($values = array(), $owner = null, $paramDummy3 = null, $paramDummy4 = null) { $result = array (); $r = 1; @@ -3238,7 +3236,7 @@ class XmlForm_Field_Checkbox extends XmlForm_Field * @param $owner * @return result */ - public function renderGrid ($values = array(), $owner = null) + public function renderGrid($values = array(), $owner = null, $paramDummy3 = null, $paramDummy4 = null) { $this->gridFieldType = 'checkbox'; $result = array (); @@ -3286,7 +3284,7 @@ class XmlForm_Field_Checkbox2 extends XmlForm_Field { public $required = false; - public function render ($value = null) + public function render($value = null, $paramDummy2 = null) { return '' . $this->label . ''; } @@ -3461,7 +3459,7 @@ class XmlForm_Field_Hidden extends XmlForm_Field * @param $owner * @return result */ - public function renderGrid ($values = null, $owner = null) + public function renderGrid($values = null, $owner = null, $paramDummy3 = null, $paramDummy4 = null) { $result = array (); $r = 1; @@ -3480,7 +3478,7 @@ class XmlForm_Field_Hidden extends XmlForm_Field * @param $owner * @return result */ - public function renderTable ($value = '', $owner = null) + public function renderTable($value = "", $owner = null, $paramDummy3 = null) { return ''; } @@ -3509,10 +3507,8 @@ class XmlForm_Field_Dropdown extends XmlForm_Field public $renderMode = ''; public $selectedValue = ''; - public function validateValue ($value, &$owner) + public function validateValue($value) { - /*$this->executeSQL( $owner ); - return isset($value) && ( array_key_exists( $value , $this->options ) );*/ return true; } @@ -3827,7 +3823,7 @@ class XmlForm_Field_Listbox extends XmlForm_Field * @param $owner * @return result */ - public function renderGrid ($value = null, $owner = null) + public function renderGrid($value = null, $owner = null, $paramDummy3 = null, $paramDummy4 = null) { return $this->render( $value, $owner ); } @@ -4046,7 +4042,7 @@ class XmlForm_Field_CheckGroupView extends XmlForm_Field * @param string value * @return string */ - public function render ($value = null) + public function render($value = null, $paramDummy2 = null) { $html = ''; foreach ($this->option as $optionName => $option) { @@ -4125,7 +4121,7 @@ class XmlForm_Field_Grid extends XmlForm_Field * @return