fernando/luos
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve ifs

Browse Source 
Remove PRO_ID update because it is not required
Refresh APP_STATUS_ID
This commit is contained in:
davidcallizaya
2017-02-21 16:25:17 -04:00
parent 8d957c7566
commit 5988543a68
11 changed files with 132 additions and 149 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
workflow/engine/classes/model/ListInbox.php
View File

@@ -32,18 +32,21 @@ class ListInbox extends BaseListInbox
$aData = $oCase->loadCase( $data["APP_UID"] );
$data['APP_TITLE'] = G::replaceDataField($data['APP_TITLE'], $aData['APP_DATA']);
}
$p = new Process();
if (!empty($data['PRO_UID'])) {
$p = new Process();
$data['PRO_ID'] = $p->load($data['PRO_UID'])['PRO_ID'];
}
$u = new Users();
if (!empty($data['USR_UID'])) {
$u = new Users();
$data['USR_ID'] = $data['USR_UID']==='SELF_SERVICES' ? null : $u->load($data['USR_UID'])['USR_ID'];
}
$t = new Task();
if (!empty($data['TAS_UID'])) {
$t = new Task();
$data['TAS_ID'] = $t->load($data['TAS_UID'])['TAS_ID'];
}
if (!empty($data['APP_STATUS'])) {
$data['APP_STATUS_ID'] = Application::$app_status_values[$data['APP_STATUS']];
}
$this->fromArray( $data, BasePeer::TYPE_FIELDNAME );
if ($this->validate()) {
$result = $this->save();
@@ -158,18 +161,17 @@ class ListInbox extends BaseListInbox
$data['DEL_PRIORITY'] = $this->getTaskPriority($data['TAS_UID'], $data['PRO_UID'], $data["APP_UID"]);
}
$p = new Process();
if (!empty($data['PRO_UID'])) {
$data['PRO_ID'] = $p->load($data['PRO_UID'])['PRO_ID'];
}
$u = new Users();
if (!empty($data['USR_UID'])) {
$u = new Users();
$data['USR_ID'] = $data['USR_UID']==='SELF_SERVICES' ? null : $u->load($data['USR_UID'])['USR_ID'];
}
$t = new Task();
if (!empty($data['TAS_UID'])) {
$t = new Task();
$data['TAS_ID'] = $t->load($data['TAS_UID'])['TAS_ID'];
}
if (!empty($data['APP_STATUS'])) {
$data['APP_STATUS_ID'] = Application::$app_status_values[$data['APP_STATUS']];
}
$con = Propel::getConnection( ListInboxPeer::DATABASE_NAME );
try {
$con->begin();