From a4aba45c61b8ddf8b8d38d3bd018670bba18d657 Mon Sep 17 00:00:00 2001 From: "Paula V. Quispe" Date: Thu, 16 Apr 2015 10:55:19 -0400 Subject: [PATCH 1/7] I reverted the issue PM-1947 --- workflow/engine/src/ProcessMaker/BusinessModel/Task.php | 2 +- workflow/engine/xmlform/tasks/tasks_TimingControl.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/workflow/engine/src/ProcessMaker/BusinessModel/Task.php b/workflow/engine/src/ProcessMaker/BusinessModel/Task.php index d6b6c31f2..d2ac8fba8 100644 --- a/workflow/engine/src/ProcessMaker/BusinessModel/Task.php +++ b/workflow/engine/src/ProcessMaker/BusinessModel/Task.php @@ -321,7 +321,7 @@ class Task } //Validating TAS_TRANSFER_FLY value - if ($arrayProperty["TAS_TRANSFER_FLY"] == "TRUE") { + if ($arrayProperty["TAS_TRANSFER_FLY"] == "FALSE") { if (!isset($arrayProperty["TAS_DURATION"])) { throw (new \Exception("Invalid value specified for 'tas_duration'")); } diff --git a/workflow/engine/xmlform/tasks/tasks_TimingControl.xml b/workflow/engine/xmlform/tasks/tasks_TimingControl.xml index 5f462988e..6a6587205 100755 --- a/workflow/engine/xmlform/tasks/tasks_TimingControl.xml +++ b/workflow/engine/xmlform/tasks/tasks_TimingControl.xml @@ -23,7 +23,7 @@ SELECT CALENDAR_UID, CALENDAR_NAME FROM availableCalendars var toggleFields = function() { - if(getField('TAS_TRANSFER_FLY').checked == true) + if(getField('TAS_TRANSFER_FLY').checked == false) { showRowById('TAS_DURATION'); showRowById('TAS_TIMEUNIT'); From 36c361c5570968111991817b5dc2c5887ca409dd Mon Sep 17 00:00:00 2001 From: Brayan Pereyra Date: Thu, 16 Apr 2015 12:25:15 -0400 Subject: [PATCH 2/7] PM-2333 Al adicionar una activity ya creado a un lane duplica el mismo --- .../engine/src/ProcessMaker/Project/Adapter/BpmnWorkflow.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/workflow/engine/src/ProcessMaker/Project/Adapter/BpmnWorkflow.php b/workflow/engine/src/ProcessMaker/Project/Adapter/BpmnWorkflow.php index 902e075e8..0235e922c 100755 --- a/workflow/engine/src/ProcessMaker/Project/Adapter/BpmnWorkflow.php +++ b/workflow/engine/src/ProcessMaker/Project/Adapter/BpmnWorkflow.php @@ -1384,10 +1384,6 @@ class BpmnWorkflow extends Project\Bpmn $activity = $bwp->getActivity($activityData["ACT_UID"]); - if ($activity["BOU_CONTAINER"] != $activityData["BOU_CONTAINER"]) { - $activity = null; - } - if ($forceInsert || is_null($activity)) { if ($generateUid) { //Generate and update UID From 94831f8a178180280f62e3fed81fecf5220d0ecf Mon Sep 17 00:00:00 2001 From: "Paula V. Quispe" Date: Thu, 16 Apr 2015 13:08:25 -0400 Subject: [PATCH 3/7] I updated the label in timing control --- workflow/engine/xmlform/tasks/tasks_TimingControl.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/workflow/engine/xmlform/tasks/tasks_TimingControl.xml b/workflow/engine/xmlform/tasks/tasks_TimingControl.xml index 6a6587205..e76b99ca2 100755 --- a/workflow/engine/xmlform/tasks/tasks_TimingControl.xml +++ b/workflow/engine/xmlform/tasks/tasks_TimingControl.xml @@ -4,7 +4,7 @@ - + From bece913f0b0c561fa7db74287dfb20327fb597e5 Mon Sep 17 00:00:00 2001 From: Brayan Pereyra Date: Thu, 16 Apr 2015 14:51:10 -0400 Subject: [PATCH 4/7] Adicion de login al hacer enter en password --- workflow/engine/xmlform/login/login.xml | 14 ++++++++++++++ workflow/engine/xmlform/login/loginpm3.xml | 15 ++++++++++++++- workflow/engine/xmlform/login/sysLoginNoWS.xml | 14 ++++++++++++++ workflow/engine/xmlform/login/sysLoginNoWSpm3.xml | 14 ++++++++++++++ 4 files changed, 56 insertions(+), 1 deletion(-) diff --git a/workflow/engine/xmlform/login/login.xml b/workflow/engine/xmlform/login/login.xml index 54fb684f2..2c4d65517 100755 --- a/workflow/engine/xmlform/login/login.xml +++ b/workflow/engine/xmlform/login/login.xml @@ -86,6 +86,20 @@ var dynaformOnload = function() { } }; +leimnud.event.add(document.getElementById('form[USR_PASSWORD_MASK]'), 'keypress', function(event) { + var key; + if(window.event) + key = window.event.keyCode; //IE + else + key = event.which; //firefox + if(key == 13) { + document.getElementById('form[BSUBMIT]').click(); + return true; + } else { + return true; + } +}); + leimnud.event.add(document.getElementById('form[BSUBMIT]'), 'click', function() { document.getElementById('form[USR_PASSWORD]').value = document.getElementById('form[USR_PASSWORD_MASK]').value; document.getElementById('form[USR_PASSWORD_MASK]').value = ''; diff --git a/workflow/engine/xmlform/login/loginpm3.xml b/workflow/engine/xmlform/login/loginpm3.xml index 99ff2d1d8..f1811cbcb 100755 --- a/workflow/engine/xmlform/login/loginpm3.xml +++ b/workflow/engine/xmlform/login/loginpm3.xml @@ -25,7 +25,6 @@ SELECT LANG_ID, LANG_NAME FROM langOptions Date: Thu, 16 Apr 2015 16:04:16 -0400 Subject: [PATCH 5/7] PM-2320 "Fix: Add DEL_RISK_DATE field in tables Delegation..." SOLVED Issue: El nuevo campo DEL_RISK_DATE no refleja la fecha correcta Cause: No se tiene de manera completa la formula para el calculo de la fecha Solution: Se a completado la formula --- .../engine/classes/model/AppDelegation.php | 23 +++++++++++++++---- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/workflow/engine/classes/model/AppDelegation.php b/workflow/engine/classes/model/AppDelegation.php index caf32c9cc..388d48542 100755 --- a/workflow/engine/classes/model/AppDelegation.php +++ b/workflow/engine/classes/model/AppDelegation.php @@ -356,17 +356,18 @@ class AppDelegation extends BaseAppDelegation $aCalendarUID = ''; } - //use the dates class to calculate dates + //Calendar - Use the dates class to calculate dates $calendar = new calendar(); $arrayCalendarData = array(); if ($calendar->pmCalendarUid == "") { - $calendar->getCalendar(null, $task->getProUid(), $this->getTasUid()); + $calendar->getCalendar(null, $this->getProUid(), $this->getTasUid()); $arrayCalendarData = $calendar->getCalendarData(); } + //Due date /*$iDueDate = $calendar->calculateDate( $this->getDelDelegateDate(), $aData['TAS_DURATION'], $aData['TAS_TIMEUNIT'] //hours or days, ( we only accept this two types or maybe weeks );*/ $dueDate = $calendar->dashCalculateDate($this->getDelDelegateDate(), $aData["TAS_DURATION"], $aData["TAS_TIMEUNIT"], $arrayCalendarData); @@ -378,10 +379,22 @@ class AppDelegation extends BaseAppDelegation public function calculateRiskDate($dueDate, $risk) { try { - $numDueDate = strtotime($dueDate); //Seconds - $numDueDate = $numDueDate - ($numDueDate * $risk); + $riskTime = strtotime($dueDate) - strtotime($this->getDelDelegateDate()); //Seconds + $riskTime = $riskTime - ($riskTime * $risk); - $riskDate = date("Y-m-d H:i:s", round($numDueDate)); + //Calendar - Use the dates class to calculate dates + $calendar = new calendar(); + + $arrayCalendarData = array(); + + if ($calendar->pmCalendarUid == "") { + $calendar->getCalendar(null, $this->getProUid(), $this->getTasUid()); + + $arrayCalendarData = $calendar->getCalendarData(); + } + + //Risk date + $riskDate = $calendar->dashCalculateDate($this->getDelDelegateDate(), round($riskTime / (60 * 60)), "HOURS", $arrayCalendarData); //Return return $riskDate; From 4af53d2768d91ad989dc588cdb7e24a0f0f30c33 Mon Sep 17 00:00:00 2001 From: Victor Saisa Lopez Date: Fri, 17 Apr 2015 10:04:59 -0400 Subject: [PATCH 6/7] PM-2112 "Fix: 0016986: REST endpoint PUT /{workspace}/oauth2/token sets.." SOLVED Issue: Fix: 0016986: REST endpoint PUT /{workspace}/oauth2/token sets the HTTP status to 200 (OK) when error Cause: Al obtener un "access token" con informacion erronea, no se define correctamente el response de error Solution: Se revierte el 1er cambio y se aplica un "exit(0);", ya que el status code se sobre escribia --- .../src/ProcessMaker/Services/OAuth2/Server.php | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/workflow/engine/src/ProcessMaker/Services/OAuth2/Server.php b/workflow/engine/src/ProcessMaker/Services/OAuth2/Server.php index 9c74bd208..72f288b38 100644 --- a/workflow/engine/src/ProcessMaker/Services/OAuth2/Server.php +++ b/workflow/engine/src/ProcessMaker/Services/OAuth2/Server.php @@ -309,17 +309,9 @@ class Server implements iAuthenticate if ($returnResponse) { return $response; } else { - if ($response->getStatusCode() == 400) { - $msg = $response->getParameter("error_description", ""); - $msg = ($msg != "")? $msg : $response->getParameter("error", ""); + $response->send(); - $rest = new \Maveriks\Extension\Restler(); - $rest->setMessage(new \Luracast\Restler\RestException(\ProcessMaker\Services\Api::STAT_APP_EXCEPTION, $msg)); - - exit(0); - } else { - $response->send(); - } + exit(0); } } From 4629ff8add1fa7ce38d8726f6a923948ba2ecd89 Mon Sep 17 00:00:00 2001 From: jennylee Date: Fri, 17 Apr 2015 10:48:39 -0400 Subject: [PATCH 7/7] Fixing a merge error --- workflow/engine/classes/class.calendar.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/workflow/engine/classes/class.calendar.php b/workflow/engine/classes/class.calendar.php index 7ec30c177..48f50b77f 100755 --- a/workflow/engine/classes/class.calendar.php +++ b/workflow/engine/classes/class.calendar.php @@ -414,7 +414,7 @@ class calendar extends CalendarDefinition $hoursDuration -= (float)($secondRes/3600); //$dataLog[] = (float)($secondRes/3600); } else { - $newDate = date('Y-m-d H:i:s', strtotime('+' . (((float)$hoursDuration)*3600) . ' seconds', strtotime($newDate))); + $newDate = date("Y-m-d H:i:s", strtotime("+" . round(((float)($hoursDuration)) * 3600) . " seconds", strtotime($newDate))); //$dataLog[] = (float)($hoursDuration); $hoursDuration = 0; }