fernando/luos
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PMCORE-3876 Check Backward Incompatible Changes, specially "String to Number Comparison"

Browse Source
This commit is contained in:
Roly Gutierrez
2022-06-30 18:01:35 -04:00
parent dff6f45c55
commit 41298e0905
38 changed files with 96 additions and 1144 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
workflow/engine/classes/Net.php
View File

@@ -263,7 +263,10 @@ class Net
$opt = [
'UID' => $this->db_user,
'PWD' => $this->db_passwd,
'Database' => $this->db_sourcename
'Database' => $this->db_sourcename,
'CharacterSet' => 'UTF-8',
'Encrypt' => true,
'TrustServerCertificate' => true
];
$link = @sqlsrv_connect($server, $opt);
@@ -399,7 +402,10 @@ class Net
$opt = [
'UID' => $this->db_user,
'PWD' => $this->db_passwd,
'Database' => $this->db_sourcename
'Database' => $this->db_sourcename,
'CharacterSet' => 'UTF-8',
'Encrypt' => true,
'TrustServerCertificate' => true
];
$link = $db = @sqlsrv_connect($server, $opt);
if ($link) {

16
workflow/engine/classes/ProcessMap.php
View File

@@ -142,22 +142,6 @@ class ProcessMap
$aRow2['FINISH'] = '';
}
/*
if (($aRow2['FINISH'] == null) && ($aRow1['TAS_UID'] == $sTask)) {
$oTask->color = '#FF0000';
} else {
if ($aRow2['CANT'] != 0) {
if ($aRow2['FINISH'] == null) {
//$oTask->color = '#FF9900';
$oTask->color = '#FF0000';
} else {
$oTask->color = '#006633';
}
} else {
$oTask->color = "#939598";
}
}
*/
if (empty($aRow2["FINISH"]) && $aRow1["TAS_UID"] == $sTask) {
$oTask->color = "#FF0000"; //Red
} else {

4
workflow/engine/classes/WsBase.php
View File

@@ -2424,7 +2424,7 @@ class WsBase
$oAppDelay = new AppDelay();
$aRow = $oAppDelay->getCasesCancelOrPaused($caseId);
if (is_array($aRow)) {
if (isset($aRow['APP_DISABLE_ACTION_USER']) && $aRow['APP_DISABLE_ACTION_USER'] != 0 && isset($aRow['APP_DISABLE_ACTION_DATE']) && $aRow['APP_DISABLE_ACTION_DATE'] != '') {
if (isset($aRow['APP_DISABLE_ACTION_USER']) && intval($aRow['APP_DISABLE_ACTION_USER']) != 0 && isset($aRow['APP_DISABLE_ACTION_DATE']) && $aRow['APP_DISABLE_ACTION_DATE'] != '') {
$result = new WsResponse(19, G::LoadTranslation('ID_CASE_IN_STATUS') . " " . $aRow['APP_TYPE']);
return $result;
@@ -3486,7 +3486,7 @@ class WsBase
$respView = $case->getAllObjectsFrom($processUid, $caseUid, $taskUid, $userUid, "VIEW");
$respBlock = $case->getAllObjectsFrom($processUid, $caseUid, $taskUid, $userUid, "BLOCK");
if ($respView["CASES_NOTES"] == 0 && $respBlock["CASES_NOTES"] == 0) {
if (intval($respView["CASES_NOTES"]) == 0 && intval($respBlock["CASES_NOTES"]) == 0) {
$result = new WsResponse(100, G::LoadTranslation("ID_CASES_NOTES_NO_PERMISSIONS"));
return $result;

3
workflow/engine/classes/XmlFormFieldToolButton.php
View File

@@ -78,7 +78,8 @@ class XmlFormFieldToolButton extends XmlFormField
case 'dropdown':
$html = '';
if (isset($this->owner->values['PRO_UID'])) {
$criteria = ProcessMap::getDynaformsCriteria($this->owner->values['PRO_UID']);
$processMap = new ProcessMap();
$criteria = $processMap->getDynaformsCriteria($this->owner->values['PRO_UID']);
$dataset = DynaformPeer::doSelectRS($criteria);
if ($dataset->getRecordCount() > 0) {
$html .= '<span style="display:inline-block; font-size: 8pt;margin-left: 5px;margin-bottom: 3px;">' . G::LoadTranslation('ID_DYNAFORM');