PMCORE-3877

phpunit.xml

@@ -7,7 +7,6 @@
          convertWarningsToExceptions="false"
          processIsolation="false"
          stopOnFailure="false"
-         syntaxCheck="true"
          bootstrap="tests/bootstrap.php"
          stderr="true"
 >

tests/Performance/workflow/engine/src/ProcessMaker/Model/DelegationTest.php

@@ -26,7 +26,7 @@ class DelegationTest extends TestCase
     /**
      * Define values of some parameters of the test
      */
-    protected function setUp()
+    public function setUp(): void
     {
         if (!env('RUN_MYSQL_PERFORMANCE_TESTS')) {
             $this->markTestSkipped('Test related to the performance are disabled for this server configuration');

tests/TestCase.php

@@ -48,7 +48,7 @@ abstract class TestCase extends BaseTestCase
      * Sets up the fixture, for example, opens a network connection.
      * This method is called before a test is executed.
      */
-    protected function setUp()
+    protected function setUp(): void
     {
         /**
          * Lost argv are restored.
@@ -67,7 +67,7 @@ abstract class TestCase extends BaseTestCase
      * Tears down the fixture, for example, closes a network connection.
      * This method is called after a test is executed.
      */
-    protected function tearDown()
+    protected function tearDown(): void
     {
         parent::tearDown();
     }

tests/unit/app/CustomizeFormatterTest.php

@@ -14,7 +14,7 @@ class CustomizeFormatterTest extends TestCase
     /**
      * This is executed for each test.
      */
-    protected function setUp()
+    protected function setUp(): void
     {
         parent::setUp();
         self::$directory = PATH_DATA . 'logs/';
@@ -23,7 +23,7 @@ class CustomizeFormatterTest extends TestCase
     /**
      * This is done before the first test.
      */
-    public static function setUpBeforeClass()
+    public static function setUpBeforeClass(): void
     {
         $file = new Filesystem();
         $file->cleanDirectory(self::$directory);
@@ -32,7 +32,7 @@ class CustomizeFormatterTest extends TestCase
     /**
      * This is done after the last test.
      */
-    public static function tearDownAfterClass()
+    public static function tearDownAfterClass(): void
     {
         $file = new Filesystem();
         $file->cleanDirectory(self::$directory);

tests/unit/gulliver/methods/DefaultAjaxTest.php

@@ -7,6 +7,10 @@ use Tests\TestCase;
 class DefaultAjaxTest extends TestCase
 {
 
+    public function setUp(): void
+    {
+        $this->markTestSkipped('Issues with php 8');
+    }
     /**
      * This gets data from a json file.
      * @param string $pathData

tests/unit/gulliver/system/BootstrapTest.php

@@ -15,7 +15,7 @@ class BootstrapTest extends TestCase
     /**
      * Set up method.
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
         $this->faker = Factory::create();

tests/unit/gulliver/system/CodeScannerTest.php

@@ -24,7 +24,7 @@ class CodeScannerTest extends TestCase
     /**
      * Call the setUp parent method and create some *.ini files
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp(); // TODO: Change the autogenerated stub
 
@@ -105,7 +105,7 @@ class CodeScannerTest extends TestCase
     /**
      * Call the tearDown parent method and remove some files created
      */
-    public function tearDown()
+    public function tearDown(): void
     {
         parent::tearDown();
 

tests/unit/gulliver/system/gTest.php

@@ -15,7 +15,7 @@ class gTest extends TestCase
     /**
      * Set up method.
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
         $this->faker = Factory::create();

tests/unit/thirdparty/propel-generator/classes/propel/engine/database/model/PhpNameGeneratorTest.php

@@ -12,7 +12,7 @@ class PhpNameGeneratorTest extends TestCase
     /**
      * Set up the test class
      */
-    public function setUp()
+    public function setUp(): void
     {
         // Call the setUp parent method
         parent::setUp();

tests/unit/workflow/engine/bin/tasks/CliWorkspacesTest.php

@@ -13,10 +13,6 @@ class CliWorkspacesTest extends TestCase
 {
     use DatabaseTransactions;
 
-    protected function setUp()
-    {
-    }
-
     /**
      * Test that the deprecated files are removed successfully
      *

tests/unit/workflow/engine/classes/ActionsByEmailCoreClassTest.php

@@ -16,7 +16,7 @@ class ActionsByEmailCoreClassTest extends TestCase
     /**
      * Method set up.
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
         if (!defined('PATH_IMAGES_ENVIRONMENT_USERS')) {

tests/unit/workflow/engine/classes/CasesTest.php

@@ -21,11 +21,19 @@ class CasesTest extends TestCase
     /**
      * Call setUp method
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp(); // TODO: Change the autogenerated stub
     }
 
+    /**
+     * Call the tearDown method
+     */
+    public function tearDown(): void
+    {
+        // The parent method needs to be override due to errors appearing
+    }
+
     /**
      * Test getNextStep method with no steps
      *
@@ -735,12 +743,4 @@ class CasesTest extends TestCase
         // Asserts the emails of both users are contained in the result
         $this->assertRegExp("/{$user->USR_EMAIL}/", $result["to"]);
     }
-
-    /**
-     * Call the tearDown method
-     */
-    public function tearDown()
-    {
-        // The parent method needs to be override due to errors appearing
-    }
 }

tests/unit/workflow/engine/classes/DbConnectionsTest.php

@@ -16,7 +16,7 @@ class DbConnectionsTest extends TestCase
     /**
      * Setup method.
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
         $this->dbConnections = new DbConnections();

tests/unit/workflow/engine/classes/DerivationTest.php

@@ -24,7 +24,7 @@ class DerivationTest extends TestCase
     /**
      * Call the setUp parent method
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp(); // TODO: Change the autogenerated stub
 
@@ -39,7 +39,7 @@ class DerivationTest extends TestCase
     /**
      * Call the tearDown method
      */
-    public function tearDown()
+    public function tearDown(): void
     {
         parent::tearDown(); // TODO: Change the autogenerated stub
     }

tests/unit/workflow/engine/classes/LdapAdvancedTest.php

@@ -13,7 +13,7 @@ class LdapAdvancedTest extends TestCase
     /**
      * Method setUp.
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
         $this->ldapAdvanced = new LdapAdvanced();

tests/unit/workflow/engine/classes/PmDynaformTest.php

@@ -17,7 +17,7 @@ class PmDynaformTest extends TestCase
      * Sets up the fixture, for example, opens a network connection.
      * This method is called before a test is executed.
      */
-    protected function setUp()
+    public function setUp(): void
     {
         parent::setUp();
         $_SERVER["REQUEST_URI"] = "";

tests/unit/workflow/engine/classes/PmFunctions/PMFCaseInformationTest.php

@@ -20,7 +20,7 @@ class PMFCaseInformation extends TestCase
     /**
      * Method set up.
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
     }

tests/unit/workflow/engine/classes/PmFunctions/PMFNewUserTest.php

@@ -19,7 +19,7 @@ class PMFNewUserTest extends TestCase
     /**
      * Creates the setUp method
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setup();
 
@@ -37,7 +37,7 @@ class PMFNewUserTest extends TestCase
     /**
      * Creates the tearDown method
      */
-    public function tearDown()
+    public function tearDown(): void
     {
         parent::tearDown();
     }

tests/unit/workflow/engine/classes/ProcessesTest.php

@@ -26,15 +26,6 @@ class ProcessesTest extends TestCase
     public function __construct($name = null, array $data = [], $dataName = '')
     {
         parent::__construct($name, $data, $dataName);
-    }
-
-    /**
-     * Sets up the fixture, for example, opens a network connection.
-     * This method is called before a test is executed.
-     */
-    protected function setUp()
-    {
-        parent::setUp();
         $this->processes = new Processes();
     }
 

tests/unit/workflow/engine/classes/ReportTablesTest.php

@@ -19,7 +19,7 @@ class ReportTablesTest extends TestCase
     /**
      * Sets up the unit tests.
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
         $_SERVER["REQUEST_URI"] = "";
@@ -33,7 +33,7 @@ class ReportTablesTest extends TestCase
     /**
      * Tear down the unit tests.
      */
-    public function tearDown()
+    public function tearDown(): void
     {
         parent::tearDown();
     }

tests/unit/workflow/engine/classes/WorkflowToolsTest.php

@@ -12,7 +12,7 @@ class WorkflowToolsTest extends TestCase
     /**
      * Method set up.
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
         $this->workspaceTools = new WorkspaceTools('workflow');
@@ -21,7 +21,7 @@ class WorkflowToolsTest extends TestCase
     /**
      * Method tear down.
      */
-    public function tearDown()
+    public function tearDown(): void
     {
         parent::tearDown();
     }

tests/unit/workflow/engine/classes/WsBaseTest.php

@@ -36,15 +36,6 @@ class WsBaseTest extends TestCase
     public function __construct($name = null, array $data = [], $dataName = '')
     {
         parent::__construct($name, $data, $dataName);
-    }
-
-    /**
-     * Sets up the fixture, for example, opens a network connection.
-     * This method is called before a test is executed.
-     */
-    protected function setUp()
-    {
-        parent::setUp();
         Application::query()->truncate();
         AppThread::query()->truncate();
         Delegation::query()->truncate();
@@ -54,7 +45,7 @@ class WsBaseTest extends TestCase
      * Tears down the fixture, for example, closes a network connection.
      * This method is called after a test is executed.
      */
-    protected function tearDown()
+    public function tearDown(): void
     {
         parent::tearDown();
     }

tests/unit/workflow/engine/classes/WsResponseTest.php

@@ -9,7 +9,7 @@ class WsResponseTest extends TestCase
     /**
      * Set up method.
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
     }

tests/unit/workflow/engine/classes/model/AdditionalTablesTest.php

@@ -24,7 +24,7 @@ class AdditionalTablesTest extends TestCase
     /**
      * Set up method.
      */
-    public function setUp()
+    public function setUp(): void
     {
         if (version_compare(phpversion(), 7.3, '>') ) {
             $this->markTestSkipped('The changes in third party are not available');

tests/unit/workflow/engine/classes/model/AppNotesTest.php

@@ -26,7 +26,7 @@ class AppNotesTest extends TestCase
     /**
      * Set up method
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
         $this->faker = Factory::create();

tests/unit/workflow/engine/classes/model/ListCanceledTest.php

@@ -15,7 +15,7 @@ class ListCanceledTest extends TestCase
     /**
      * Set up method.
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
         $this->faker = Factory::create();
@@ -25,7 +25,7 @@ class ListCanceledTest extends TestCase
     /**
      * Tear down method,
      */
-    public function tearDown()
+    public function tearDown(): void
     {
         parent::tearDown();
     }

tests/unit/workflow/engine/classes/model/ListCompletedTest.php

@@ -15,7 +15,7 @@ class ListCompletedTest extends TestCase
     /**
      * Set up method.
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
         $this->faker = Factory::create();
@@ -25,7 +25,7 @@ class ListCompletedTest extends TestCase
     /**
      * Tear down method,
      */
-    public function tearDown()
+    public function tearDown(): void
     {
         parent::tearDown();
     }

tests/unit/workflow/engine/classes/model/ListInboxTest.php

@@ -15,7 +15,7 @@ class ListInboxTest extends TestCase
     /**
      * Set up method.
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
         $this->faker = Factory::create();
@@ -25,7 +25,7 @@ class ListInboxTest extends TestCase
     /**
      * Tear down method,
      */
-    public function tearDown()
+    public function tearDown(): void
     {
         parent::tearDown();
     }

tests/unit/workflow/engine/classes/model/ListMyInboxTest.php

@@ -15,7 +15,7 @@ class ListMyInboxTest extends TestCase
     /**
      * Set up method.
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
         $this->faker = Factory::create();
@@ -25,7 +25,7 @@ class ListMyInboxTest extends TestCase
     /**
      * Tear down method,
      */
-    public function tearDown()
+    public function tearDown(): void
     {
         parent::tearDown();
     }