fernando/luos
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HOR-1300 Performance Issue in PMFGroupList function

Browse Source
This commit is contained in:
Ronald Q
2016-06-23 14:03:56 -04:00
parent 7cbc64996a
commit 3cc18d73d7
2 changed files with 36 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
workflow/engine/classes/class.pmFunctions.php
View File

@@ -1897,20 +1897,20 @@ function PMFGenerateOutputDocument ($outputID, $sApplication = null, $index = nu
* @label PMF Group List * @label PMF Group List
* @link http://wiki.processmaker.com/index.php/ProcessMaker_Functions#PMFGroupList.28.29 * @link http://wiki.processmaker.com/index.php/ProcessMaker_Functions#PMFGroupList.28.29
* *
* @param string | $search = null | String to search | Optional parameter.
* @param int | $start = null | Start | Optional parameter.
* @param int | $limit = null | Limit | Optional parameter.
* @return array | $rows | List of groups | An array of groups * @return array | $rows | List of groups | An array of groups
* *
*/ */
function PMFGroupList () //its test was successfull function PMFGroupList ($search = null, $start = null, $limit = null) //its test was successfull
{ {
G::LoadClass( 'wsBase' ); G::LoadClass( 'wsBase' );
$ws = new wsBase(); $ws = new wsBase();
$result = $ws->groupList(); $result = $ws->groupList($search, $start, $limit);
$rows = Array (); $rows = array();
$i = 1;
if (isset( $result )) { if (isset( $result )) {
foreach ($result as $item) { $rows = array_combine(range(1, count($result)), array_values($result));
$rows[$i ++] = $item;
}
} }
return $rows; return $rows;
} }

49
workflow/engine/classes/class.wsBase.php
View File

@@ -229,32 +229,41 @@ class wsBase
/** /**
* get all groups * get all groups
* *
* @param none * @param null $search
* @return $result will return an object * @param null $start
* @param null $limit
* @return array|stdClass
*/ */
public function groupList () public function groupList($search = null, $start = null, $limit = null)
{ {
try { try {
$result = array (); $criteria = new Criteria('workflow');
$oCriteria = new Criteria( 'workflow' ); $criteria->addSelectColumn(GroupwfPeer::GRP_UID);
$oCriteria->add( GroupwfPeer::GRP_STATUS, 'ACTIVE' ); $criteria->addSelectColumn(GroupwfPeer::GRP_TITLE);
$oDataset = GroupwfPeer::doSelectRS( $oCriteria ); $criteria->add(GroupwfPeer::GRP_STATUS, 'ACTIVE');
$oDataset->setFetchmode( ResultSet::FETCHMODE_ASSOC ); $criteria->addAscendingOrderByColumn(GroupwfPeer::GRP_TITLE);
$oDataset->next(); if ($search) {
$criteria->add(GroupwfPeer::GRP_TITLE, $search, Criteria::EQUAL);
while ($aRow = $oDataset->getRow()) { $criteria->addOr(GroupwfPeer::GRP_TITLE, $search . '%', Criteria::LIKE);
$oGroupwf = new Groupwf(); $criteria->addOr(GroupwfPeer::GRP_TITLE, '%' . $search, Criteria::LIKE);
$arrayGroupwf = $oGroupwf->Load( $aRow['GRP_UID'] ); $criteria->addOr(GroupwfPeer::GRP_TITLE, '%' . $search . '%', Criteria::LIKE);
$result[] = array ('guid' => $aRow['GRP_UID'],'name' => $arrayGroupwf['GRP_TITLE'] }
); if ($start) {
$oDataset->next(); $criteria->setOffset($start);
}
if ($limit) {
$criteria->setLimit($limit);
}
$rs = GroupwfPeer::doSelectRS($criteria);
$rs->setFetchmode(ResultSet::FETCHMODE_ASSOC);
$result = array();
while ($rs->next()) {
$rows = $rs->getRow();
$result[] = array('guid' => $rows['GRP_UID'], 'name' => $rows['GRP_TITLE']);
} }
return $result; return $result;
} catch (Exception $e) { } catch (Exception $e) {
$result[] = array ('guid' => $e->getMessage(),'name' => $e->getMessage() $result[] = array('guid' => $e->getMessage(), 'name' => $e->getMessage());
);
return $result; return $result;
} }
} }