fernando/luos
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactoring streamJSTranslationFile to remove eval use

Browse Source
This commit is contained in:
IsaiDiaz
2025-06-27 11:11:25 -04:00
parent a4668fb5e3
commit 2cfcc84510
1 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
gulliver/system/class.bootstrap.php
View File

@@ -827,6 +827,11 @@ class Bootstrap
$typeName = trim($typeName); $typeName = trim($typeName);
$fileConst = ($typeName == 'translation') ? 'translation.' . $locale : 'translation.' . $typeName . '.' . $locale; $fileConst = ($typeName == 'translation') ? 'translation.' . $locale : 'translation.' . $typeName . '.' . $locale;
if (!preg_match('/^[a-zA-Z0-9_]+$/', $typeName)) {
error_log("Attempted to stream invalid translation type: " . $typeName);
return '';
}
if ($typeName == 'translation') { if ($typeName == 'translation') {
$defaultTranslations = array(); $defaultTranslations = array();
$foreignTranslations = array(); $foreignTranslations = array();
@@ -863,11 +868,16 @@ class Bootstrap
$newName = implode('.', $typearray); $newName = implode('.', $typearray);
if (file_exists(PATH_LANGUAGECONT . $newName)) { if (file_exists(PATH_LANGUAGECONT . $newName)) {
require_once(PATH_LANGUAGECONT . $newName); require_once(PATH_LANGUAGECONT . $newName);
$return = ''; $dynamicTranslationVarName = 'translation' . $typeName;
eval('$return = "var TRANSLATIONS_" . strtoupper($typeName) . " = " . Bootstrap::json_encode($translation' . $typeName . ') . ";";'); if (isset($$dynamicTranslationVarName) && is_array($$dynamicTranslationVarName)) {
return $return; $translationToEncode = $$dynamicTranslationVarName;
return 'var TRANSLATIONS_' . strtoupper($typeName) . ' = ' . Bootstrap::json_encode($translationToEncode) . ';';
} else {
error_log("Missing or invalid translation array for type: " . $typeName);
return '';
} }
return; }
return '';
} }
} }