fernando/luos
1
0
Fork 0
Code Releases Activity

Merged in bugfix/PMCORE-545 (pull request #7231)

Browse Source 
PMCORE-545 Public files in a process cannot be deleted (in Windows Server) when the process is imported

Approved-by: Julio Cesar Laura Avendaño <contact@julio-laura.com>
This commit is contained in:
Roly
2020-02-05 13:17:12 +00:00
committed by Julio Cesar Laura Avendaño
parent 25b123aff9 6a09fb6ddd
commit 0c2c343fdc
12 changed files with 386 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

208
tests/unit/workflow/engine/src/ProcessMaker/BusinessModel/FilesManagerTest.php Normal file
View File

@@ -0,0 +1,208 @@
<?php
namespace ProcessMaker\BusinessModel;
use Exception;
use Faker\Factory;
use G;
use ProcessMaker\BusinessModel\FilesManager;
use ProcessMaker\Model\EmailEvent as EmailEventModel;
use ProcessMaker\Model\Process as ProcessModel;
use ProcessMaker\Model\ProcessFiles as ProcessFilesModel;
use ProcessMaker\Model\User as UserModel;
use Tests\TestCase;
class FilesManagerTest extends TestCase
{
private $faker;
private $directories;
/**
* Set up method.
*/
public function setUp()
{
parent::setUp();
$this->faker = Factory::create();
$this->directories = [];
}
/**
* Tear down method.
*/
public function tearDown()
{
parent::tearDown();
$this->directories = array_reverse($this->directories);
foreach ($this->directories as $value) {
rmdir($value);
}
}
/**
* This test verifies if a file is missing.
* @test
* @covers \ProcessMaker\BusinessModel\FilesManager::deleteProcessFilesManager()
*/
public function it_should_deleted_public_files_when_not_exist()
{
$proUid = G::generateUniqueID();
$prfUid = G::generateUniqueID();
$filesManager = new FilesManager();
$this->expectException(Exception::class);
$filesManager->deleteProcessFilesManager($proUid, $prfUid);
}
/**
* This represents the windows and linux separators.
*/
public function directorySeparator()
{
return [
["linux", "/"],
["windows", "\\"]
];
}
/**
* This test verifies the deletion of a template.
* @test
* @covers \ProcessMaker\BusinessModel\FilesManager::deleteProcessFilesManager()
* @dataProvider directorySeparator
*/
public function it_should_deleted_a_template_file($type, $separator)
{
$user = factory(UserModel::class)->create([
'USR_UID' => G::generateUniqueID()
]);
$process = factory(ProcessModel::class)->create([
'PRO_UID' => G::generateUniqueID()
]);
//create a template file
$directory = PATH_DATA_SITE;
if (!is_dir($directory)) {
mkdir($directory);
$this->directories[] = $directory;
}
$directory = PATH_DATA_PUBLIC;
if (!is_dir($directory)) {
mkdir($directory);
$this->directories[] = $directory;
}
$directory = PATH_DATA_PUBLIC . $process->PRO_UID;
if (!is_dir($directory)) {
mkdir($directory);
$this->directories[] = $directory;
}
$fileName = "template1.html";
$path = $directory . "/" . $fileName;
file_put_contents($path, $this->faker->randomHtml());
$processFiles = factory(ProcessFilesModel::class)->create([
'PRF_UID' => G::generateUniqueID(),
'PRO_UID' => $process->PRO_UID,
'USR_UID' => $user->USR_UID,
'PRF_PATH' => $separator . $fileName
]);
$filesManager = new FilesManager();
$filesManager->deleteProcessFilesManager($process->PRO_UID, $processFiles->PRF_UID);
//assert empty registry
$expectedEmptyObject = ProcessFilesModel::where('PRF_UID', '=', $processFiles->PRF_UID)->first();
$this->assertTrue(empty($expectedEmptyObject));
//assert empty file
$this->assertTrue(!file_exists($path));
}
/**
* This test verifies the deletion of a public file.
* @test
* @covers \ProcessMaker\BusinessModel\FilesManager::deleteProcessFilesManager()
* @dataProvider directorySeparator
*/
public function it_should_deleted_a_public_file($type, $separator)
{
$user = factory(UserModel::class)->create([
'USR_UID' => G::generateUniqueID()
]);
$process = factory(ProcessModel::class)->create([
'PRO_UID' => G::generateUniqueID()
]);
//create a temporal file
$directory = PATH_DATA_SITE;
if (!is_dir($directory)) {
mkdir($directory);
$this->directories[] = $directory;
}
$directory = PATH_DATA_MAILTEMPLATES;
if (!is_dir($directory)) {
mkdir($directory);
$this->directories[] = $directory;
}
$directory = PATH_DATA_MAILTEMPLATES . $process->PRO_UID;
if (!is_dir($directory)) {
mkdir($directory);
$this->directories[] = $directory;
}
$fileName = "temporal.html";
$path = $directory . "/" . $fileName;
file_put_contents($path, $this->faker->randomHtml());
$processFiles = factory(ProcessFilesModel::class)->create([
'PRF_UID' => G::generateUniqueID(),
'PRO_UID' => $process->PRO_UID,
'USR_UID' => $user->USR_UID,
'PRF_PATH' => $separator . $fileName
]);
$filesManager = new FilesManager();
$filesManager->deleteProcessFilesManager($process->PRO_UID, $processFiles->PRF_UID);
//assert empty registry
$expectedEmptyObject = ProcessFilesModel::where('PRF_UID', '=', $processFiles->PRF_UID)->first();
$this->assertTrue(empty($expectedEmptyObject));
//assert empty file
$this->assertTrue(!file_exists($path));
}
/**
* This test verifies the removal of a template that is being used by an
* intermediate email event.
* @test
* @covers \ProcessMaker\BusinessModel\FilesManager::deleteProcessFilesManager()
*/
public function it_should_deleted_public_files_with_event_relation()
{
$user = factory(UserModel::class)->create([
'USR_UID' => G::generateUniqueID()
]);
$process = factory(ProcessModel::class)->create([
'PRO_UID' => G::generateUniqueID()
]);
$processFiles = factory(ProcessFilesModel::class)->create([
'PRF_UID' => G::generateUniqueID(),
'PRO_UID' => $process->PRO_UID,
'USR_UID' => $user->USR_UID,
'PRF_PATH' => '/'
]);
$emailEvent = factory(EmailEventModel::class)->create([
'PRF_UID' => $processFiles->PRF_UID
]);
$filesManager = new FilesManager();
$this->expectException(Exception::class);
$filesManager->deleteProcessFilesManager($process->PRO_UID, $processFiles->PRF_UID);
}
}