BUG 8977 Duplicidad de funciones en varios archivos... SOLVED

- was verified duplicate code.
- was removed codigo DEPRECATED.

workflow/engine/methods/cases/cases_StepToRevise.php

@@ -144,12 +144,10 @@ function setSelect()
 {
   var ex=<?=$_GET['ex']?>;
   try {
-    for(i=1; i<50; i++)
+    for(i=1; i<50; i++) {
-    {
       if (i == ex) {
         document.getElementById('focus'+i).innerHTML = '<img src="/images/bulletButton.gif" />';
-      }
+      } else {
-      else{
         document.getElementById('focus'+i).innerHTML = '';
       }
     }
@@ -157,42 +155,6 @@ function setSelect()
     return 0;
   }
 }
-
-function toRevisePanel(APP_UID,DEL_INDEX)
-{
-
-  oPanel = new leimnud.module.panel();
-  oPanel.options = {
-      size	:{w:250,h:450},
-      position:{x:0,y:0},
-      title	:'',
-      theme	:"processmaker",
-      statusBar:false,
-      control	:{resize:false,roll:false,close:false,drag:true},
-      fx	:{modal:false,opacity:true,blinkToFront:false,fadeIn:false,drag:true}
-  };
-  oPanel.events = {
-    remove: function() { delete(oPanel); }.extend(this)
-  };
-  oPanel.make();
-  oPanel.loader.show();
-
-  var oRPC = new leimnud.module.rpc.xmlhttp({
-      url : 'cases_Ajax',
-      method:'post',
-      args: 'action=toRevisePanel&APP_UID='+APP_UID+'&DEL_INDEX='+DEL_INDEX
-    });
-    oRPC.callback = function(rpc) {
-      oPanel.loader.hide();
-      oPanel.addContent(rpc.xmlhttp.responseText);
-      setSelect();
-
-    }.extend(this);
-  oRPC.make();
-}
-//toRevisePanel('<?=$_GET['APP_UID']?>','<?=$_GET['DEL_INDEX']?>');
-// DEPRECATED this JS section is marked for removal
-
 </script>
 
 

workflow/engine/methods/cases/cases_StepToReviseInputs.php

@@ -150,14 +150,11 @@ G::RenderPage('publish', 'blank');
 function setSelect()
 {
     var ex=<?=$_GET['ex']?>;
-
     try {
-		for(i=1; i<50; i++)
+        for (i=1; i<50; i++) {
-		{
             if (i == ex) {
                 document.getElementById('focus'+i).innerHTML = '<img src="/images/bulletButton.gif" />';
-			}
+            } else {
-			else{
                 document.getElementById('focus'+i).innerHTML = '';
             }
         }
@@ -165,40 +162,4 @@ function setSelect()
         return 0;
     }
 }
-
-function toRevisePanel(APP_UID,DEL_INDEX)
-{
-	oPanel = new leimnud.module.panel();
-	oPanel.options = {
-	    size	:{w:250,h:450},
-	  	position:{x:0,y:0},
-	  	title	:'',
-	  	theme	:"processmaker",
-	  	statusBar:false,
-	  	control	:{resize:false,roll:false,close:false,drag:true},
-	    fx	:{modal:false,opacity:true,blinkToFront:false,fadeIn:false,drag:true}
-  	};
-  	oPanel.events = {
-  		remove: function() { delete(oPanel); }.extend(this)
-  	};
-	oPanel.make();
-	oPanel.loader.show();
-
-	var oRPC = new leimnud.module.rpc.xmlhttp({
-	  	url : 'cases_Ajax',
-	  	method:'post',
-	  	args: 'action=toRevisePanel&APP_UID='+APP_UID+'&DEL_INDEX='+DEL_INDEX
-  	});
-    oRPC.callback = function(rpc) {
-	  	oPanel.loader.hide();
-	  	oPanel.addContent(rpc.xmlhttp.responseText);
-	  	//setSelect();
-
-  	}.extend(this);
-	oRPC.make();
-}
-//Deprecated Section since the interface are now movig to ExtJS
-//Remove this Jscript code
-//toRevisePanel('<?=$_GET['APP_UID']?>','<?=$_GET['DEL_INDEX']?>');
-
 </script>

workflow/engine/methods/cases/cases_StepToReviseOutputs.php

@@ -81,14 +81,11 @@ if(!isset($_GET['ex'])) $_GET['ex']=0;
 function setSelect()
 {
     var ex=<?=$_GET['ex']?>;
-	
     try{
-		for(i=1; i<50; i++)
+        for (i=1; i<50; i++) {
-		{
             if (i == ex) {
                 document.getElementById('focus'+i).innerHTML = '<img src="/images/bulletButton.gif" />';
-			}
+            } else {
-			else{			
                 document.getElementById('focus'+i).innerHTML = '';
             }
         }
@@ -96,38 +93,4 @@ function setSelect()
         return 0;
     }
 }
-//Deprecated Section since the interface are now movig to ExtJS
-function toRevisePanel(APP_UID,DEL_INDEX)
-{
-	oPanel = new leimnud.module.panel();
-	oPanel.options = {
-	  	size	:{w:250,h:450},
-	  	position:{x:0,y:0},
-	  	title	:'',
-	  	theme	:"processmaker",
-	  	statusBar:false,
-	  	control	:{resize:false,roll:false,close:false,drag:true},
-	  	fx	:{modal:false,opacity:true,blinkToFront:false,fadeIn:false,drag:true}
-  	};
-  	oPanel.events = {
-  		remove: function() { delete(oPanel); }.extend(this)
-  	};
-	oPanel.make();
-	oPanel.loader.show();
-
-	var oRPC = new leimnud.module.rpc.xmlhttp({
-	  	url : 'cases_Ajax',
-	  	method:'post',
-	  	args: 'action=toRevisePanel&APP_UID='+APP_UID+'&DEL_INDEX='+DEL_INDEX
-  	});
-    oRPC.callback = function(rpc) {
-	  	oPanel.loader.hide();
-	  	oPanel.addContent(rpc.xmlhttp.responseText);
-	  	setSelect();
-
-  	}.extend(this);
-	oRPC.make();
-}
-
-//toRevisePanel('<?=$_GET['APP_UID']?>','<?=$_GET['DEL_INDEX']?>');
 </script>